* [PATCH 1/1] ASoC: dwc: correct irq clear method
@ 2015-10-02 7:18 Yitian Bu
0 siblings, 0 replies; 2+ messages in thread
From: Yitian Bu @ 2015-10-02 7:18 UTC (permalink / raw)
To: yitian.bu, buyit, lgirdwood, broonie, perex, tiwai, Andrew.Jackson, wsa
Cc: alsa-devel, linux-kernel, linux-arm-kernel
from Designware I2S datasheet, tx/rx XRUN irq is cleared by
reading register TOR/ROR, rather than by writing into them.
Signed-off-by: Yitian Bu <yitian.bu@tangramtek.com>
---
sound/soc/dwc/designware_i2s.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
index a3e97b4..0d28e3b 100644
--- a/sound/soc/dwc/designware_i2s.c
+++ b/sound/soc/dwc/designware_i2s.c
@@ -131,10 +131,10 @@ static inline void i2s_clear_irqs(struct dw_i2s_dev *dev, u32 stream)
if (stream == SNDRV_PCM_STREAM_PLAYBACK) {
for (i = 0; i < 4; i++)
- i2s_write_reg(dev->i2s_base, TOR(i), 0);
+ i2s_read_reg(dev->i2s_base, TOR(i));
} else {
for (i = 0; i < 4; i++)
- i2s_write_reg(dev->i2s_base, ROR(i), 0);
+ i2s_read_reg(dev->i2s_base, ROR(i));
}
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 1/1] ASoc: dwc: correct irq clear method
@ 2015-09-28 6:20 yitian
0 siblings, 0 replies; 2+ messages in thread
From: yitian @ 2015-09-28 6:20 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, Andrew.Jackson, wsa
Cc: alsa-devel, linux-kernel, linux-arm-kernel
from Designware I2S datasheet, irq is cleared by reading from
TOR/ROR registers, rather than by writing into them.
Signed-off-by: Yitian Bu <yitian.bu@tangramtek.com>
---
sound/soc/dwc/designware_i2s.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
index a3e97b4..0d28e3b 100644
--- a/sound/soc/dwc/designware_i2s.c
+++ b/sound/soc/dwc/designware_i2s.c
@@ -131,10 +131,10 @@ static inline void i2s_clear_irqs(struct dw_i2s_dev
*dev, u32 stream)
if (stream == SNDRV_PCM_STREAM_PLAYBACK) {
for (i = 0; i < 4; i++)
- i2s_write_reg(dev->i2s_base, TOR(i), 0);
+ i2s_read_reg(dev->i2s_base, TOR(i));
} else {
for (i = 0; i < 4; i++)
- i2s_write_reg(dev->i2s_base, ROR(i), 0);
+ i2s_read_reg(dev->i2s_base, ROR(i));
}
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-02 7:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-02 7:18 [PATCH 1/1] ASoC: dwc: correct irq clear method Yitian Bu
-- strict thread matches above, loose matches on Subject: below --
2015-09-28 6:20 [PATCH 1/1] ASoc: " yitian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).