* [PATCH RT 0/4] Warning fixes for PREEMPT_RT
@ 2015-10-06 2:41 Ben Hutchings
2015-10-06 2:55 ` [PATCH RT 1/4] KVM: lapic: Fix name of timer handler before 3.7 Ben Hutchings
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Ben Hutchings @ 2015-10-06 2:41 UTC (permalink / raw)
To: linux-kernel; +Cc: stable-rt
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
These patches fix various warnings I got when building 3.2.71-rt104;
some of them are applicable to other RT branches as well.
Ben.
Ben Hutchings (4):
KVM: lapic: Fix name of timer handler before 3.7
rtmutex: Fix rt_mutex_timed_fastlock() slowfn type mismatch up to 3.10
genirq: Fix pointer cast warning for randomness on 32-bit
architectures
work-simple: Add missing #include <linux/export.h>
arch/x86/kvm/lapic.c | 4 +---
kernel/irq/manage.c | 3 ++-
kernel/rtmutex.c | 2 +-
kernel/work-simple.c | 1 +
4 files changed, 5 insertions(+), 5 deletions(-)
--
Ben Hutchings
All the simple programs have been written, and all the good names taken.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH RT 1/4] KVM: lapic: Fix name of timer handler before 3.7
2015-10-06 2:41 [PATCH RT 0/4] Warning fixes for PREEMPT_RT Ben Hutchings
@ 2015-10-06 2:55 ` Ben Hutchings
2015-10-06 2:55 ` [PATCH RT 2/4] rtmutex: Fix rt_mutex_timed_fastlock() slowfn type mismatch up to 3.10 Ben Hutchings
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Ben Hutchings @ 2015-10-06 2:55 UTC (permalink / raw)
To: linux-kernel; +Cc: stable-rt
[-- Attachment #1: Type: text/plain, Size: 945 bytes --]
The timer handler was named kvm_timer_fn, not apic_timer_fn, before
Linux 3.7.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: <stable-rt@vger.kernel.org> # 3.2 3.4
---
arch/x86/kvm/lapic.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
index 7198be0..c661909 100644
--- a/arch/x86/kvm/lapic.c
+++ b/arch/x86/kvm/lapic.c
@@ -680,15 +680,13 @@ static void update_divide_count(struct kvm_lapic *apic)
}
-static enum hrtimer_restart apic_timer_fn(struct hrtimer *data);
-
static void apic_timer_expired(struct hrtimer *data)
{
int ret, i = 0;
enum hrtimer_restart r;
struct kvm_timer *ktimer = container_of(data, struct kvm_timer, timer);
- r = apic_timer_fn(data);
+ r = kvm_timer_fn(data);
if (r == HRTIMER_RESTART) {
do {
--
Ben Hutchings
All the simple programs have been written, and all the good names taken.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH RT 2/4] rtmutex: Fix rt_mutex_timed_fastlock() slowfn type mismatch up to 3.10
2015-10-06 2:41 [PATCH RT 0/4] Warning fixes for PREEMPT_RT Ben Hutchings
2015-10-06 2:55 ` [PATCH RT 1/4] KVM: lapic: Fix name of timer handler before 3.7 Ben Hutchings
@ 2015-10-06 2:55 ` Ben Hutchings
2015-10-06 2:55 ` [PATCH RT 3/4] genirq: Fix pointer cast warning for randomness on 32-bit architectures Ben Hutchings
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Ben Hutchings @ 2015-10-06 2:55 UTC (permalink / raw)
To: linux-kernel; +Cc: stable-rt
[-- Attachment #1: Type: text/plain, Size: 1721 bytes --]
The type of the slowfn parameter is declared incorrectly in some of
the backports, resulting in:
kernel/rtmutex.c: In function 'rt_mutex_timed_futex_lock':
kernel/rtmutex.c:1730:12: warning: passing argument 5 of 'rt_mutex_timed_fastlock' from incompatible pointer type [enabled by default]
kernel/rtmutex.c:1655:1: note: expected 'int (*)(struct rt_mutex *, int, struct hrtimer_sleeper *, int)' but argument is of type 'int (*)(struct rt_mutex *, int, struct hrtimer_sleeper *, enum rtmutex_chainwalk)'
kernel/rtmutex.c: In function 'rt_mutex_timed_lock':
kernel/rtmutex.c:1770:12: warning: passing argument 5 of 'rt_mutex_timed_fastlock' from incompatible pointer type [enabled by default]
kernel/rtmutex.c:1655:1: note: expected 'int (*)(struct rt_mutex *, int, struct hrtimer_sleeper *, int)' but argument is of type 'int (*)(struct rt_mutex *, int, struct hrtimer_sleeper *, enum rtmutex_chainwalk)'
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: <stable-rt@vger.kernel.org> # 3.2 3.4 3.10
---
kernel/rtmutex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rtmutex.c b/kernel/rtmutex.c
index 52cab27..26550b6 100644
--- a/kernel/rtmutex.c
+++ b/kernel/rtmutex.c
@@ -1657,7 +1657,7 @@ rt_mutex_timed_fastlock(struct rt_mutex *lock, int state,
enum rtmutex_chainwalk chwalk,
int (*slowfn)(struct rt_mutex *lock, int state,
struct hrtimer_sleeper *timeout,
- int detect_deadlock))
+ enum rtmutex_chainwalk chwalk))
{
if (chwalk == RT_MUTEX_MIN_CHAINWALK &&
likely(rt_mutex_cmpxchg(lock, NULL, current))) {
--
Ben Hutchings
All the simple programs have been written, and all the good names taken.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH RT 3/4] genirq: Fix pointer cast warning for randomness on 32-bit architectures
2015-10-06 2:41 [PATCH RT 0/4] Warning fixes for PREEMPT_RT Ben Hutchings
2015-10-06 2:55 ` [PATCH RT 1/4] KVM: lapic: Fix name of timer handler before 3.7 Ben Hutchings
2015-10-06 2:55 ` [PATCH RT 2/4] rtmutex: Fix rt_mutex_timed_fastlock() slowfn type mismatch up to 3.10 Ben Hutchings
@ 2015-10-06 2:55 ` Ben Hutchings
2015-10-06 2:55 ` [PATCH RT 4/4] work-simple: Add missing #include <linux/export.h> Ben Hutchings
2015-11-21 0:20 ` [PATCH RT 0/4] Warning fixes for PREEMPT_RT Ben Hutchings
4 siblings, 0 replies; 7+ messages in thread
From: Ben Hutchings @ 2015-10-06 2:55 UTC (permalink / raw)
To: linux-kernel; +Cc: stable-rt
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
gcc warns about casting directly from a 32-bit pointer to u64. In the
current rt patch series we cast to unsigned long to avoid the warning,
but this fix hasn't been backported to all versions.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: <stable-rt@vger.kernel.org> # 3.2 3.4
---
kernel/irq/manage.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index e4549b2..964cf41 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -897,7 +897,8 @@ static int irq_thread(void *data)
#ifdef CONFIG_PREEMPT_RT_FULL
migrate_disable();
add_interrupt_randomness(action->irq, 0,
- desc->random_ip ^ (u64) action);
+ desc->random_ip ^
+ (unsigned long) action);
migrate_enable();
#endif
}
--
Ben Hutchings
All the simple programs have been written, and all the good names taken.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH RT 4/4] work-simple: Add missing #include <linux/export.h>
2015-10-06 2:41 [PATCH RT 0/4] Warning fixes for PREEMPT_RT Ben Hutchings
` (2 preceding siblings ...)
2015-10-06 2:55 ` [PATCH RT 3/4] genirq: Fix pointer cast warning for randomness on 32-bit architectures Ben Hutchings
@ 2015-10-06 2:55 ` Ben Hutchings
2015-11-21 0:20 ` [PATCH RT 0/4] Warning fixes for PREEMPT_RT Ben Hutchings
4 siblings, 0 replies; 7+ messages in thread
From: Ben Hutchings @ 2015-10-06 2:55 UTC (permalink / raw)
To: linux-kernel; +Cc: stable-rt
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
work-simple.c uses EXPORT_SYMBOL_GPL(), defined in <linux/export.h>.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: stable-rt@vger.kernel.org
---
kernel/work-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/work-simple.c b/kernel/work-simple.c
index c996f75..e57a052 100644
--- a/kernel/work-simple.c
+++ b/kernel/work-simple.c
@@ -10,6 +10,7 @@
#include <linux/kthread.h>
#include <linux/slab.h>
#include <linux/spinlock.h>
+#include <linux/export.h>
#define SWORK_EVENT_PENDING (1 << 0)
--
Ben Hutchings
All the simple programs have been written, and all the good names taken.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH RT 0/4] Warning fixes for PREEMPT_RT
2015-10-06 2:41 [PATCH RT 0/4] Warning fixes for PREEMPT_RT Ben Hutchings
` (3 preceding siblings ...)
2015-10-06 2:55 ` [PATCH RT 4/4] work-simple: Add missing #include <linux/export.h> Ben Hutchings
@ 2015-11-21 0:20 ` Ben Hutchings
2015-11-23 14:36 ` Steven Rostedt
4 siblings, 1 reply; 7+ messages in thread
From: Ben Hutchings @ 2015-11-21 0:20 UTC (permalink / raw)
To: linux-kernel; +Cc: stable-rt
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On Tue, 2015-10-06 at 03:41 +0100, Ben Hutchings wrote:
> These patches fix various warnings I got when building 3.2.71-rt104;
> some of them are applicable to other RT branches as well.
Ping.
Ben.
> Ben.
>
> Ben Hutchings (4):
> KVM: lapic: Fix name of timer handler before 3.7
> rtmutex: Fix rt_mutex_timed_fastlock() slowfn type mismatch up to 3.10
> genirq: Fix pointer cast warning for randomness on 32-bit
> architectures
> work-simple: Add missing #include
>
> arch/x86/kvm/lapic.c | 4 +---
> kernel/irq/manage.c | 3 ++-
> kernel/rtmutex.c | 2 +-
> kernel/work-simple.c | 1 +
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
--
Ben Hutchings
friends: People who know you well, but like you anyway.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RT 0/4] Warning fixes for PREEMPT_RT
2015-11-21 0:20 ` [PATCH RT 0/4] Warning fixes for PREEMPT_RT Ben Hutchings
@ 2015-11-23 14:36 ` Steven Rostedt
0 siblings, 0 replies; 7+ messages in thread
From: Steven Rostedt @ 2015-11-23 14:36 UTC (permalink / raw)
To: Ben Hutchings; +Cc: linux-kernel, stable-rt
On Sat, 21 Nov 2015 00:20:41 +0000
Ben Hutchings <ben@decadent.org.uk> wrote:
> On Tue, 2015-10-06 at 03:41 +0100, Ben Hutchings wrote:
> > These patches fix various warnings I got when building 3.2.71-rt104;
> > some of them are applicable to other RT branches as well.
>
> Ping.
>
Sorry, I've been behind in reading this list. I'll take a look at this.
Thanks,
-- Steve
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-11-23 14:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-06 2:41 [PATCH RT 0/4] Warning fixes for PREEMPT_RT Ben Hutchings
2015-10-06 2:55 ` [PATCH RT 1/4] KVM: lapic: Fix name of timer handler before 3.7 Ben Hutchings
2015-10-06 2:55 ` [PATCH RT 2/4] rtmutex: Fix rt_mutex_timed_fastlock() slowfn type mismatch up to 3.10 Ben Hutchings
2015-10-06 2:55 ` [PATCH RT 3/4] genirq: Fix pointer cast warning for randomness on 32-bit architectures Ben Hutchings
2015-10-06 2:55 ` [PATCH RT 4/4] work-simple: Add missing #include <linux/export.h> Ben Hutchings
2015-11-21 0:20 ` [PATCH RT 0/4] Warning fixes for PREEMPT_RT Ben Hutchings
2015-11-23 14:36 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).