* [PATCH] h8300: Fix build error due to missing word-at-a-time.h
@ 2015-10-06 5:32 Guenter Roeck
2015-10-07 13:41 ` Chris Metcalf
2015-10-08 7:49 ` Yoshinori Sato
0 siblings, 2 replies; 6+ messages in thread
From: Guenter Roeck @ 2015-10-06 5:32 UTC (permalink / raw)
To: Yoshinori Sato
Cc: uclinux-h8-devel, linux-kernel, Guenter Roeck, Chris Metcalf
h8300 builds fail with
lib/string.c:31:32: fatal error: asm/word-at-a-time.h: No such file or directory
Fixes: 30035e45753b ("string: provide strscpy()")
Cc: Chris Metcalf <cmetcalf@ezchip.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/h8300/include/asm/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/h8300/include/asm/Kbuild b/arch/h8300/include/asm/Kbuild
index 70e6ae1e7006..373cb23301e3 100644
--- a/arch/h8300/include/asm/Kbuild
+++ b/arch/h8300/include/asm/Kbuild
@@ -73,4 +73,5 @@ generic-y += uaccess.h
generic-y += ucontext.h
generic-y += unaligned.h
generic-y += vga.h
+generic-y += word-at-a-time.h
generic-y += xor.h
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] h8300: Fix build error due to missing word-at-a-time.h
2015-10-06 5:32 [PATCH] h8300: Fix build error due to missing word-at-a-time.h Guenter Roeck
@ 2015-10-07 13:41 ` Chris Metcalf
2015-10-07 16:35 ` Guenter Roeck
2015-10-08 7:49 ` Yoshinori Sato
1 sibling, 1 reply; 6+ messages in thread
From: Chris Metcalf @ 2015-10-07 13:41 UTC (permalink / raw)
To: Guenter Roeck, Yoshinori Sato; +Cc: uclinux-h8-devel, linux-kernel
On 10/06/2015 01:32 AM, Guenter Roeck wrote:
> h8300 builds fail with
>
> lib/string.c:31:32: fatal error: asm/word-at-a-time.h: No such file or directory
>
> Fixes: 30035e45753b ("string: provide strscpy()")
> Cc: Chris Metcalf <cmetcalf@ezchip.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/h8300/include/asm/Kbuild | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Chris Metcalf <cmetcalf@ezchip.com>
--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] h8300: Fix build error due to missing word-at-a-time.h
2015-10-07 13:41 ` Chris Metcalf
@ 2015-10-07 16:35 ` Guenter Roeck
2015-10-07 17:03 ` Chris Metcalf
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2015-10-07 16:35 UTC (permalink / raw)
To: Chris Metcalf; +Cc: linux-kernel
On 10/07/2015 06:41 AM, Chris Metcalf wrote:
> On 10/06/2015 01:32 AM, Guenter Roeck wrote:
>> h8300 builds fail with
>>
>> lib/string.c:31:32: fatal error: asm/word-at-a-time.h: No such file or directory
>>
>> Fixes: 30035e45753b ("string: provide strscpy()")
>> Cc: Chris Metcalf <cmetcalf@ezchip.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> arch/h8300/include/asm/Kbuild | 1 +
>> 1 file changed, 1 insertion(+)
>
> Acked-by: Chris Metcalf <cmetcalf@ezchip.com>
>
lib/string.c: In function 'strscpy':
lib/string.c:209:4: error: implicit declaration of function 'zero_bytemask' [-Werror=implicit-function-declaration]
*(unsigned long *)(dest+res) = c & zero_bytemask(data);
Now seen upstream for all powerpc builds. Seems to be due to
'strscpy: zero any trailing garbage bytes in the destination'.
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] h8300: Fix build error due to missing word-at-a-time.h
2015-10-07 16:35 ` Guenter Roeck
@ 2015-10-07 17:03 ` Chris Metcalf
0 siblings, 0 replies; 6+ messages in thread
From: Chris Metcalf @ 2015-10-07 17:03 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-kernel
On 10/7/2015 12:35 PM, Guenter Roeck wrote:
> lib/string.c: In function 'strscpy':
> lib/string.c:209:4: error: implicit declaration of function 'zero_bytemask' [-Werror=implicit-function-declaration]
> *(unsigned long *)(dest+res) = c & zero_bytemask(data);
>
> Now seen upstream for all powerpc builds. Seems to be due to
> 'strscpy: zero any trailing garbage bytes in the destination'.
See:
http://lkml.kernel.org/r/1444229188-19640-1-git-send-email-cmetcalf@ezchip.com
--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] h8300: Fix build error due to missing word-at-a-time.h
2015-10-06 5:32 [PATCH] h8300: Fix build error due to missing word-at-a-time.h Guenter Roeck
2015-10-07 13:41 ` Chris Metcalf
@ 2015-10-08 7:49 ` Yoshinori Sato
2015-10-08 12:36 ` Guenter Roeck
1 sibling, 1 reply; 6+ messages in thread
From: Yoshinori Sato @ 2015-10-08 7:49 UTC (permalink / raw)
To: Guenter Roeck; +Cc: uclinux-h8-devel, linux-kernel, Chris Metcalf
On Tue, 06 Oct 2015 14:32:58 +0900,
Guenter Roeck wrote:
>
> h8300 builds fail with
>
> lib/string.c:31:32: fatal error: asm/word-at-a-time.h: No such file or directory
>
> Fixes: 30035e45753b ("string: provide strscpy()")
> Cc: Chris Metcalf <cmetcalf@ezchip.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/h8300/include/asm/Kbuild | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/h8300/include/asm/Kbuild b/arch/h8300/include/asm/Kbuild
> index 70e6ae1e7006..373cb23301e3 100644
> --- a/arch/h8300/include/asm/Kbuild
> +++ b/arch/h8300/include/asm/Kbuild
> @@ -73,4 +73,5 @@ generic-y += uaccess.h
> generic-y += ucontext.h
> generic-y += unaligned.h
> generic-y += vga.h
> +generic-y += word-at-a-time.h
> generic-y += xor.h
> --
> 2.1.4
>
Merged in my tree.
Thanks.
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] h8300: Fix build error due to missing word-at-a-time.h
2015-10-08 7:49 ` Yoshinori Sato
@ 2015-10-08 12:36 ` Guenter Roeck
0 siblings, 0 replies; 6+ messages in thread
From: Guenter Roeck @ 2015-10-08 12:36 UTC (permalink / raw)
To: Yoshinori Sato; +Cc: uclinux-h8-devel, linux-kernel, Chris Metcalf
On 10/08/2015 12:49 AM, Yoshinori Sato wrote:
> On Tue, 06 Oct 2015 14:32:58 +0900,
> Guenter Roeck wrote:
>>
>> h8300 builds fail with
>>
>> lib/string.c:31:32: fatal error: asm/word-at-a-time.h: No such file or directory
>>
>> Fixes: 30035e45753b ("string: provide strscpy()")
>> Cc: Chris Metcalf <cmetcalf@ezchip.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> arch/h8300/include/asm/Kbuild | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/h8300/include/asm/Kbuild b/arch/h8300/include/asm/Kbuild
>> index 70e6ae1e7006..373cb23301e3 100644
>> --- a/arch/h8300/include/asm/Kbuild
>> +++ b/arch/h8300/include/asm/Kbuild
>> @@ -73,4 +73,5 @@ generic-y += uaccess.h
>> generic-y += ucontext.h
>> generic-y += unaligned.h
>> generic-y += vga.h
>> +generic-y += word-at-a-time.h
>> generic-y += xor.h
>> --
>> 2.1.4
>>
>
> Merged in my tree.
> Thanks.
>
Chris already applied and pushed a different patch.
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-08 12:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-06 5:32 [PATCH] h8300: Fix build error due to missing word-at-a-time.h Guenter Roeck
2015-10-07 13:41 ` Chris Metcalf
2015-10-07 16:35 ` Guenter Roeck
2015-10-07 17:03 ` Chris Metcalf
2015-10-08 7:49 ` Yoshinori Sato
2015-10-08 12:36 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).