* [PATCH 0/1] ARM: meson: Add status LED for Odroid-C1
@ 2015-10-09 14:37 Edward Cragg
2015-10-09 14:37 ` [PATCH 1/1] " Edward Cragg
0 siblings, 1 reply; 5+ messages in thread
From: Edward Cragg @ 2015-10-09 14:37 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Carlo Caione, devicetree, linux-kernel
Add status LED for Hardkernel Odroid-C1 development board
Edward Cragg (1):
ARM: meson: Add status LED for Odroid-C1
arch/arm/boot/dts/meson8b-odroidc1.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
--
2.5.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] ARM: meson: Add status LED for Odroid-C1
2015-10-09 14:37 [PATCH 0/1] ARM: meson: Add status LED for Odroid-C1 Edward Cragg
@ 2015-10-09 14:37 ` Edward Cragg
2015-10-12 19:15 ` Carlo Caione
2015-10-30 17:55 ` Edward Cragg
0 siblings, 2 replies; 5+ messages in thread
From: Edward Cragg @ 2015-10-09 14:37 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, Carlo Caione, devicetree, linux-kernel
Add the blue status LED to the Hardkernel Odroid C1 board DTS.
This is the only programmable LED on the board.
Signed-off-by: Edward Cragg <edward.cragg@codethink.co.uk>
---
arch/arm/boot/dts/meson8b-odroidc1.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index a8e2911..3b03523 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -1,6 +1,8 @@
/*
* Copyright 2015 Endless Mobile, Inc.
* Author: Carlo Caione <carlo@endlessm.com>
+ * Copyright 2015 Codethink Ltd.
+ * Author: Edward Cragg <edward.cragg@codethink.co.uk>
*
* This file is dual-licensed: you can use it either under the terms
* of the GPL or the X11 license, at your option. Note that this dual
@@ -46,6 +48,7 @@
/dts-v1/;
#include "meson8b.dtsi"
+#include <dt-bindings/gpio/gpio.h>
/ {
model = "Hardkernel ODROID-C1";
@@ -58,6 +61,16 @@
memory {
reg = <0x40000000 0x40000000>;
};
+
+ leds {
+ compatible = "gpio-leds";
+ blue {
+ label = "c1:blue:alive";
+ gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
+ linux,default-trigger = "heartbeat";
+ default-state = "off";
+ };
+ };
};
&uart_AO {
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] ARM: meson: Add status LED for Odroid-C1
2015-10-09 14:37 ` [PATCH 1/1] " Edward Cragg
@ 2015-10-12 19:15 ` Carlo Caione
2015-10-30 17:55 ` Edward Cragg
1 sibling, 0 replies; 5+ messages in thread
From: Carlo Caione @ 2015-10-12 19:15 UTC (permalink / raw)
To: Edward Cragg
Cc: linux-arm-kernel, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King, Carlo Caione, devicetree,
linux-kernel
On Fri, Oct 9, 2015 at 4:37 PM, Edward Cragg
<edward.cragg@codethink.co.uk> wrote:
> Add the blue status LED to the Hardkernel Odroid C1 board DTS.
> This is the only programmable LED on the board.
>
> Signed-off-by: Edward Cragg <edward.cragg@codethink.co.uk>
> ---
> arch/arm/boot/dts/meson8b-odroidc1.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
> index a8e2911..3b03523 100644
> --- a/arch/arm/boot/dts/meson8b-odroidc1.dts
> +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
> @@ -1,6 +1,8 @@
> /*
> * Copyright 2015 Endless Mobile, Inc.
> * Author: Carlo Caione <carlo@endlessm.com>
> + * Copyright 2015 Codethink Ltd.
> + * Author: Edward Cragg <edward.cragg@codethink.co.uk>
Usually we do not add a copyright line for each small addition to the DTS.
> *
> * This file is dual-licensed: you can use it either under the terms
> * of the GPL or the X11 license, at your option. Note that this dual
> @@ -46,6 +48,7 @@
>
> /dts-v1/;
> #include "meson8b.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> model = "Hardkernel ODROID-C1";
> @@ -58,6 +61,16 @@
> memory {
> reg = <0x40000000 0x40000000>;
> };
> +
> + leds {
> + compatible = "gpio-leds";
> + blue {
> + label = "c1:blue:alive";
> + gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "heartbeat";
> + default-state = "off";
> + };
> + };
> };
otherwise Acked-by: Carlo Caione <carlo@endlessm.com>
--
Carlo Caione
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] ARM: meson: Add status LED for Odroid-C1
2015-10-09 14:37 ` [PATCH 1/1] " Edward Cragg
2015-10-12 19:15 ` Carlo Caione
@ 2015-10-30 17:55 ` Edward Cragg
2015-10-30 18:13 ` Carlo Caione
1 sibling, 1 reply; 5+ messages in thread
From: Edward Cragg @ 2015-10-30 17:55 UTC (permalink / raw)
To: Edward Cragg
Cc: linux-arm-kernel, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King, Carlo Caione, devicetree,
linux-kernel
On Fri, Oct 09, 2015 at 03:37:10PM +0100, Edward Cragg wrote:
> Add the blue status LED to the Hardkernel Odroid C1 board DTS.
> This is the only programmable LED on the board.
>
> Signed-off-by: Edward Cragg <edward.cragg@codethink.co.uk>
> ---
> arch/arm/boot/dts/meson8b-odroidc1.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
Hi, has anyone had a chance to have a look at this yet?
I originally forgot to add that this patch is dependent on:
[PATCH v2 0/4] Add support for Amlogic Meson8b and couple of boards
which has already been accepted.
Ed
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] ARM: meson: Add status LED for Odroid-C1
2015-10-30 17:55 ` Edward Cragg
@ 2015-10-30 18:13 ` Carlo Caione
0 siblings, 0 replies; 5+ messages in thread
From: Carlo Caione @ 2015-10-30 18:13 UTC (permalink / raw)
To: Edward Cragg
Cc: linux-arm-kernel, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Russell King, Carlo Caione, devicetree,
linux-kernel
On Fri, Oct 30, 2015 at 6:55 PM, Edward Cragg
<edward.cragg@codethink.co.uk> wrote:
> On Fri, Oct 09, 2015 at 03:37:10PM +0100, Edward Cragg wrote:
>> Add the blue status LED to the Hardkernel Odroid C1 board DTS.
>> This is the only programmable LED on the board.
>>
>> Signed-off-by: Edward Cragg <edward.cragg@codethink.co.uk>
>> ---
>> arch/arm/boot/dts/meson8b-odroidc1.dts | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>
> Hi, has anyone had a chance to have a look at this yet?
Yes, I already replied to you on Oct 12.
I was waiting for a resubmission without the added copyright but I'll
modify it myself and I'll push a PR.
Cheers,
--
Carlo Caione
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-30 18:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-09 14:37 [PATCH 0/1] ARM: meson: Add status LED for Odroid-C1 Edward Cragg
2015-10-09 14:37 ` [PATCH 1/1] " Edward Cragg
2015-10-12 19:15 ` Carlo Caione
2015-10-30 17:55 ` Edward Cragg
2015-10-30 18:13 ` Carlo Caione
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).