* [PATCH] NFC: nfcwilink: Drop a useless static qualifier
@ 2015-10-13 6:31 Christophe JAILLET
2015-10-20 4:50 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2015-10-13 6:31 UTC (permalink / raw)
To: lauro.venancio, aloisio.almeida, sameo
Cc: linux-wireless, linux-kernel, Christophe JAILLET
There is no need to have the 'struct nfcwilink *drv' variable static in the
probe function.
It only wastes a few bytes of memory.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/nfc/nfcwilink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nfc/nfcwilink.c b/drivers/nfc/nfcwilink.c
index ce2e2cf..f81e500 100644
--- a/drivers/nfc/nfcwilink.c
+++ b/drivers/nfc/nfcwilink.c
@@ -497,7 +497,7 @@ static struct nci_ops nfcwilink_ops = {
static int nfcwilink_probe(struct platform_device *pdev)
{
- static struct nfcwilink *drv;
+ struct nfcwilink *drv;
int rc;
__u32 protocols;
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NFC: nfcwilink: Drop a useless static qualifier
2015-10-13 6:31 [PATCH] NFC: nfcwilink: Drop a useless static qualifier Christophe JAILLET
@ 2015-10-20 4:50 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2015-10-20 4:50 UTC (permalink / raw)
To: Christophe JAILLET
Cc: lauro.venancio, aloisio.almeida, linux-wireless, linux-kernel
Hi Christophe,
On Tue, Oct 13, 2015 at 08:31:04AM +0200, Christophe JAILLET wrote:
> There is no need to have the 'struct nfcwilink *drv' variable static in the
> probe function.
> It only wastes a few bytes of memory.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/nfc/nfcwilink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks a lot.
Cheers,
Samuel.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-20 4:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-13 6:31 [PATCH] NFC: nfcwilink: Drop a useless static qualifier Christophe JAILLET
2015-10-20 4:50 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).