* [PATCH] scsi: wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE
@ 2015-10-21 22:23 Muhammad Falak R Wani
2015-10-22 7:22 ` Johannes Thumshirn
2015-10-22 11:32 ` Vaishali Thakkar
0 siblings, 2 replies; 3+ messages in thread
From: Muhammad Falak R Wani @ 2015-10-21 22:23 UTC (permalink / raw)
To: James E.J. Bottomley, linux-scsi, linux-kernel
Cc: Ondrej Zary, Muhammad Falak R Wani
Use struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
the goal of getting rid of this macro completely, as this macro
is deprecated.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/scsi/wd719x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
index e3da1a2..2a9da2e 100644
--- a/drivers/scsi/wd719x.c
+++ b/drivers/scsi/wd719x.c
@@ -962,7 +962,7 @@ static void wd719x_pci_remove(struct pci_dev *pdev)
scsi_host_put(sh);
}
-static DEFINE_PCI_DEVICE_TABLE(wd719x_pci_table) = {
+static const struct pci_device_id wd719x_pci_table[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_WD, 0x3296) },
{}
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE
2015-10-21 22:23 [PATCH] scsi: wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE Muhammad Falak R Wani
@ 2015-10-22 7:22 ` Johannes Thumshirn
2015-10-22 11:32 ` Vaishali Thakkar
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2015-10-22 7:22 UTC (permalink / raw)
To: Muhammad Falak R Wani, James E.J. Bottomley, linux-scsi, linux-kernel
Cc: Ondrej Zary
On Thu, 2015-10-22 at 03:53 +0530, Muhammad Falak R Wani wrote:
> Use struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
> the goal of getting rid of this macro completely, as this macro
> is deprecated.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/scsi/wd719x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
> index e3da1a2..2a9da2e 100644
> --- a/drivers/scsi/wd719x.c
> +++ b/drivers/scsi/wd719x.c
> @@ -962,7 +962,7 @@ static void wd719x_pci_remove(struct pci_dev
> *pdev)
> scsi_host_put(sh);
> }
>
> -static DEFINE_PCI_DEVICE_TABLE(wd719x_pci_table) = {
> +static const struct pci_device_id wd719x_pci_table[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_WD, 0x3296) },
> {}
> };
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE
2015-10-21 22:23 [PATCH] scsi: wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE Muhammad Falak R Wani
2015-10-22 7:22 ` Johannes Thumshirn
@ 2015-10-22 11:32 ` Vaishali Thakkar
1 sibling, 0 replies; 3+ messages in thread
From: Vaishali Thakkar @ 2015-10-22 11:32 UTC (permalink / raw)
To: Muhammad Falak R Wani
Cc: James E.J. Bottomley, linux-scsi, Linux Kernel Mailing List, Ondrej Zary
On Thu, Oct 22, 2015 at 3:53 AM, Muhammad Falak R Wani
<falakreyaz@gmail.com> wrote:
> Use struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
> the goal of getting rid of this macro completely, as this macro
> is deprecated.
Duplicate of :https://lkml.org/lkml/2015/7/17/62
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/scsi/wd719x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c
> index e3da1a2..2a9da2e 100644
> --- a/drivers/scsi/wd719x.c
> +++ b/drivers/scsi/wd719x.c
> @@ -962,7 +962,7 @@ static void wd719x_pci_remove(struct pci_dev *pdev)
> scsi_host_put(sh);
> }
>
> -static DEFINE_PCI_DEVICE_TABLE(wd719x_pci_table) = {
> +static const struct pci_device_id wd719x_pci_table[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_WD, 0x3296) },
> {}
> };
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Vaishali
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-22 11:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-21 22:23 [PATCH] scsi: wd719x: Remove use of macro DEFINE_PCI_DEVICE_TABLE Muhammad Falak R Wani
2015-10-22 7:22 ` Johannes Thumshirn
2015-10-22 11:32 ` Vaishali Thakkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).