* [PATCH] serial: msm_serial: Make config tristate
@ 2015-10-21 23:05 Stephen Boyd
2015-10-22 2:50 ` Andy Gross
2015-10-22 13:50 ` Paul Gortmaker
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Boyd @ 2015-10-21 23:05 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: linux-kernel, linux-arm-msm, linux-arm-kernel, Paul Gortmaker
This driver works as a module, so mark it as a tristate config
instead of a bool.
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
I tested this with a busybox ramdisk that modprobes msm_serial and
then runs a getty on ttyMSM0. This patch should supersede Paul's earlier
patch that removes the module code from this driver.
drivers/tty/serial/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 1aec4404062d..e4f35da3de27 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1044,7 +1044,7 @@ config SERIAL_SGI_IOC3
say Y or M. Otherwise, say N.
config SERIAL_MSM
- bool "MSM on-chip serial port support"
+ tristate "MSM on-chip serial port support"
depends on ARCH_QCOM
select SERIAL_CORE
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: msm_serial: Make config tristate
2015-10-21 23:05 [PATCH] serial: msm_serial: Make config tristate Stephen Boyd
@ 2015-10-22 2:50 ` Andy Gross
2015-10-22 13:50 ` Paul Gortmaker
1 sibling, 0 replies; 3+ messages in thread
From: Andy Gross @ 2015-10-22 2:50 UTC (permalink / raw)
To: Stephen Boyd
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-kernel, linux-arm-msm,
linux-arm-kernel, Paul Gortmaker
On Wed, Oct 21, 2015 at 04:05:23PM -0700, Stephen Boyd wrote:
> This driver works as a module, so mark it as a tristate config
> instead of a bool.
>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> I tested this with a busybox ramdisk that modprobes msm_serial and
> then runs a getty on ttyMSM0. This patch should supersede Paul's earlier
> patch that removes the module code from this driver.
>
> drivers/tty/serial/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andy Gross <agross@codeaurora.org>
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: msm_serial: Make config tristate
2015-10-21 23:05 [PATCH] serial: msm_serial: Make config tristate Stephen Boyd
2015-10-22 2:50 ` Andy Gross
@ 2015-10-22 13:50 ` Paul Gortmaker
1 sibling, 0 replies; 3+ messages in thread
From: Paul Gortmaker @ 2015-10-22 13:50 UTC (permalink / raw)
To: Stephen Boyd
Cc: Greg Kroah-Hartman, Jiri Slaby, linux-kernel, linux-arm-msm,
linux-arm-kernel
[[PATCH] serial: msm_serial: Make config tristate] On 21/10/2015 (Wed 16:05) Stephen Boyd wrote:
> This driver works as a module, so mark it as a tristate config
> instead of a bool.
>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>
> I tested this with a busybox ramdisk that modprobes msm_serial and
> then runs a getty on ttyMSM0. This patch should supersede Paul's earlier
> patch that removes the module code from this driver.
Thanks, I'll drop my patch for this driver.
Paul.
--
>
> drivers/tty/serial/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 1aec4404062d..e4f35da3de27 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1044,7 +1044,7 @@ config SERIAL_SGI_IOC3
> say Y or M. Otherwise, say N.
>
> config SERIAL_MSM
> - bool "MSM on-chip serial port support"
> + tristate "MSM on-chip serial port support"
> depends on ARCH_QCOM
> select SERIAL_CORE
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-22 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-21 23:05 [PATCH] serial: msm_serial: Make config tristate Stephen Boyd
2015-10-22 2:50 ` Andy Gross
2015-10-22 13:50 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).