* [PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc
@ 2015-10-24 7:06 Punit Vara
2015-10-25 3:25 ` Matthew R. Ochs
2015-11-22 23:10 ` Sebastian Herbszt
0 siblings, 2 replies; 4+ messages in thread
From: Punit Vara @ 2015-10-24 7:06 UTC (permalink / raw)
To: JBottomley
Cc: don.brace, storagedev, linux-scsi, linux-kernel, mrochs, Punit Vara
This patch is to the lpfc_els.c which resolves following warning
reported by coccicheck:
WARNING: kzalloc should be used for rdp_context, instead of
kmalloc/memset
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/scsi/lpfc/lpfc_els.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index 36bf58b..9729ab1 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -4990,13 +4990,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
if (RDP_NPORT_ID_SIZE !=
be32_to_cpu(rdp_req->nport_id_desc.length))
goto rjt_logerr;
- rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
+ rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
if (!rdp_context) {
rjt_err = LSRJT_UNABLE_TPC;
goto error;
}
- memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
cmd = &cmdiocb->iocb;
rdp_context->ndlp = lpfc_nlp_get(ndlp);
rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;
--
2.5.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc
2015-10-24 7:06 [PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc Punit Vara
@ 2015-10-25 3:25 ` Matthew R. Ochs
2015-12-16 23:20 ` James Smart
2015-11-22 23:10 ` Sebastian Herbszt
1 sibling, 1 reply; 4+ messages in thread
From: Matthew R. Ochs @ 2015-10-25 3:25 UTC (permalink / raw)
To: Punit Vara; +Cc: JBottomley, don.brace, storagedev, linux-scsi, linux-kernel
> On Oct 24, 2015, at 2:06 AM, Punit Vara <punitvara@gmail.com> wrote:
>
> This patch is to the lpfc_els.c which resolves following warning
> reported by coccicheck:
>
> WARNING: kzalloc should be used for rdp_context, instead of
> kmalloc/memset
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc
2015-10-24 7:06 [PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc Punit Vara
2015-10-25 3:25 ` Matthew R. Ochs
@ 2015-11-22 23:10 ` Sebastian Herbszt
1 sibling, 0 replies; 4+ messages in thread
From: Sebastian Herbszt @ 2015-11-22 23:10 UTC (permalink / raw)
To: Punit Vara
Cc: JBottomley, don.brace, storagedev, linux-scsi, linux-kernel,
mrochs, James Smart, Sebastian Herbszt
Punit Vara wrote:
> This patch is to the lpfc_els.c which resolves following warning
> reported by coccicheck:
>
> WARNING: kzalloc should be used for rdp_context, instead of
> kmalloc/memset
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_els.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index 36bf58b..9729ab1 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -4990,13 +4990,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
> if (RDP_NPORT_ID_SIZE !=
> be32_to_cpu(rdp_req->nport_id_desc.length))
> goto rjt_logerr;
> - rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> + rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> if (!rdp_context) {
> rjt_err = LSRJT_UNABLE_TPC;
> goto error;
> }
>
> - memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
> cmd = &cmdiocb->iocb;
> rdp_context->ndlp = lpfc_nlp_get(ndlp);
> rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;
Reviewed-by: Sebastian Herbszt <herbszt@gmx.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc
2015-10-25 3:25 ` Matthew R. Ochs
@ 2015-12-16 23:20 ` James Smart
0 siblings, 0 replies; 4+ messages in thread
From: James Smart @ 2015-12-16 23:20 UTC (permalink / raw)
To: Matthew R. Ochs, Punit Vara
Cc: JBottomley, don.brace, storagedev, linux-scsi, linux-kernel
fyi - this patch was just pushed in our 11.0.0.10 patch set - patch 16/17
-- james s
On 10/24/2015 8:25 PM, Matthew R. Ochs wrote:
>> On Oct 24, 2015, at 2:06 AM, Punit Vara <punitvara@gmail.com> wrote:
>>
>> This patch is to the lpfc_els.c which resolves following warning
>> reported by coccicheck:
>>
>> WARNING: kzalloc should be used for rdp_context, instead of
>> kmalloc/memset
>>
>> Signed-off-by: Punit Vara <punitvara@gmail.com>
> Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-16 23:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-24 7:06 [PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc Punit Vara
2015-10-25 3:25 ` Matthew R. Ochs
2015-12-16 23:20 ` James Smart
2015-11-22 23:10 ` Sebastian Herbszt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).