From: Julia Lawall <Julia.Lawall@lip6.fr>
To: linux-wireless@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
linux-media@vger.kernel.org,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jason Cooper" <jason@lakedaemon.net>
Subject: [PATCH 0/8] add missing of_node_put
Date: Sun, 25 Oct 2015 14:56:59 +0100 [thread overview]
Message-ID: <1445781427-7110-1-git-send-email-Julia.Lawall@lip6.fr> (raw)
The various for_each device_node iterators performs an of_node_get on each
iteration, so a break out of the loop requires an of_node_put.
The complete semantic patch that fixes this problem is
(http://coccinelle.lip6.fr):
// <smpl>
@r@
local idexpression n;
expression e1,e2;
iterator name for_each_node_by_name, for_each_node_by_type,
for_each_compatible_node, for_each_matching_node,
for_each_matching_node_and_match, for_each_child_of_node,
for_each_available_child_of_node, for_each_node_with_property;
iterator i;
statement S;
expression list [n1] es;
@@
(
(
for_each_node_by_name(n,e1) S
|
for_each_node_by_type(n,e1) S
|
for_each_compatible_node(n,e1,e2) S
|
for_each_matching_node(n,e1) S
|
for_each_matching_node_and_match(n,e1,e2) S
|
for_each_child_of_node(e1,n) S
|
for_each_available_child_of_node(e1,n) S
|
for_each_node_with_property(n,e1) S
)
&
i(es,n,...) S
)
@@
local idexpression r.n;
iterator r.i;
expression e;
expression list [r.n1] es;
@@
i(es,n,...) {
...
(
of_node_put(n);
|
e = n
|
return n;
|
+ of_node_put(n);
? return ...;
)
...
}
@@
local idexpression r.n;
iterator r.i;
expression e;
expression list [r.n1] es;
@@
i(es,n,...) {
...
(
of_node_put(n);
|
e = n
|
+ of_node_put(n);
? break;
)
...
}
... when != n
@@
local idexpression r.n;
iterator r.i;
expression e;
identifier l;
expression list [r.n1] es;
@@
i(es,n,...) {
...
(
of_node_put(n);
|
e = n
|
+ of_node_put(n);
? goto l;
)
...
}
...
l: ... when != n// </smpl>
---
drivers/media/platform/xilinx/xilinx-tpg.c | 2 ++
drivers/media/platform/xilinx/xilinx-vipp.c | 4 +++-
drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 +++-
drivers/net/ethernet/marvell/mv643xx_eth.c | 4 +++-
drivers/net/ethernet/ti/netcp_ethss.c | 8 ++++++--
drivers/net/phy/mdio-mux-mmioreg.c | 2 ++
drivers/net/phy/mdio-mux.c | 1 +
drivers/net/wireless/ath/ath6kl/init.c | 1 +
8 files changed, 21 insertions(+), 5 deletions(-)
next reply other threads:[~2015-10-25 14:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-25 13:56 Julia Lawall [this message]
2015-10-25 13:57 ` [PATCH 1/8] net: thunderx: add missing of_node_put Julia Lawall
2015-10-25 13:57 ` [PATCH 2/8] net: netcp: " Julia Lawall
2015-10-25 13:57 ` [PATCH 3/8] netdev/phy: " Julia Lawall
2015-10-25 13:57 ` [PATCH 4/8] net: phy: mdio: " Julia Lawall
2015-10-25 13:57 ` [PATCH 5/8] [media] v4l: xilinx-vipp: " Julia Lawall
2015-10-26 1:20 ` Laurent Pinchart
2015-10-25 13:57 ` [PATCH 6/8] [media] v4l: xilinx-tpg: " Julia Lawall
2015-10-26 1:19 ` Laurent Pinchart
2015-10-25 13:57 ` [PATCH 7/8] ath6kl: " Julia Lawall
2015-10-25 13:57 ` [PATCH 8/8] net: mv643xx_eth: " Julia Lawall
2015-10-27 5:08 ` [PATCH 0/8] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445781427-7110-1-git-send-email-Julia.Lawall@lip6.fr \
--to=julia.lawall@lip6.fr \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=jason@lakedaemon.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=soren.brinkmann@xilinx.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).