From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: "Hyun Kwon" <hyun.kwon@xilinx.com>,
kernel-janitors@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jason Cooper" <jason@lakedaemon.net>
Subject: Re: [PATCH 6/8] [media] v4l: xilinx-tpg: add missing of_node_put
Date: Mon, 26 Oct 2015 03:19:42 +0200 [thread overview]
Message-ID: <1798308.03Tu29vvmA@avalon> (raw)
In-Reply-To: <1445781427-7110-7-git-send-email-Julia.Lawall@lip6.fr>
Hi Julia,
Thank you for the patch.
On Sunday 25 October 2015 14:57:05 Julia Lawall wrote:
> for_each_child_of_node performs an of_node_get on each iteration, so
> a break out of the loop requires an of_node_put.
>
> A simplified version of the semantic patch that fixes this problem is as
> follows (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> @@
>
> for_each_child_of_node(root, child) {
> ... when != of_node_put(child)
> when != e = child
> (
> return child;
>
> + of_node_put(child);
> ? return ...;
> )
> ...
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/xilinx/xilinx-tpg.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/xilinx/xilinx-tpg.c
> b/drivers/media/platform/xilinx/xilinx-tpg.c index b5f7d5e..8bd7e37 100644
> --- a/drivers/media/platform/xilinx/xilinx-tpg.c
> +++ b/drivers/media/platform/xilinx/xilinx-tpg.c
> @@ -731,6 +731,7 @@ static int xtpg_parse_of(struct xtpg_device *xtpg)
> format = xvip_of_get_format(port);
> if (IS_ERR(format)) {
> dev_err(dev, "invalid format in DT");
> + of_node_put(port);
> return PTR_ERR(format);
> }
>
> @@ -739,6 +740,7 @@ static int xtpg_parse_of(struct xtpg_device *xtpg)
> xtpg->vip_format = format;
> } else if (xtpg->vip_format != format) {
> dev_err(dev, "in/out format mismatch in DT");
> + of_node_put(port);
> return -EINVAL;
> }
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-10-26 1:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-25 13:56 [PATCH 0/8] add missing of_node_put Julia Lawall
2015-10-25 13:57 ` [PATCH 1/8] net: thunderx: " Julia Lawall
2015-10-25 13:57 ` [PATCH 2/8] net: netcp: " Julia Lawall
2015-10-25 13:57 ` [PATCH 3/8] netdev/phy: " Julia Lawall
2015-10-25 13:57 ` [PATCH 4/8] net: phy: mdio: " Julia Lawall
2015-10-25 13:57 ` [PATCH 5/8] [media] v4l: xilinx-vipp: " Julia Lawall
2015-10-26 1:20 ` Laurent Pinchart
2015-10-25 13:57 ` [PATCH 6/8] [media] v4l: xilinx-tpg: " Julia Lawall
2015-10-26 1:19 ` Laurent Pinchart [this message]
2015-10-25 13:57 ` [PATCH 7/8] ath6kl: " Julia Lawall
2015-10-25 13:57 ` [PATCH 8/8] net: mv643xx_eth: " Julia Lawall
2015-10-27 5:08 ` [PATCH 0/8] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1798308.03Tu29vvmA@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=Julia.Lawall@lip6.fr \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=hyun.kwon@xilinx.com \
--cc=jason@lakedaemon.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mchehab@osg.samsung.com \
--cc=michal.simek@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).