linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yaniv Gardi <ygardi@codeaurora.org>
To: robherring2@gmail.com, James.Bottomley@HansenPartnership.com,
	pebolle@tiscali.nl, hch@infradead.org
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
	linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
	ygardi@codeaurora.org, gbroner@codeaurora.org,
	draviv@codeaurora.org, Vinayak Holikatti <vinholikatti@gmail.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>
Subject: [PATCH v2 14/17] scsi: ufs: fix leakage during link off state
Date: Mon, 26 Oct 2015 17:41:09 +0200	[thread overview]
Message-ID: <1445874072-25909-15-git-send-email-ygardi@codeaurora.org> (raw)
In-Reply-To: <1445874072-25909-1-git-send-email-ygardi@codeaurora.org>

Currently when we try to put the link in off/disabled state during
suspend, it seems link is not being kept in low power mode.
This patch fixes the issue by putting the link in hibern8 first
(so device also puts the link in low power mode) and then stop the
host controller.

Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>

---
 drivers/scsi/ufs/ufshcd.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 822692e..f85cd66 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -5649,6 +5649,16 @@ static int ufshcd_link_state_transition(struct ufs_hba *hba,
 		   (!check_for_bkops || (check_for_bkops &&
 		    !hba->auto_bkops_enabled))) {
 		/*
+		 * Let's make sure that link is in low power mode, we are doing
+		 * this currently by putting the link in Hibern8. Otherway to
+		 * put the link in low power mode is to send the DME end point
+		 * to device and then send the DME reset command to local
+		 * unipro. But putting the link in hibern8 is much faster.
+		 */
+		ret = ufshcd_uic_hibern8_enter(hba);
+		if (ret)
+			goto out;
+		/*
 		 * Change controller state to "reset state" which
 		 * should also put the link in off/reset state
 		 */
-- 
1.8.5.2

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

  parent reply	other threads:[~2015-10-26 15:42 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26 15:40 [PATCH v2 00/17] add fixes, device quirks, error recovery, Yaniv Gardi
2015-10-26 15:40 ` [PATCH v2 01/17] scsi: ufs-qcom: add number of lanes per direction Yaniv Gardi
2015-10-26 15:40 ` [PATCH v2 02/17] scsi: ufs: add option to change default UFS power management level Yaniv Gardi
2015-11-12 17:39   ` Rob Herring
2015-10-26 15:40 ` [PATCH v2 03/17] scsi: ufs: optimize system suspend handling Yaniv Gardi
2015-10-26 15:40 ` [PATCH v2 04/17] scsi: ufs: avoid spurious UFS host controller interrupts Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 05/17] scsi: ufs: implement scsi host timeout handler Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 06/17] scsi :ufs: verify hba controller hce reg value Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 07/17] scsi: ufs: separate device and host quirks Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 08/17] scsi: ufs: disable vccq if it's not needed by UFS device Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 09/17] scsi: ufs: make error handling bit faster Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 10/17] scsi: ufs: add error recovery after DL NAC error Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 11/17] scsi: ufs: add retry for query descriptors Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 12/17] scsi: ufs: handle non spec compliant bkops behaviour by device Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 13/17] scsi: ufs: tune UniPro parameters to optimize hibern8 exit time Yaniv Gardi
2015-10-26 15:41 ` Yaniv Gardi [this message]
2015-10-26 15:41 ` [PATCH v2 15/17] scsi: ufs: add device quirk delay before putting UFS rails in LPM Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 16/17] scsi: ufs-qcom: set PA_Local_TX_LCC_Enable before link startup Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings Yaniv Gardi
2015-10-26 21:56   ` Stephen Boyd
2015-10-27 10:10     ` ygardi
2015-10-27 17:27       ` Stephen Boyd
2015-10-27 18:22         ` ygardi
2015-10-27 18:52           ` Stephen Boyd
2015-10-28 11:46 ` [PATCH v2 00/17] add fixes, device quirks, error recovery, Gilad Broner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445874072-25909-15-git-send-email-ygardi@codeaurora.org \
    --to=ygardi@codeaurora.org \
    --cc=JBottomley@odin.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=draviv@codeaurora.org \
    --cc=gbroner@codeaurora.org \
    --cc=hch@infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi-owner@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=robherring2@gmail.com \
    --cc=santoshsy@gmail.com \
    --cc=subhashj@codeaurora.org \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).