From: Stephen Boyd <sboyd@codeaurora.org>
To: Yaniv Gardi <ygardi@codeaurora.org>,
robherring2@gmail.com, James.Bottomley@HansenPartnership.com,
pebolle@tiscali.nl, hch@infradead.org
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
gbroner@codeaurora.org, draviv@codeaurora.org,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <JBottomley@odin.com>
Subject: Re: [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings
Date: Mon, 26 Oct 2015 14:56:46 -0700 [thread overview]
Message-ID: <562EA19E.2070007@codeaurora.org> (raw)
In-Reply-To: <1445874072-25909-18-git-send-email-ygardi@codeaurora.org>
On 10/26/2015 08:41 AM, Yaniv Gardi wrote:
> Tnis patch fixes the following compilation warnings:
> ...ufs-qcom.c:1201:40:
> warning: incorrect type in argument 1 (different address spaces)
> ...ufs-qcom.c:1201:40:
> expected void const *ptr
> ...ufs-qcom.c:1201:40:
> got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
> ...ufs-qcom.c:1207:53:
> warning: incorrect type in argument 1 (different address spaces)
> ...ufs-qcom.c:1207:53:
> expected void const *ptr
> ...ufs-qcom.c:1207:53:
> got void [noderef] <asn:2>*dev_ref_clk_ctrl_mmio
>
> Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>
>
> ---
What version of sparse do you use? You shouldn't need to do this.
> drivers/scsi/ufs/ufs-qcom.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index 72b0ef7..b57f88a 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1226,11 +1226,12 @@ static int ufs_qcom_init(struct ufs_hba *hba)
> if (res) {
> host->dev_ref_clk_ctrl_mmio =
> devm_ioremap_resource(dev, res);
> - if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) {
> - dev_warn(dev,
> - "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
> + if (IS_ERR((__force void const *)
> + host->dev_ref_clk_ctrl_mmio)) {
> + dev_warn(dev, "%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
> __func__,
> - PTR_ERR(host->dev_ref_clk_ctrl_mmio));
> + PTR_ERR((__force void const *)
> + host->dev_ref_clk_ctrl_mmio));
> host->dev_ref_clk_ctrl_mmio = NULL;
> }
> host->dev_ref_clk_en_mask = BIT(5);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-10-26 21:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 15:40 [PATCH v2 00/17] add fixes, device quirks, error recovery, Yaniv Gardi
2015-10-26 15:40 ` [PATCH v2 01/17] scsi: ufs-qcom: add number of lanes per direction Yaniv Gardi
2015-10-26 15:40 ` [PATCH v2 02/17] scsi: ufs: add option to change default UFS power management level Yaniv Gardi
2015-11-12 17:39 ` Rob Herring
2015-10-26 15:40 ` [PATCH v2 03/17] scsi: ufs: optimize system suspend handling Yaniv Gardi
2015-10-26 15:40 ` [PATCH v2 04/17] scsi: ufs: avoid spurious UFS host controller interrupts Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 05/17] scsi: ufs: implement scsi host timeout handler Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 06/17] scsi :ufs: verify hba controller hce reg value Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 07/17] scsi: ufs: separate device and host quirks Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 08/17] scsi: ufs: disable vccq if it's not needed by UFS device Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 09/17] scsi: ufs: make error handling bit faster Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 10/17] scsi: ufs: add error recovery after DL NAC error Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 11/17] scsi: ufs: add retry for query descriptors Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 12/17] scsi: ufs: handle non spec compliant bkops behaviour by device Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 13/17] scsi: ufs: tune UniPro parameters to optimize hibern8 exit time Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 14/17] scsi: ufs: fix leakage during link off state Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 15/17] scsi: ufs: add device quirk delay before putting UFS rails in LPM Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 16/17] scsi: ufs-qcom: set PA_Local_TX_LCC_Enable before link startup Yaniv Gardi
2015-10-26 15:41 ` [PATCH v2 17/17] scsi: ufs-qcom: fix compilation warnings Yaniv Gardi
2015-10-26 21:56 ` Stephen Boyd [this message]
2015-10-27 10:10 ` ygardi
2015-10-27 17:27 ` Stephen Boyd
2015-10-27 18:22 ` ygardi
2015-10-27 18:52 ` Stephen Boyd
2015-10-28 11:46 ` [PATCH v2 00/17] add fixes, device quirks, error recovery, Gilad Broner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562EA19E.2070007@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=JBottomley@odin.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=draviv@codeaurora.org \
--cc=gbroner@codeaurora.org \
--cc=hch@infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=robherring2@gmail.com \
--cc=santoshsy@gmail.com \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).