* [PATCH] net: hns: fixes the bug tested XGE by ethtool -p
@ 2015-10-27 9:17 yankejian
2015-10-28 3:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: yankejian @ 2015-10-27 9:17 UTC (permalink / raw)
To: davem, yisen.zhuang, lisheng011, lipeng321, yankejian,
salil.mehta, huangdaode, xuwei5, liguozhu
Cc: haifeng.wei, linuxarm, netdev, linux-kernel
From: Li Peng <lipeng321@huawei.com>
delete action of ETHTOOL_ID_ON/ETHTOOL_ID_OFF in XGE ethtool -p,
so Hardware control the LED state instead of software.
Signed-off-by: Li Peng <lipeng321@huawei.com>
Signed-off-by: Yisen Zhuang <yisen.zhuang@huawei.com>
Signed-off-by: yankejian <yankejian@huawei.com>
---
drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
index d611388..523e9b8 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c
@@ -64,17 +64,10 @@ int cpld_set_led_id(struct hns_mac_cb *mac_cb,
switch (status) {
case HNAE_LED_ACTIVE:
mac_cb->cpld_led_value = dsaf_read_b(mac_cb->cpld_vaddr);
- return 2;
- case HNAE_LED_ON:
dsaf_set_bit(mac_cb->cpld_led_value, DSAF_LED_ANCHOR_B,
CPLD_LED_ON_VALUE);
dsaf_write_b(mac_cb->cpld_vaddr, mac_cb->cpld_led_value);
- break;
- case HNAE_LED_OFF:
- dsaf_set_bit(mac_cb->cpld_led_value, DSAF_LED_ANCHOR_B,
- CPLD_LED_DEFAULT_VALUE);
- dsaf_write_b(mac_cb->cpld_vaddr, mac_cb->cpld_led_value);
- break;
+ return 2;
case HNAE_LED_INACTIVE:
dsaf_set_bit(mac_cb->cpld_led_value, DSAF_LED_ANCHOR_B,
CPLD_LED_DEFAULT_VALUE);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: hns: fixes the bug tested XGE by ethtool -p
2015-10-27 9:17 [PATCH] net: hns: fixes the bug tested XGE by ethtool -p yankejian
@ 2015-10-28 3:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-10-28 3:16 UTC (permalink / raw)
To: yankejian
Cc: yisen.zhuang, lisheng011, lipeng321, salil.mehta, huangdaode,
xuwei5, liguozhu, haifeng.wei, linuxarm, netdev, linux-kernel
From: yankejian <yankejian@huawei.com>
Date: Tue, 27 Oct 2015 17:17:40 +0800
> From: Li Peng <lipeng321@huawei.com>
>
> delete action of ETHTOOL_ID_ON/ETHTOOL_ID_OFF in XGE ethtool -p,
> so Hardware control the LED state instead of software.
>
> Signed-off-by: Li Peng <lipeng321@huawei.com>
> Signed-off-by: Yisen Zhuang <yisen.zhuang@huawei.com>
> Signed-off-by: yankejian <yankejian@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-28 2:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-27 9:17 [PATCH] net: hns: fixes the bug tested XGE by ethtool -p yankejian
2015-10-28 3:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).