From: Philipp Zabel <p.zabel@pengutronix.de>
To: Chen Feng <puck.chen@hisilicon.com>
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk
Subject: Re: [PATCH V5 Base on RC7 3/3] Add reset controller for hi6220 SoC platform.
Date: Wed, 28 Oct 2015 12:42:22 +0100 [thread overview]
Message-ID: <1446032542.12590.33.camel@pengutronix.de> (raw)
In-Reply-To: <1445939498-94147-3-git-send-email-puck.chen@hisilicon.com>
Am Dienstag, den 27.10.2015, 17:51 +0800 schrieb Chen Feng:
> reset: add driver for hi6220 reset controller
>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 3f03380..3f055e2 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -167,5 +167,12 @@
> clocks = <&ao_ctrl 36>, <&ao_ctrl 36>;
> clock-names = "uartclk", "apb_pclk";
> };
> +
> + reset_ctrl: reset_ctrl@f7030000 {
> + compatible = "hisilicon,hi6220-reset-ctl";
> + reg = <0x0 0xf7030000 0x0 0x1000>;
> + #reset-cells = <1>;
> + };
> +
While applying I just noticed that the device tree already contains a
node claiming the same address space:
sys_ctrl: sys_ctrl@f7030000 {
compatible = "hisilicon,hi6220-sysctrl", "syscon";
reg = <0x0 0xf7030000 0x0 0x2000>;
#clock-cells = <1>;
};
It is documented in
Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt and
Documentation/devicetree/bindings/clock/hi6220-clock.txt.
Could you clarify whether the reset controls are just part of the
sys_ctrl block? If so, I think you should add #reset-cells = <1> to the
sys_ctrl node instead.
regards
Philipp
next prev parent reply other threads:[~2015-10-28 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 9:51 [PATCH V5 Base on RC7 1/3] Add DT bindings documentation for hi6220 SoC reset controller Chen Feng
2015-10-27 9:51 ` [PATCH V5 Base on RC7 2/3] Add reset controller for hi6220 SoC platform Chen Feng
2015-10-27 9:51 ` [PATCH V5 Base on RC7 3/3] " Chen Feng
2015-10-28 11:42 ` Philipp Zabel [this message]
2015-10-29 8:34 ` chenfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446032542.12590.33.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=puck.chen@hisilicon.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).