* [PATCH v1 0/6] Support the thermal for RK3368 SoCs @ 2015-10-29 7:14 Caesar Wang 2015-10-29 7:14 ` [PATCH v1 1/6] dt-bindings: rockchip-thermal: Support the RK3368 SoCs compatible Caesar Wang ` (5 more replies) 0 siblings, 6 replies; 9+ messages in thread From: Caesar Wang @ 2015-10-29 7:14 UTC (permalink / raw) To: Heiko Stuebner, Eduardo Valentin Cc: linux-rockchip, Caesar Wang, devicetree, Will Deacon, Lorenzo Pieralisi, linux-pm, Olof Johansson, Kumar Gala, linux-kernel, Ian Campbell, Rob Herring, Dmitry Torokhov, linux-arm-kernel, Pawel Moll, Zhang Rui, Mark Rutland, Catalin Marinas This series patchs are working for RK3368 on Rockchip platform. @Heiko, The PATCH [5/6] is working based on big/littel cluster cpufreq added. Anyway, the PATCH [5/6] also work for next kernel. @Eduardo, This patchset are based on linus master branch. Note: Need add the following thermal patchs for thermal driver before apply this series patchs. 1) thermal: rockchip: fix handling of invalid readings (https://patchwork.kernel.org/patch/6973101/) 2) thermal: rockhip: fix setting thermal shutdown polarity (https://patchwork.kernel.org/patch/6973131/) 3) dt-bindings: rockchip-thermal: Add the pinctrl states in this document (https://patchwork.kernel.org/patch/7472021/) 4) thermal: rockchip: support the sleep pinctrl state to avoid glitches in s2r (https://patchwork.kernel.org/patch/7472051/) the git log oneline my local branch as follows: 8132956 arm64: dts: Enable the Thermal on R88 board ba3fd05 arm64: dts: Add main Thermal info to rk3368.dtsi 66adecc arm64: dts: Add the thermal data found on RK3368 acc9cb6 thermal: rockchip: Support the RK3368 SoCs in thermal driver 8c65003 thermal: rockchip: better to compatible the driver for different SoCs ea9f28a dt-bindings: rockchip-thermal: Support the RK3368 SoCs compatible 29eb0c7 thermal: rockchip: support the sleep pinctrl state to avoid glitches in s2r cf2100b dt-bindings: rockchip-thermal: Add the pinctrl states in this document 38e287b0 thermal: rockhip: fix setting thermal shutdown polarity ddee4a2 thermal: rockchip: fix handling of invalid readings 8a28d67 Merge tag 'powerpc-4.3-6' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux 977bf06 powerpc/dma: dma_set_coherent_mask() should not be GPL only a22c4d7 block: re-add discard_granularity and alignment checks 23d8827 Merge branch 'fixes' of git://ftp.arm.linux.org.uk/~rmk/linux-arm 3d0aa36 Merge branch 'for-linus' of git://git.kernel.dk/linux-block dc5bc3f Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 9e17f90 Merge tag 'fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux 174fd8d blkcg: fix incorrect read/write sync/async stat accounting 858e904 Merge tag 'iommu-fixes-v4.3-rc7' of ...... ---- This series are tested on RK3368 board. while true;do ls >/dev/null; done& while true; do grep "" /sys/class/thermal/thermal_zone[0-1]/temp; sleep .5; done & You can get the temperature form sensors. /sys/class/thermal/thermal_zone0/temp:27500 /sys/class/thermal/thermal_zone1/temp:30000 /sys/class/thermal/thermal_zone0/temp:30000 /sys/class/thermal/thermal_zone1/temp:30000 /sys/class/thermal/thermal_zone0/temp:27500 /sys/class/thermal/thermal_zone1/temp:30000 /sys/class/thermal/thermal_zone0/temp:30000 /sys/class/thermal/thermal_zone1/temp:30000 /sys/class/thermal/thermal_zone0/temp:25000 /sys/class/thermal/thermal_zone1/temp:30000 /sys/class/thermal/thermal_zone0/temp:32500 /sys/class/thermal/thermal_zone1/temp:30000 /sys/class/thermal/thermal_zone0/temp:30000 /sys/class/thermal/thermal_zone1/temp:30000 /sys/class/thermal/thermal_zone0/temp:22500 /sys/class/thermal/thermal_zone1/temp:32500 /sys/class/thermal/thermal_zone0/temp:25000 /sys/class/thermal/thermal_zone1/temp:30000 /sys/class/thermal/thermal_zone0/temp:25000 /sys/class/thermal/thermal_zone1/temp:30000 /sys/class/thermal/thermal_zone0/temp:22500 /sys/class/thermal/thermal_zone1/temp:30000 /sys/class/thermal/thermal_zone0/temp:30000 /sys/class/thermal/thermal_zone1/temp:32500 /sys/class/thermal/thermal_zone1/temp:32500 /sys/class/thermal/thermal_zone0/temp:32500 Changes in v1: - %s/thermal/rockchip-thermal in subject. - add a new patch for thermal driver to support more SoCs. - As Dmitry comment, make the conversion table in as a parameter. - support the opt gpio pinctrl state Caesar Wang (6): dt-bindings: rockchip-thermal: Support the RK3368 SoCs compatible thermal: rockchip: better to compatible the driver for different SoCs thermal: rockchip: Support the RK3368 SoCs in thermal driver arm64: dts: Add the thermal data found on RK3368 arm64: dts: Add main Thermal info to rk3368.dtsi arm64: dts: Enable the Thermal on R88 board .../bindings/thermal/rockchip-thermal.txt | 4 +- arch/arm64/boot/dts/rockchip/rk3368-r88.dts | 6 + arch/arm64/boot/dts/rockchip/rk3368-thermal.dtsi | 112 +++++++++ arch/arm64/boot/dts/rockchip/rk3368.dtsi | 36 +++ drivers/thermal/rockchip_thermal.c | 267 ++++++++++++++++----- 5 files changed, 362 insertions(+), 63 deletions(-) create mode 100644 arch/arm64/boot/dts/rockchip/rk3368-thermal.dtsi -- 1.9.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v1 1/6] dt-bindings: rockchip-thermal: Support the RK3368 SoCs compatible 2015-10-29 7:14 [PATCH v1 0/6] Support the thermal for RK3368 SoCs Caesar Wang @ 2015-10-29 7:14 ` Caesar Wang 2015-10-29 7:14 ` [PATCH v1 2/6] thermal: rockchip: better to compatible the driver for different SoCs Caesar Wang ` (4 subsequent siblings) 5 siblings, 0 replies; 9+ messages in thread From: Caesar Wang @ 2015-10-29 7:14 UTC (permalink / raw) To: Heiko Stuebner, Eduardo Valentin Cc: linux-rockchip, Caesar Wang, devicetree, linux-pm, Kumar Gala, linux-kernel, Ian Campbell, Rob Herring, linux-arm-kernel, Pawel Moll, Zhang Rui, Mark Rutland This patchset attempts to new compatible for thermal founding on RK3368 SoCs. Signed-off-by: Caesar Wang <wxt@rock-chips.com> --- Changes in v1: - %s/thermal/rockchip-thermal in subject. Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt index b38200d..0dfa60d 100644 --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt @@ -1,7 +1,9 @@ * Temperature Sensor ADC (TSADC) on rockchip SoCs Required properties: -- compatible : "rockchip,rk3288-tsadc" +- compatible : should be "rockchip,<name>-tsadc" + "rockchip,rk3288-tsadc": found on RK3288 SoCs + "rockchip,rk3368-tsadc": found on RK3368 SoCs - reg : physical base address of the controller and length of memory mapped region. - interrupts : The interrupt number to the cpu. The interrupt specifier format -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v1 2/6] thermal: rockchip: better to compatible the driver for different SoCs 2015-10-29 7:14 [PATCH v1 0/6] Support the thermal for RK3368 SoCs Caesar Wang 2015-10-29 7:14 ` [PATCH v1 1/6] dt-bindings: rockchip-thermal: Support the RK3368 SoCs compatible Caesar Wang @ 2015-10-29 7:14 ` Caesar Wang 2015-10-29 7:14 ` [PATCH v1 3/6] thermal: rockchip: Support the RK3368 SoCs in thermal driver Caesar Wang ` (3 subsequent siblings) 5 siblings, 0 replies; 9+ messages in thread From: Caesar Wang @ 2015-10-29 7:14 UTC (permalink / raw) To: Heiko Stuebner, Eduardo Valentin Cc: linux-rockchip, Caesar Wang, linux-pm, linux-kernel, Zhang Rui, linux-arm-kernel The current driver is default to register the two thermal sensors in probe since some SoCs maybe only have one sensor for thermal. In some cases, the channel 0 is not always the cpu or gpu sensor. So add the channel can be configured for sensors. Signed-off-by: Caesar Wang <wxt@rock-chips.com> --- Changes in v1: - add a new patch for thermal driver to support more SoCs. drivers/thermal/rockchip_thermal.c | 84 +++++++++++++++++++++----------------- 1 file changed, 47 insertions(+), 37 deletions(-) diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index 2b58870..f96c151 100644 --- a/drivers/thermal/rockchip_thermal.c +++ b/drivers/thermal/rockchip_thermal.c @@ -44,15 +44,25 @@ enum tshut_polarity { }; /** - * The system has three Temperature Sensors. channel 0 is reserved, - * channel 1 is for CPU, and channel 2 is for GPU. + * The system has two Temperature Sensors. + * sensor0 is for CPU, and sensor1 is for GPU. */ enum sensor_id { - SENSOR_CPU = 1, + SENSOR_CPU = 0, SENSOR_GPU, }; +/** + * The max sensors is two in rockchip SoCs. + * Two sensors: CPU and GPU sensor. + */ +#define SOC_MAX_SENSORS 2 + struct rockchip_tsadc_chip { + /* The sensor id of chip correspond to the ADC channel */ + int chn_id[SOC_MAX_SENSORS]; + int chn_num; + /* The hardware-controlled tshut property */ long tshut_temp; enum tshut_mode tshut_mode; @@ -72,17 +82,15 @@ struct rockchip_tsadc_chip { struct rockchip_thermal_sensor { struct rockchip_thermal_data *thermal; struct thermal_zone_device *tzd; - enum sensor_id id; + int id; }; -#define NUM_SENSORS 2 /* Ignore unused sensor 0 */ - struct rockchip_thermal_data { const struct rockchip_tsadc_chip *chip; struct platform_device *pdev; struct reset_control *reset; - struct rockchip_thermal_sensor sensors[NUM_SENSORS]; + struct rockchip_thermal_sensor sensors[SOC_MAX_SENSORS]; struct clk *clk; struct clk *pclk; @@ -317,6 +325,10 @@ static void rk_tsadcv2_tshut_mode(int chn, void __iomem *regs, } static const struct rockchip_tsadc_chip rk3288_tsadc_data = { + .chn_id[SENSOR_CPU] = 1, /* cpu sensor is channel 1 */ + .chn_id[SENSOR_GPU] = 2, /* gpu sensor is channel 2 */ + .chn_num = 2, /* two channels for tsadc */ + .tshut_mode = TSHUT_MODE_GPIO, /* default TSHUT via GPIO give PMIC */ .tshut_polarity = TSHUT_LOW_ACTIVE, /* default TSHUT LOW ACTIVE */ .tshut_temp = 95000, @@ -356,7 +368,7 @@ static irqreturn_t rockchip_thermal_alarm_irq_thread(int irq, void *dev) thermal->chip->irq_ack(thermal->regs); - for (i = 0; i < ARRAY_SIZE(thermal->sensors); i++) + for (i = 0; i < thermal->chip->chn_num; i++) thermal_zone_device_update(thermal->sensors[i].tzd); return IRQ_HANDLED; @@ -441,7 +453,7 @@ static int rockchip_thermal_register_sensor(struct platform_device *pdev, struct rockchip_thermal_data *thermal, struct rockchip_thermal_sensor *sensor, - enum sensor_id id) + int id) { const struct rockchip_tsadc_chip *tsadc = thermal->chip; int error; @@ -480,7 +492,7 @@ static int rockchip_thermal_probe(struct platform_device *pdev) const struct of_device_id *match; struct resource *res; int irq; - int i; + int i, j; int error; match = of_match_node(of_rockchip_thermal_match, np); @@ -555,22 +567,19 @@ static int rockchip_thermal_probe(struct platform_device *pdev) thermal->chip->initialize(thermal->regs, thermal->tshut_polarity); - error = rockchip_thermal_register_sensor(pdev, thermal, - &thermal->sensors[0], - SENSOR_CPU); - if (error) { - dev_err(&pdev->dev, - "failed to register CPU thermal sensor: %d\n", error); - goto err_disable_pclk; - } - - error = rockchip_thermal_register_sensor(pdev, thermal, - &thermal->sensors[1], - SENSOR_GPU); - if (error) { - dev_err(&pdev->dev, - "failed to register GPU thermal sensor: %d\n", error); - goto err_unregister_cpu_sensor; + for (i = 0; i < thermal->chip->chn_num; i++) { + error = rockchip_thermal_register_sensor(pdev, thermal, + &thermal->sensors[i], + thermal->chip->chn_id[i]); + if (error) { + dev_err(&pdev->dev, + "failed to register sensor[%d] : error = %d\n", + i, error); + for (j = 0; j < i; j++) + thermal_zone_of_sensor_unregister(&pdev->dev, + thermal->sensors[j].tzd); + goto err_disable_pclk; + } } error = devm_request_threaded_irq(&pdev->dev, irq, NULL, @@ -580,22 +589,23 @@ static int rockchip_thermal_probe(struct platform_device *pdev) if (error) { dev_err(&pdev->dev, "failed to request tsadc irq: %d\n", error); - goto err_unregister_gpu_sensor; + goto err_unregister_sensor; } thermal->chip->control(thermal->regs, true); - for (i = 0; i < ARRAY_SIZE(thermal->sensors); i++) + for (i = 0; i < thermal->chip->chn_num; i++) rockchip_thermal_toggle_sensor(&thermal->sensors[i], true); platform_set_drvdata(pdev, thermal); return 0; -err_unregister_gpu_sensor: - thermal_zone_of_sensor_unregister(&pdev->dev, thermal->sensors[1].tzd); -err_unregister_cpu_sensor: - thermal_zone_of_sensor_unregister(&pdev->dev, thermal->sensors[0].tzd); +err_unregister_sensor: + while (i--) + thermal_zone_of_sensor_unregister(&pdev->dev, + thermal->sensors[i].tzd); + err_disable_pclk: clk_disable_unprepare(thermal->pclk); err_disable_clk: @@ -609,7 +619,7 @@ static int rockchip_thermal_remove(struct platform_device *pdev) struct rockchip_thermal_data *thermal = platform_get_drvdata(pdev); int i; - for (i = 0; i < ARRAY_SIZE(thermal->sensors); i++) { + for (i = 0; i < thermal->chip->chn_num; i++) { struct rockchip_thermal_sensor *sensor = &thermal->sensors[i]; rockchip_thermal_toggle_sensor(sensor, false); @@ -630,7 +640,7 @@ static int __maybe_unused rockchip_thermal_suspend(struct device *dev) struct rockchip_thermal_data *thermal = platform_get_drvdata(pdev); int i; - for (i = 0; i < ARRAY_SIZE(thermal->sensors); i++) + for (i = 0; i < thermal->chip->chn_num; i++) rockchip_thermal_toggle_sensor(&thermal->sensors[i], false); thermal->chip->control(thermal->regs, false); @@ -662,8 +672,8 @@ static int __maybe_unused rockchip_thermal_resume(struct device *dev) thermal->chip->initialize(thermal->regs, thermal->tshut_polarity); - for (i = 0; i < ARRAY_SIZE(thermal->sensors); i++) { - enum sensor_id id = thermal->sensors[i].id; + for (i = 0; i < thermal->chip->chn_num; i++) { + int id = thermal->sensors[i].id; thermal->chip->set_tshut_mode(id, thermal->regs, thermal->tshut_mode); @@ -673,7 +683,7 @@ static int __maybe_unused rockchip_thermal_resume(struct device *dev) thermal->chip->control(thermal->regs, true); - for (i = 0; i < ARRAY_SIZE(thermal->sensors); i++) + for (i = 0; i < thermal->chip->chn_num; i++) rockchip_thermal_toggle_sensor(&thermal->sensors[i], true); pinctrl_pm_select_default_state(dev); -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v1 3/6] thermal: rockchip: Support the RK3368 SoCs in thermal driver 2015-10-29 7:14 [PATCH v1 0/6] Support the thermal for RK3368 SoCs Caesar Wang 2015-10-29 7:14 ` [PATCH v1 1/6] dt-bindings: rockchip-thermal: Support the RK3368 SoCs compatible Caesar Wang 2015-10-29 7:14 ` [PATCH v1 2/6] thermal: rockchip: better to compatible the driver for different SoCs Caesar Wang @ 2015-10-29 7:14 ` Caesar Wang 2015-11-03 17:48 ` Eduardo Valentin 2015-10-29 7:14 ` [PATCH v1 4/6] arm64: dts: Add the thermal data found on RK3368 Caesar Wang ` (2 subsequent siblings) 5 siblings, 1 reply; 9+ messages in thread From: Caesar Wang @ 2015-10-29 7:14 UTC (permalink / raw) To: Heiko Stuebner, Eduardo Valentin Cc: linux-rockchip, Caesar Wang, linux-pm, linux-kernel, Zhang Rui, linux-arm-kernel The RK3368 SoCs support to 2 channel TS-ADC, the temperature criteria of each channel can be configurable. The system has two Temperature Sensors, channel 0 is for CPU, and channel 1 is for GPU. Signed-off-by: Caesar Wang <wxt@rock-chips.com> --- Changes in v1: - As Dmitry comment, make the conversion table in as a parameter. drivers/thermal/rockchip_thermal.c | 183 ++++++++++++++++++++++++++++++++----- 1 file changed, 158 insertions(+), 25 deletions(-) diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index f96c151..4748a8e 100644 --- a/drivers/thermal/rockchip_thermal.c +++ b/drivers/thermal/rockchip_thermal.c @@ -1,6 +1,9 @@ /* * Copyright (c) 2014, Fuzhou Rockchip Electronics Co., Ltd * + * Copyright (c) 2015, Fuzhou Rockchip Electronics Co., Ltd + * Caesar Wang <wxt@rock-chips.com> + * * This program is free software; you can redistribute it and/or modify it * under the terms and conditions of the GNU General Public License, * version 2, as published by the Free Software Foundation. @@ -75,8 +78,12 @@ struct rockchip_tsadc_chip { /* Per-sensor methods */ int (*get_temp)(int chn, void __iomem *reg, int *temp); - void (*set_tshut_temp)(int chn, void __iomem *reg, long temp); + void (*set_tshut_value)(int chn, void __iomem *reg, u32 value); void (*set_tshut_mode)(int chn, void __iomem *reg, enum tshut_mode m); + + /* Per-table methods */ + const struct tsadc_table *table; + int table_num; }; struct rockchip_thermal_sensor { @@ -102,7 +109,7 @@ struct rockchip_thermal_data { enum tshut_polarity tshut_polarity; }; -/* TSADC V2 Sensor info define: */ +/* TSADC Sensor info define: */ #define TSADCV2_AUTO_CON 0x04 #define TSADCV2_INT_EN 0x08 #define TSADCV2_INT_PD 0x0c @@ -124,6 +131,8 @@ struct rockchip_thermal_data { #define TSADCV2_INT_PD_CLEAR_MASK ~BIT(8) #define TSADCV2_DATA_MASK 0xfff +#define TSADCV3_DATA_MASK 0x3ff + #define TSADCV2_HIGHT_INT_DEBOUNCE_COUNT 4 #define TSADCV2_HIGHT_TSHUT_DEBOUNCE_COUNT 4 #define TSADCV2_AUTO_PERIOD_TIME 250 /* msec */ @@ -172,21 +181,62 @@ static const struct tsadc_table v2_code_table[] = { {3421, 125000}, }; -static u32 rk_tsadcv2_temp_to_code(long temp) +static const struct tsadc_table v3_code_table[] = { + {0, -40000}, + {106, -40000}, + {108, -35000}, + {110, -30000}, + {112, -25000}, + {114, -20000}, + {116, -15000}, + {118, -10000}, + {120, -5000}, + {122, 0}, + {124, 5000}, + {126, 10000}, + {128, 15000}, + {130, 20000}, + {132, 25000}, + {134, 30000}, + {136, 35000}, + {138, 40000}, + {140, 45000}, + {142, 50000}, + {144, 55000}, + {146, 60000}, + {148, 65000}, + {150, 70000}, + {152, 75000}, + {154, 80000}, + {156, 85000}, + {158, 90000}, + {160, 95000}, + {162, 100000}, + {163, 105000}, + {165, 110000}, + {167, 115000}, + {169, 120000}, + {171, 125000}, + {TSADCV3_DATA_MASK, 125000}, +}; + +static u32 rk_tsadcv2_temp_to_code(const struct rockchip_tsadc_chip *chip, + long temp) { + const struct tsadc_table *table = chip->table; int high, low, mid; low = 0; - high = ARRAY_SIZE(v2_code_table) - 1; + high = chip->table_num - 1; mid = (high + low) / 2; - if (temp < v2_code_table[low].temp || temp > v2_code_table[high].temp) + if (temp < table[low].temp || temp > table[high].temp) return 0; while (low <= high) { - if (temp == v2_code_table[mid].temp) - return v2_code_table[mid].code; - else if (temp < v2_code_table[mid].temp) + if (temp == table[mid].temp) + return table[mid].code; + else if (temp < table[mid].temp) high = mid - 1; else low = mid + 1; @@ -235,16 +285,59 @@ static int rk_tsadcv2_code_to_temp(u32 code, int *temp) return 0; } +static int rk_tsadcv3_code_to_temp(u32 code, int *temp) +{ + unsigned int low = 1; + unsigned int high = ARRAY_SIZE(v3_code_table) - 1; + unsigned int mid = (low + high) / 2; + unsigned int num; + unsigned long denom; + + BUILD_BUG_ON(ARRAY_SIZE(v3_code_table) < 2); + + code &= TSADCV3_DATA_MASK; + if (code < v3_code_table[low].code) + return -EAGAIN; /* Incorrect reading */ + + while (low <= high) { + if (code >= v3_code_table[mid - 1].code && + code < v3_code_table[mid].code) + break; + else if (code > v3_code_table[mid].code) + low = mid + 1; + else + high = mid - 1; + mid = (low + high) / 2; + } + + /* + * The 5C granularity provided by the table is too much. Let's + * assume that the relationship between sensor readings and + * temperature between 2 table entries is linear and interpolate + * to produce less granular result. + */ + num = v3_code_table[mid].temp - v3_code_table[mid - 1].temp; + num *= code - v3_code_table[mid - 1].code; + denom = v3_code_table[mid].code - v3_code_table[mid - 1].code; + *temp = v3_code_table[mid - 1].temp + (num / denom); + + return 0; +} + /** - * rk_tsadcv2_initialize - initialize TASDC Controller - * (1) Set TSADCV2_AUTO_PERIOD, configure the interleave between - * every two accessing of TSADC in normal operation. - * (2) Set TSADCV2_AUTO_PERIOD_HT, configure the interleave between - * every two accessing of TSADC after the temperature is higher - * than COM_SHUT or COM_INT. - * (3) Set TSADCV2_HIGH_INT_DEBOUNCE and TSADC_HIGHT_TSHUT_DEBOUNCE, - * if the temperature is higher than COMP_INT or COMP_SHUT for - * "debounce" times, TSADC controller will generate interrupt or TSHUT. + * rk_tsadcv2_initialize - initialize TASDC Controller. + * + * (1) Set TSADC_V2_AUTO_PERIOD: + * Configure the interleave between every two accessing of + * TSADC in normal operation. + * + * (2) Set TSADCV2_AUTO_PERIOD_HT: + * Configure the interleave between every two accessing of + * TSADC after the temperature is higher than COM_SHUT or COM_INT. + * + * (3) Set TSADCV2_HIGH_INT_DEBOUNCE and TSADC_HIGHT_TSHUT_DEBOUNCE: + * If the temperature is higher than COMP_INT or COMP_SHUT for + * "debounce" times, TSADC controller will generate interrupt or TSHUT. */ static void rk_tsadcv2_initialize(void __iomem *regs, enum tshut_polarity tshut_polarity) @@ -286,6 +379,15 @@ static void rk_tsadcv2_control(void __iomem *regs, bool enable) writel_relaxed(val, regs + TSADCV2_AUTO_CON); } +static int rk_tsadcv3_get_temp(int chn, void __iomem *regs, int *temp) +{ + u32 val; + + val = readl_relaxed(regs + TSADCV2_DATA(chn)); + + return rk_tsadcv3_code_to_temp(val, temp); +} + static int rk_tsadcv2_get_temp(int chn, void __iomem *regs, int *temp) { u32 val; @@ -295,12 +397,11 @@ static int rk_tsadcv2_get_temp(int chn, void __iomem *regs, int *temp) return rk_tsadcv2_code_to_temp(val, temp); } -static void rk_tsadcv2_tshut_temp(int chn, void __iomem *regs, long temp) +static void rk_tsadcv2_tshut_value(int chn, void __iomem *regs, u32 value) { - u32 tshut_value, val; + u32 val; - tshut_value = rk_tsadcv2_temp_to_code(temp); - writel_relaxed(tshut_value, regs + TSADCV2_COMP_SHUT(chn)); + writel_relaxed(value, regs + TSADCV2_COMP_SHUT(chn)); /* TSHUT will be valid */ val = readl_relaxed(regs + TSADCV2_AUTO_CON); @@ -337,8 +438,31 @@ static const struct rockchip_tsadc_chip rk3288_tsadc_data = { .irq_ack = rk_tsadcv2_irq_ack, .control = rk_tsadcv2_control, .get_temp = rk_tsadcv2_get_temp, - .set_tshut_temp = rk_tsadcv2_tshut_temp, + .set_tshut_value = rk_tsadcv2_tshut_value, + .set_tshut_mode = rk_tsadcv2_tshut_mode, + + .table = v2_code_table, + .table_num = ARRAY_SIZE(v2_code_table), +}; + +static const struct rockchip_tsadc_chip rk3368_tsadc_data = { + .chn_id[SENSOR_CPU] = 0, /* cpu sensor is channel 0 */ + .chn_id[SENSOR_GPU] = 1, /* gpu sensor is channel 1 */ + .chn_num = 2, /* two channels for tsadc */ + + .tshut_mode = TSHUT_MODE_GPIO, /* default TSHUT via GPIO give PMIC */ + .tshut_polarity = TSHUT_LOW_ACTIVE, /* default TSHUT LOW ACTIVE */ + .tshut_temp = 95000, + + .initialize = rk_tsadcv2_initialize, + .irq_ack = rk_tsadcv2_irq_ack, + .control = rk_tsadcv2_control, + .get_temp = rk_tsadcv3_get_temp, + .set_tshut_value = rk_tsadcv2_tshut_value, .set_tshut_mode = rk_tsadcv2_tshut_mode, + + .table = v3_code_table, + .table_num = ARRAY_SIZE(v3_code_table), }; static const struct of_device_id of_rockchip_thermal_match[] = { @@ -346,6 +470,10 @@ static const struct of_device_id of_rockchip_thermal_match[] = { .compatible = "rockchip,rk3288-tsadc", .data = (void *)&rk3288_tsadc_data, }, + { + .compatible = "rockchip,rk3368-tsadc", + .data = (void *)&rk3368_tsadc_data, + }, { /* end */ }, }; MODULE_DEVICE_TABLE(of, of_rockchip_thermal_match); @@ -458,8 +586,10 @@ rockchip_thermal_register_sensor(struct platform_device *pdev, const struct rockchip_tsadc_chip *tsadc = thermal->chip; int error; + u32 tshut_value = rk_tsadcv2_temp_to_code(tsadc, thermal->tshut_temp); + tsadc->set_tshut_mode(id, thermal->regs, thermal->tshut_mode); - tsadc->set_tshut_temp(id, thermal->regs, thermal->tshut_temp); + tsadc->set_tshut_value(id, thermal->regs, tshut_value); sensor->thermal = thermal; sensor->id = id; @@ -660,6 +790,9 @@ static int __maybe_unused rockchip_thermal_resume(struct device *dev) int i; int error; + u32 tshut_value = rk_tsadcv2_temp_to_code(thermal->chip, + thermal->tshut_temp); + error = clk_enable(thermal->clk); if (error) return error; @@ -677,8 +810,8 @@ static int __maybe_unused rockchip_thermal_resume(struct device *dev) thermal->chip->set_tshut_mode(id, thermal->regs, thermal->tshut_mode); - thermal->chip->set_tshut_temp(id, thermal->regs, - thermal->tshut_temp); + thermal->chip->set_tshut_value(id, thermal->regs, + tshut_value); } thermal->chip->control(thermal->regs, true); -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v1 3/6] thermal: rockchip: Support the RK3368 SoCs in thermal driver 2015-10-29 7:14 ` [PATCH v1 3/6] thermal: rockchip: Support the RK3368 SoCs in thermal driver Caesar Wang @ 2015-11-03 17:48 ` Eduardo Valentin 2015-11-05 4:54 ` Caesar Wang 0 siblings, 1 reply; 9+ messages in thread From: Eduardo Valentin @ 2015-11-03 17:48 UTC (permalink / raw) To: Caesar Wang Cc: Heiko Stuebner, linux-rockchip, linux-pm, linux-kernel, Zhang Rui, linux-arm-kernel Hello Caesar, On Thu, Oct 29, 2015 at 03:14:15PM +0800, Caesar Wang wrote: > The RK3368 SoCs support to 2 channel TS-ADC, the temperature criteria > of each channel can be configurable. > > The system has two Temperature Sensors, channel 0 is for CPU, > and channel 1 is for GPU. Please improve your patch description. I dont think this patch only adds the support for RK3368. I see, for example, at least two other (maybe dependencies of the new chip support) changes: - conversion function improvement - tshut value/temperature configuration Could you please split this patch in smaller changes? > > Signed-off-by: Caesar Wang <wxt@rock-chips.com> > > --- > > Changes in v1: > - As Dmitry comment, make the conversion table in as a parameter. > Are you sure that this version implements this suggestion? > drivers/thermal/rockchip_thermal.c | 183 ++++++++++++++++++++++++++++++++----- > 1 file changed, 158 insertions(+), 25 deletions(-) > > diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c > index f96c151..4748a8e 100644 > --- a/drivers/thermal/rockchip_thermal.c > +++ b/drivers/thermal/rockchip_thermal.c > @@ -1,6 +1,9 @@ > /* > * Copyright (c) 2014, Fuzhou Rockchip Electronics Co., Ltd > * > + * Copyright (c) 2015, Fuzhou Rockchip Electronics Co., Ltd > + * Caesar Wang <wxt@rock-chips.com> > + * > * This program is free software; you can redistribute it and/or modify it > * under the terms and conditions of the GNU General Public License, > * version 2, as published by the Free Software Foundation. > @@ -75,8 +78,12 @@ struct rockchip_tsadc_chip { > > /* Per-sensor methods */ > int (*get_temp)(int chn, void __iomem *reg, int *temp); > - void (*set_tshut_temp)(int chn, void __iomem *reg, long temp); > + void (*set_tshut_value)(int chn, void __iomem *reg, u32 value); Do you have any explanation why do you need to change from temp to value? Can you include this in your patch description? > void (*set_tshut_mode)(int chn, void __iomem *reg, enum tshut_mode m); > + > + /* Per-table methods */ > + const struct tsadc_table *table; > + int table_num; > }; > > struct rockchip_thermal_sensor { > @@ -102,7 +109,7 @@ struct rockchip_thermal_data { > enum tshut_polarity tshut_polarity; > }; > > -/* TSADC V2 Sensor info define: */ > +/* TSADC Sensor info define: */ > #define TSADCV2_AUTO_CON 0x04 > #define TSADCV2_INT_EN 0x08 > #define TSADCV2_INT_PD 0x0c > @@ -124,6 +131,8 @@ struct rockchip_thermal_data { > #define TSADCV2_INT_PD_CLEAR_MASK ~BIT(8) > > #define TSADCV2_DATA_MASK 0xfff > +#define TSADCV3_DATA_MASK 0x3ff > + > #define TSADCV2_HIGHT_INT_DEBOUNCE_COUNT 4 > #define TSADCV2_HIGHT_TSHUT_DEBOUNCE_COUNT 4 > #define TSADCV2_AUTO_PERIOD_TIME 250 /* msec */ > @@ -172,21 +181,62 @@ static const struct tsadc_table v2_code_table[] = { > {3421, 125000}, > }; > > -static u32 rk_tsadcv2_temp_to_code(long temp) > +static const struct tsadc_table v3_code_table[] = { > + {0, -40000}, > + {106, -40000}, > + {108, -35000}, > + {110, -30000}, > + {112, -25000}, > + {114, -20000}, > + {116, -15000}, > + {118, -10000}, > + {120, -5000}, > + {122, 0}, > + {124, 5000}, > + {126, 10000}, > + {128, 15000}, > + {130, 20000}, > + {132, 25000}, > + {134, 30000}, > + {136, 35000}, > + {138, 40000}, > + {140, 45000}, > + {142, 50000}, > + {144, 55000}, > + {146, 60000}, > + {148, 65000}, > + {150, 70000}, > + {152, 75000}, > + {154, 80000}, > + {156, 85000}, > + {158, 90000}, > + {160, 95000}, > + {162, 100000}, > + {163, 105000}, > + {165, 110000}, > + {167, 115000}, > + {169, 120000}, > + {171, 125000}, > + {TSADCV3_DATA_MASK, 125000}, > +}; > + > +static u32 rk_tsadcv2_temp_to_code(const struct rockchip_tsadc_chip *chip, > + long temp) > { This function receives the chip structure as parameter... > + const struct tsadc_table *table = chip->table; > int high, low, mid; > > low = 0; > - high = ARRAY_SIZE(v2_code_table) - 1; > + high = chip->table_num - 1; > mid = (high + low) / 2; > > - if (temp < v2_code_table[low].temp || temp > v2_code_table[high].temp) > + if (temp < table[low].temp || temp > table[high].temp) > return 0; > > while (low <= high) { > - if (temp == v2_code_table[mid].temp) > - return v2_code_table[mid].code; > - else if (temp < v2_code_table[mid].temp) > + if (temp == table[mid].temp) > + return table[mid].code; > + else if (temp < table[mid].temp) > high = mid - 1; > else > low = mid + 1; And seams to do the work.. but.. I am assuming you have forgotten to continue the change in the remaining functions: rk_tsadcv2_code_to_temp: 215 216 /* 217 * The 5C granularity provided by the table is too much. Let's 218 * assume that the relationship between sensor readings and 219 * temperature between 2 table entries is linear and interpolate 220 * to produce less granular result. 221 */ 222 num = v2_code_table[mid].temp - v2_code_table[mid - 1].temp; 223 num *= v2_code_table[mid - 1].code - code; 224 denom = v2_code_table[mid - 1].code - v2_code_table[mid].code; 225 *temp = v2_code_table[mid - 1].temp + (num / denom); 226 Please finish the change in rk_tsadcv2_code_to_temp, to use chip->table, and > @@ -235,16 +285,59 @@ static int rk_tsadcv2_code_to_temp(u32 code, int *temp) > return 0; > } > > +static int rk_tsadcv3_code_to_temp(u32 code, int *temp) > +{ > + unsigned int low = 1; > + unsigned int high = ARRAY_SIZE(v3_code_table) - 1; > + unsigned int mid = (low + high) / 2; > + unsigned int num; > + unsigned long denom; > + > + BUILD_BUG_ON(ARRAY_SIZE(v3_code_table) < 2); > + > + code &= TSADCV3_DATA_MASK; > + if (code < v3_code_table[low].code) > + return -EAGAIN; /* Incorrect reading */ > + > + while (low <= high) { > + if (code >= v3_code_table[mid - 1].code && > + code < v3_code_table[mid].code) > + break; > + else if (code > v3_code_table[mid].code) > + low = mid + 1; > + else > + high = mid - 1; > + mid = (low + high) / 2; > + } > + > + /* > + * The 5C granularity provided by the table is too much. Let's > + * assume that the relationship between sensor readings and > + * temperature between 2 table entries is linear and interpolate > + * to produce less granular result. > + */ > + num = v3_code_table[mid].temp - v3_code_table[mid - 1].temp; > + num *= code - v3_code_table[mid - 1].code; > + denom = v3_code_table[mid].code - v3_code_table[mid - 1].code; > + *temp = v3_code_table[mid - 1].temp + (num / denom); > + > + return 0; > +} Do not add the above function, as it is a code duplication of rk_tsadcv2_code_to_temp. The above function, functionality wise, the same as rk_tsadcv2_code_to_temp, except that it uses a different table. The suggestion is to pass the table as parameter to rk_tsadcv2_code_to_temp, then just reuse rk_tsadcv2_code_to_temp in both cases. Would that work for you? > + > /** > - * rk_tsadcv2_initialize - initialize TASDC Controller > - * (1) Set TSADCV2_AUTO_PERIOD, configure the interleave between > - * every two accessing of TSADC in normal operation. > - * (2) Set TSADCV2_AUTO_PERIOD_HT, configure the interleave between > - * every two accessing of TSADC after the temperature is higher > - * than COM_SHUT or COM_INT. > - * (3) Set TSADCV2_HIGH_INT_DEBOUNCE and TSADC_HIGHT_TSHUT_DEBOUNCE, > - * if the temperature is higher than COMP_INT or COMP_SHUT for > - * "debounce" times, TSADC controller will generate interrupt or TSHUT. > + * rk_tsadcv2_initialize - initialize TASDC Controller. > + * > + * (1) Set TSADC_V2_AUTO_PERIOD: > + * Configure the interleave between every two accessing of > + * TSADC in normal operation. > + * > + * (2) Set TSADCV2_AUTO_PERIOD_HT: > + * Configure the interleave between every two accessing of > + * TSADC after the temperature is higher than COM_SHUT or COM_INT. > + * > + * (3) Set TSADCV2_HIGH_INT_DEBOUNCE and TSADC_HIGHT_TSHUT_DEBOUNCE: > + * If the temperature is higher than COMP_INT or COMP_SHUT for > + * "debounce" times, TSADC controller will generate interrupt or TSHUT. > */ > static void rk_tsadcv2_initialize(void __iomem *regs, > enum tshut_polarity tshut_polarity) > @@ -286,6 +379,15 @@ static void rk_tsadcv2_control(void __iomem *regs, bool enable) > writel_relaxed(val, regs + TSADCV2_AUTO_CON); > } > > +static int rk_tsadcv3_get_temp(int chn, void __iomem *regs, int *temp) > +{ > + u32 val; > + > + val = readl_relaxed(regs + TSADCV2_DATA(chn)); > + > + return rk_tsadcv3_code_to_temp(val, temp); > +} Same suggestion here. This function looks exactly the same as rk_tsadcv2_get_temp. can you just pass the chip as parameter, then? > + > static int rk_tsadcv2_get_temp(int chn, void __iomem *regs, int *temp) > { > u32 val; > @@ -295,12 +397,11 @@ static int rk_tsadcv2_get_temp(int chn, void __iomem *regs, int *temp) > return rk_tsadcv2_code_to_temp(val, temp); > } > > -static void rk_tsadcv2_tshut_temp(int chn, void __iomem *regs, long temp) > +static void rk_tsadcv2_tshut_value(int chn, void __iomem *regs, u32 value) > { > - u32 tshut_value, val; > + u32 val; > > - tshut_value = rk_tsadcv2_temp_to_code(temp); > - writel_relaxed(tshut_value, regs + TSADCV2_COMP_SHUT(chn)); > + writel_relaxed(value, regs + TSADCV2_COMP_SHUT(chn)); > > /* TSHUT will be valid */ > val = readl_relaxed(regs + TSADCV2_AUTO_CON); > @@ -337,8 +438,31 @@ static const struct rockchip_tsadc_chip rk3288_tsadc_data = { > .irq_ack = rk_tsadcv2_irq_ack, > .control = rk_tsadcv2_control, > .get_temp = rk_tsadcv2_get_temp, > - .set_tshut_temp = rk_tsadcv2_tshut_temp, > + .set_tshut_value = rk_tsadcv2_tshut_value, > + .set_tshut_mode = rk_tsadcv2_tshut_mode, > + > + .table = v2_code_table, > + .table_num = ARRAY_SIZE(v2_code_table), > +}; > + > +static const struct rockchip_tsadc_chip rk3368_tsadc_data = { > + .chn_id[SENSOR_CPU] = 0, /* cpu sensor is channel 0 */ > + .chn_id[SENSOR_GPU] = 1, /* gpu sensor is channel 1 */ > + .chn_num = 2, /* two channels for tsadc */ > + > + .tshut_mode = TSHUT_MODE_GPIO, /* default TSHUT via GPIO give PMIC */ > + .tshut_polarity = TSHUT_LOW_ACTIVE, /* default TSHUT LOW ACTIVE */ > + .tshut_temp = 95000, > + > + .initialize = rk_tsadcv2_initialize, > + .irq_ack = rk_tsadcv2_irq_ack, > + .control = rk_tsadcv2_control, > + .get_temp = rk_tsadcv3_get_temp, > + .set_tshut_value = rk_tsadcv2_tshut_value, > .set_tshut_mode = rk_tsadcv2_tshut_mode, > + > + .table = v3_code_table, > + .table_num = ARRAY_SIZE(v3_code_table), > }; > > static const struct of_device_id of_rockchip_thermal_match[] = { > @@ -346,6 +470,10 @@ static const struct of_device_id of_rockchip_thermal_match[] = { > .compatible = "rockchip,rk3288-tsadc", > .data = (void *)&rk3288_tsadc_data, > }, > + { > + .compatible = "rockchip,rk3368-tsadc", > + .data = (void *)&rk3368_tsadc_data, > + }, > { /* end */ }, > }; > MODULE_DEVICE_TABLE(of, of_rockchip_thermal_match); > @@ -458,8 +586,10 @@ rockchip_thermal_register_sensor(struct platform_device *pdev, > const struct rockchip_tsadc_chip *tsadc = thermal->chip; > int error; > > + u32 tshut_value = rk_tsadcv2_temp_to_code(tsadc, thermal->tshut_temp); > + > tsadc->set_tshut_mode(id, thermal->regs, thermal->tshut_mode); > - tsadc->set_tshut_temp(id, thermal->regs, thermal->tshut_temp); > + tsadc->set_tshut_value(id, thermal->regs, tshut_value); > > sensor->thermal = thermal; > sensor->id = id; > @@ -660,6 +790,9 @@ static int __maybe_unused rockchip_thermal_resume(struct device *dev) > int i; > int error; > > + u32 tshut_value = rk_tsadcv2_temp_to_code(thermal->chip, > + thermal->tshut_temp); > + > error = clk_enable(thermal->clk); > if (error) > return error; > @@ -677,8 +810,8 @@ static int __maybe_unused rockchip_thermal_resume(struct device *dev) > > thermal->chip->set_tshut_mode(id, thermal->regs, > thermal->tshut_mode); > - thermal->chip->set_tshut_temp(id, thermal->regs, > - thermal->tshut_temp); > + thermal->chip->set_tshut_value(id, thermal->regs, > + tshut_value); > } > > thermal->chip->control(thermal->regs, true); > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 3/6] thermal: rockchip: Support the RK3368 SoCs in thermal driver 2015-11-03 17:48 ` Eduardo Valentin @ 2015-11-05 4:54 ` Caesar Wang 0 siblings, 0 replies; 9+ messages in thread From: Caesar Wang @ 2015-11-05 4:54 UTC (permalink / raw) To: Eduardo Valentin, Caesar Wang Cc: Heiko Stuebner, linux-pm, linux-kernel, linux-rockchip, Zhang Rui, linux-arm-kernel Hello Eduardo, Thanks your comments. 在 2015年11月04日 01:48, Eduardo Valentin 写道: > Hello Caesar, > > On Thu, Oct 29, 2015 at 03:14:15PM +0800, Caesar Wang wrote: >> The RK3368 SoCs support to 2 channel TS-ADC, the temperature criteria >> of each channel can be configurable. >> >> The system has two Temperature Sensors, channel 0 is for CPU, >> and channel 1 is for GPU. > Please improve your patch description. I dont think this patch only > adds the support for RK3368. > > I see, for example, at least two other (maybe dependencies of the > new chip support) changes: > > - conversion function improvement > - tshut value/temperature configuration > > Could you please split this patch in smaller changes? Okay, Done. That's on my local oneline. 92ffb82 thermal: rockchip: Support the RK3368 SoCs in thermal drivers e4f5e61 thermal: rockchip: Add the flag for adc value increment or decrement b599a6b thermal: rockchip: improve the conversion function d629c52 thermal: rockchip: trivial: fix typo in commit I will send these in next version. >> Signed-off-by: Caesar Wang <wxt@rock-chips.com> >> >> --- >> >> Changes in v1: >> - As Dmitry comment, make the conversion table in as a parameter. >> > Are you sure that this version implements this suggestion? > > >> drivers/thermal/rockchip_thermal.c | 183 ++++++++++++++++++++++++++++++++----- >> 1 file changed, 158 insertions(+), 25 deletions(-) >> >> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c >> index f96c151..4748a8e 100644 >> --- a/drivers/thermal/rockchip_thermal.c >> +++ b/drivers/thermal/rockchip_thermal.c >> @@ -1,6 +1,9 @@ >> /* >> * Copyright (c) 2014, Fuzhou Rockchip Electronics Co., Ltd >> * >> + * Copyright (c) 2015, Fuzhou Rockchip Electronics Co., Ltd >> + * Caesar Wang <wxt@rock-chips.com> >> + * >> * This program is free software; you can redistribute it and/or modify it >> * under the terms and conditions of the GNU General Public License, >> * version 2, as published by the Free Software Foundation. >> @@ -75,8 +78,12 @@ struct rockchip_tsadc_chip { >> >> /* Per-sensor methods */ >> int (*get_temp)(int chn, void __iomem *reg, int *temp); >> - void (*set_tshut_temp)(int chn, void __iomem *reg, long temp); >> + void (*set_tshut_value)(int chn, void __iomem *reg, u32 value); > Do you have any explanation why do you need to change from temp to > value? Can you include this in your patch description? Okay, I think that's *not* really needed. I have removed this change. >> void (*set_tshut_mode)(int chn, void __iomem *reg, enum tshut_mode m); >> + >> + /* Per-table methods */ >> + const struct tsadc_table *table; >> + int table_num; >> }; >> >> struct rockchip_thermal_sensor { >> @@ -102,7 +109,7 @@ struct rockchip_thermal_data { >> enum tshut_polarity tshut_polarity; >> }; >> >> -/* TSADC V2 Sensor info define: */ >> +/* TSADC Sensor info define: */ >> #define TSADCV2_AUTO_CON 0x04 >> #define TSADCV2_INT_EN 0x08 >> #define TSADCV2_INT_PD 0x0c >> @@ -124,6 +131,8 @@ struct rockchip_thermal_data { >> #define TSADCV2_INT_PD_CLEAR_MASK ~BIT(8) >> >> #define TSADCV2_DATA_MASK 0xfff >> +#define TSADCV3_DATA_MASK 0x3ff >> + >> #define TSADCV2_HIGHT_INT_DEBOUNCE_COUNT 4 >> #define TSADCV2_HIGHT_TSHUT_DEBOUNCE_COUNT 4 >> #define TSADCV2_AUTO_PERIOD_TIME 250 /* msec */ >> @@ -172,21 +181,62 @@ static const struct tsadc_table v2_code_table[] = { >> {3421, 125000}, >> }; >> >> -static u32 rk_tsadcv2_temp_to_code(long temp) >> +static const struct tsadc_table v3_code_table[] = { >> + {0, -40000}, >> + {106, -40000}, >> + {108, -35000}, >> + {110, -30000}, >> + {112, -25000}, >> + {114, -20000}, >> + {116, -15000}, >> + {118, -10000}, >> + {120, -5000}, >> + {122, 0}, >> + {124, 5000}, >> + {126, 10000}, >> + {128, 15000}, >> + {130, 20000}, >> + {132, 25000}, >> + {134, 30000}, >> + {136, 35000}, >> + {138, 40000}, >> + {140, 45000}, >> + {142, 50000}, >> + {144, 55000}, >> + {146, 60000}, >> + {148, 65000}, >> + {150, 70000}, >> + {152, 75000}, >> + {154, 80000}, >> + {156, 85000}, >> + {158, 90000}, >> + {160, 95000}, >> + {162, 100000}, >> + {163, 105000}, >> + {165, 110000}, >> + {167, 115000}, >> + {169, 120000}, >> + {171, 125000}, >> + {TSADCV3_DATA_MASK, 125000}, >> +}; >> + >> +static u32 rk_tsadcv2_temp_to_code(const struct rockchip_tsadc_chip *chip, >> + long temp) >> { > This function receives the chip structure as parameter... Okay, we should do the table as a parameter. >> + const struct tsadc_table *table = chip->table; >> int high, low, mid; >> >> low = 0; >> - high = ARRAY_SIZE(v2_code_table) - 1; >> + high = chip->table_num - 1; >> mid = (high + low) / 2; >> >> - if (temp < v2_code_table[low].temp || temp > v2_code_table[high].temp) >> + if (temp < table[low].temp || temp > table[high].temp) >> return 0; >> >> while (low <= high) { >> - if (temp == v2_code_table[mid].temp) >> - return v2_code_table[mid].code; >> - else if (temp < v2_code_table[mid].temp) >> + if (temp == table[mid].temp) >> + return table[mid].code; >> + else if (temp < table[mid].temp) >> high = mid - 1; >> else >> low = mid + 1; > And seams to do the work.. but.. > > I am assuming you have forgotten to continue the change in the remaining > functions: rk_tsadcv2_code_to_temp: > > 215 > 216 /* > 217 * The 5C granularity provided by the table is too much. Let's > 218 * assume that the relationship between sensor readings and > 219 * temperature between 2 table entries is linear and interpolate > 220 * to produce less granular result. > 221 */ > 222 num = v2_code_table[mid].temp - v2_code_table[mid - 1].temp; > 223 num *= v2_code_table[mid - 1].code - code; > 224 denom = v2_code_table[mid - 1].code - v2_code_table[mid].code; > 225 *temp = v2_code_table[mid - 1].temp + (num / denom); > 226 > > > Please finish the change in rk_tsadcv2_code_to_temp, to use chip->table, and > > > >> @@ -235,16 +285,59 @@ static int rk_tsadcv2_code_to_temp(u32 code, int *temp) >> return 0; >> } >> >> +static int rk_tsadcv3_code_to_temp(u32 code, int *temp) >> +{ >> + unsigned int low = 1; >> + unsigned int high = ARRAY_SIZE(v3_code_table) - 1; >> + unsigned int mid = (low + high) / 2; >> + unsigned int num; >> + unsigned long denom; >> + >> + BUILD_BUG_ON(ARRAY_SIZE(v3_code_table) < 2); >> + >> + code &= TSADCV3_DATA_MASK; >> + if (code < v3_code_table[low].code) >> + return -EAGAIN; /* Incorrect reading */ >> + >> + while (low <= high) { >> + if (code >= v3_code_table[mid - 1].code && >> + code < v3_code_table[mid].code) >> + break; >> + else if (code > v3_code_table[mid].code) >> + low = mid + 1; >> + else >> + high = mid - 1; >> + mid = (low + high) / 2; >> + } >> + >> + /* >> + * The 5C granularity provided by the table is too much. Let's >> + * assume that the relationship between sensor readings and >> + * temperature between 2 table entries is linear and interpolate >> + * to produce less granular result. >> + */ >> + num = v3_code_table[mid].temp - v3_code_table[mid - 1].temp; >> + num *= code - v3_code_table[mid - 1].code; >> + denom = v3_code_table[mid].code - v3_code_table[mid - 1].code; >> + *temp = v3_code_table[mid - 1].temp + (num / denom); >> + >> + return 0; >> +} > Do not add the above function, as it is a code duplication of > rk_tsadcv2_code_to_temp. The above function, functionality wise, the same > as rk_tsadcv2_code_to_temp, except that it uses a different table. > > The suggestion is to pass the table as parameter to rk_tsadcv2_code_to_temp, > then just reuse rk_tsadcv2_code_to_temp in both cases. > > Would that work for you? Thanks, I think that's ok on next version. >> + >> /** >> - * rk_tsadcv2_initialize - initialize TASDC Controller >> - * (1) Set TSADCV2_AUTO_PERIOD, configure the interleave between >> - * every two accessing of TSADC in normal operation. >> - * (2) Set TSADCV2_AUTO_PERIOD_HT, configure the interleave between >> - * every two accessing of TSADC after the temperature is higher >> - * than COM_SHUT or COM_INT. >> - * (3) Set TSADCV2_HIGH_INT_DEBOUNCE and TSADC_HIGHT_TSHUT_DEBOUNCE, >> - * if the temperature is higher than COMP_INT or COMP_SHUT for >> - * "debounce" times, TSADC controller will generate interrupt or TSHUT. >> + * rk_tsadcv2_initialize - initialize TASDC Controller. >> + * >> + * (1) Set TSADC_V2_AUTO_PERIOD: >> + * Configure the interleave between every two accessing of >> + * TSADC in normal operation. >> + * >> + * (2) Set TSADCV2_AUTO_PERIOD_HT: >> + * Configure the interleave between every two accessing of >> + * TSADC after the temperature is higher than COM_SHUT or COM_INT. >> + * >> + * (3) Set TSADCV2_HIGH_INT_DEBOUNCE and TSADC_HIGHT_TSHUT_DEBOUNCE: >> + * If the temperature is higher than COMP_INT or COMP_SHUT for >> + * "debounce" times, TSADC controller will generate interrupt or TSHUT. >> */ >> static void rk_tsadcv2_initialize(void __iomem *regs, >> enum tshut_polarity tshut_polarity) >> @@ -286,6 +379,15 @@ static void rk_tsadcv2_control(void __iomem *regs, bool enable) >> writel_relaxed(val, regs + TSADCV2_AUTO_CON); >> } >> >> +static int rk_tsadcv3_get_temp(int chn, void __iomem *regs, int *temp) >> +{ >> + u32 val; >> + >> + val = readl_relaxed(regs + TSADCV2_DATA(chn)); >> + >> + return rk_tsadcv3_code_to_temp(val, temp); >> +} > Same suggestion here. This function looks exactly the same as rk_tsadcv2_get_temp. can you just pass the chip as parameter, then? Done, make a table as a parameter. >> + >> static int rk_tsadcv2_get_temp(int chn, void __iomem *regs, int *temp) >> { >> u32 val; >> @@ -295,12 +397,11 @@ static int rk_tsadcv2_get_temp(int chn, void __iomem *regs, int *temp) >> return rk_tsadcv2_code_to_temp(val, temp); >> } >> >> -static void rk_tsadcv2_tshut_temp(int chn, void __iomem *regs, long temp) >> +static void rk_tsadcv2_tshut_value(int chn, void __iomem *regs, u32 value) >> { >> - u32 tshut_value, val; >> + u32 val; >> >> - tshut_value = rk_tsadcv2_temp_to_code(temp); >> - writel_relaxed(tshut_value, regs + TSADCV2_COMP_SHUT(chn)); >> + writel_relaxed(value, regs + TSADCV2_COMP_SHUT(chn)); >> >> /* TSHUT will be valid */ >> val = readl_relaxed(regs + TSADCV2_AUTO_CON); >> @@ -337,8 +438,31 @@ static const struct rockchip_tsadc_chip rk3288_tsadc_data = { >> .irq_ack = rk_tsadcv2_irq_ack, >> .control = rk_tsadcv2_control, >> .get_temp = rk_tsadcv2_get_temp, >> - .set_tshut_temp = rk_tsadcv2_tshut_temp, >> + .set_tshut_value = rk_tsadcv2_tshut_value, >> + .set_tshut_mode = rk_tsadcv2_tshut_mode, >> + >> + .table = v2_code_table, >> + .table_num = ARRAY_SIZE(v2_code_table), >> +}; >> + >> +static const struct rockchip_tsadc_chip rk3368_tsadc_data = { >> + .chn_id[SENSOR_CPU] = 0, /* cpu sensor is channel 0 */ >> + .chn_id[SENSOR_GPU] = 1, /* gpu sensor is channel 1 */ >> + .chn_num = 2, /* two channels for tsadc */ >> + >> + .tshut_mode = TSHUT_MODE_GPIO, /* default TSHUT via GPIO give PMIC */ >> + .tshut_polarity = TSHUT_LOW_ACTIVE, /* default TSHUT LOW ACTIVE */ >> + .tshut_temp = 95000, >> + >> + .initialize = rk_tsadcv2_initialize, >> + .irq_ack = rk_tsadcv2_irq_ack, >> + .control = rk_tsadcv2_control, >> + .get_temp = rk_tsadcv3_get_temp, >> + .set_tshut_value = rk_tsadcv2_tshut_value, >> .set_tshut_mode = rk_tsadcv2_tshut_mode, >> + >> + .table = v3_code_table, >> + .table_num = ARRAY_SIZE(v3_code_table), >> }; >> >> static const struct of_device_id of_rockchip_thermal_match[] = { >> @@ -346,6 +470,10 @@ static const struct of_device_id of_rockchip_thermal_match[] = { >> .compatible = "rockchip,rk3288-tsadc", >> .data = (void *)&rk3288_tsadc_data, >> }, >> + { >> + .compatible = "rockchip,rk3368-tsadc", >> + .data = (void *)&rk3368_tsadc_data, >> + }, >> { /* end */ }, >> }; >> MODULE_DEVICE_TABLE(of, of_rockchip_thermal_match); >> @@ -458,8 +586,10 @@ rockchip_thermal_register_sensor(struct platform_device *pdev, >> const struct rockchip_tsadc_chip *tsadc = thermal->chip; >> int error; >> >> + u32 tshut_value = rk_tsadcv2_temp_to_code(tsadc, thermal->tshut_temp); >> + >> tsadc->set_tshut_mode(id, thermal->regs, thermal->tshut_mode); >> - tsadc->set_tshut_temp(id, thermal->regs, thermal->tshut_temp); >> + tsadc->set_tshut_value(id, thermal->regs, tshut_value); >> >> sensor->thermal = thermal; >> sensor->id = id; >> @@ -660,6 +790,9 @@ static int __maybe_unused rockchip_thermal_resume(struct device *dev) >> int i; >> int error; >> >> + u32 tshut_value = rk_tsadcv2_temp_to_code(thermal->chip, >> + thermal->tshut_temp); >> + >> error = clk_enable(thermal->clk); >> if (error) >> return error; >> @@ -677,8 +810,8 @@ static int __maybe_unused rockchip_thermal_resume(struct device *dev) >> >> thermal->chip->set_tshut_mode(id, thermal->regs, >> thermal->tshut_mode); >> - thermal->chip->set_tshut_temp(id, thermal->regs, >> - thermal->tshut_temp); >> + thermal->chip->set_tshut_value(id, thermal->regs, >> + tshut_value); >> } >> >> thermal->chip->control(thermal->regs, true); >> -- >> 1.9.1 >> > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- Thanks, Caesar ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v1 4/6] arm64: dts: Add the thermal data found on RK3368 2015-10-29 7:14 [PATCH v1 0/6] Support the thermal for RK3368 SoCs Caesar Wang ` (2 preceding siblings ...) 2015-10-29 7:14 ` [PATCH v1 3/6] thermal: rockchip: Support the RK3368 SoCs in thermal driver Caesar Wang @ 2015-10-29 7:14 ` Caesar Wang 2015-10-29 7:14 ` [PATCH v1 5/6] arm64: dts: Add main Thermal info to rk3368.dtsi Caesar Wang 2015-10-29 7:14 ` [PATCH v1 6/6] arm64: dts: Enable the Thermal on R88 board Caesar Wang 5 siblings, 0 replies; 9+ messages in thread From: Caesar Wang @ 2015-10-29 7:14 UTC (permalink / raw) To: Heiko Stuebner, Eduardo Valentin Cc: linux-rockchip, Caesar Wang, devicetree, Kumar Gala, linux-kernel, Ian Campbell, Rob Herring, Dmitry Torokhov, Pawel Moll, Will Deacon, Mark Rutland, Catalin Marinas, linux-arm-kernel This patchset add the thermal for RK3368 dts, Since the two CPU clusters, with four CPU core for each cluster, One cluster is optimized for high-performance(big cluster) and the othe is optimized for low power(little cluster). This patch adds the second order for thermal throttle, and the critical temperature for thermal over-tempeature protection on Software. Signed-off-by: Caesar Wang <wxt@rock-chips.com> --- Changes in v1: None arch/arm64/boot/dts/rockchip/rk3368-thermal.dtsi | 112 +++++++++++++++++++++++ 1 file changed, 112 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3368-thermal.dtsi diff --git a/arch/arm64/boot/dts/rockchip/rk3368-thermal.dtsi b/arch/arm64/boot/dts/rockchip/rk3368-thermal.dtsi new file mode 100644 index 0000000..a10010f --- /dev/null +++ b/arch/arm64/boot/dts/rockchip/rk3368-thermal.dtsi @@ -0,0 +1,112 @@ +/* + * Device Tree Source for RK3368 SoC thermal + * + * Copyright (c) 2015, Fuzhou Rockchip Electronics Co., Ltd + * Caesar Wang <wxt@rock-chips.com> + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This file is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of the + * License, or (at your option) any later version. + * + * This file is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively, + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use, + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */ + +#include <dt-bindings/thermal/thermal.h> + +cpu_thermal: cpu_thermal { + polling-delay-passive = <100>; /* milliseconds */ + polling-delay = <5000>; /* milliseconds */ + + thermal-sensors = <&tsadc 0>; + + trips { + cpu_alert0: cpu_alert0 { + temperature = <75000>; /* millicelsius */ + hysteresis = <2000>; /* millicelsius */ + type = "passive"; + }; + cpu_alert1: cpu_alert1 { + temperature = <80000>; /* millicelsius */ + hysteresis = <2000>; /* millicelsius */ + type = "passive"; + }; + cpu_crit: cpu_crit { + temperature = <95000>; /* millicelsius */ + hysteresis = <2000>; /* millicelsius */ + type = "critical"; + }; + }; + + cooling-maps { + map0 { + trip = <&cpu_alert0>; + cooling-device = + <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + }; + map1 { + trip = <&cpu_alert1>; + cooling-device = + <&cpu_l0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + }; + }; +}; + +gpu_thermal: gpu_thermal { + polling-delay-passive = <100>; /* milliseconds */ + polling-delay = <5000>; /* milliseconds */ + + thermal-sensors = <&tsadc 1>; + + trips { + gpu_alert0: gpu_alert0 { + temperature = <80000>; /* millicelsius */ + hysteresis = <2000>; /* millicelsius */ + type = "passive"; + }; + gpu_crit: gpu_crit { + temperature = <1150000>; /* millicelsius */ + hysteresis = <2000>; /* millicelsius */ + type = "critical"; + }; + }; + + cooling-maps { + map0 { + trip = <&gpu_alert0>; + cooling-device = + <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + }; + }; +}; -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v1 5/6] arm64: dts: Add main Thermal info to rk3368.dtsi 2015-10-29 7:14 [PATCH v1 0/6] Support the thermal for RK3368 SoCs Caesar Wang ` (3 preceding siblings ...) 2015-10-29 7:14 ` [PATCH v1 4/6] arm64: dts: Add the thermal data found on RK3368 Caesar Wang @ 2015-10-29 7:14 ` Caesar Wang 2015-10-29 7:14 ` [PATCH v1 6/6] arm64: dts: Enable the Thermal on R88 board Caesar Wang 5 siblings, 0 replies; 9+ messages in thread From: Caesar Wang @ 2015-10-29 7:14 UTC (permalink / raw) To: Heiko Stuebner, Eduardo Valentin Cc: linux-rockchip, Caesar Wang, devicetree, Lorenzo Pieralisi, Kumar Gala, linux-kernel, Ian Campbell, Rob Herring, Pawel Moll, Will Deacon, Mark Rutland, Olof Johansson, Catalin Marinas, linux-arm-kernel This patch add the thermal needed info on RK3368. Meanwhile, support the trips to throttle for thermal. Signed-off-by: Caesar Wang <wxt@rock-chips.com> --- Changes in v1: - support the opt gpio pinctrl state arch/arm64/boot/dts/rockchip/rk3368.dtsi | 36 ++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi index cc093a4..7207293 100644 --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi @@ -45,6 +45,7 @@ #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/pinctrl/rockchip.h> +#include <dt-bindings/thermal/thermal.h> / { compatible = "rockchip,rk3368"; @@ -123,6 +124,8 @@ reg = <0x0 0x0>; cpu-idle-states = <&cpu_sleep>; enable-method = "psci"; + + #cooling-cells = <2>; /* min followed by max */ }; cpu_l1: cpu@1 { @@ -155,6 +158,8 @@ reg = <0x0 0x100>; cpu-idle-states = <&cpu_sleep>; enable-method = "psci"; + + #cooling-cells = <2>; /* min followed by max */ }; cpu_b1: cpu@101 { @@ -404,6 +409,27 @@ status = "disabled"; }; + thermal-zones { + #include "rk3368-thermal.dtsi" + }; + + tsadc: tsadc@ff280000 { + compatible = "rockchip,rk3368-tsadc"; + reg = <0x0 0xff280000 0x0 0x100>; + interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cru SCLK_TSADC>, <&cru PCLK_TSADC>; + clock-names = "tsadc", "apb_pclk"; + resets = <&cru SRST_TSADC>; + reset-names = "tsadc-apb"; + pinctrl-names = "init", "default", "sleep"; + pinctrl-0 = <&otp_gpio>; + pinctrl-1 = <&otp_out>; + pinctrl-2 = <&otp_gpio>; + #thermal-sensor-cells = <1>; + rockchip,hw-tshut-temp = <95000>; + status = "disabled"; + }; + gmac: ethernet@ff290000 { compatible = "rockchip,rk3368-gmac"; reg = <0x0 0xff290000 0x0 0x10000>; @@ -829,6 +855,16 @@ }; }; + tsadc { + otp_out: otp-gpio { + rockchip,pins = <0 10 RK_FUNC_GPIO &pcfg_pull_none>; + }; + + otp_out: otp-out { + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_none>; + }; + }; + uart0 { uart0_xfer: uart0-xfer { rockchip,pins = <2 24 RK_FUNC_1 &pcfg_pull_up>, -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v1 6/6] arm64: dts: Enable the Thermal on R88 board 2015-10-29 7:14 [PATCH v1 0/6] Support the thermal for RK3368 SoCs Caesar Wang ` (4 preceding siblings ...) 2015-10-29 7:14 ` [PATCH v1 5/6] arm64: dts: Add main Thermal info to rk3368.dtsi Caesar Wang @ 2015-10-29 7:14 ` Caesar Wang 5 siblings, 0 replies; 9+ messages in thread From: Caesar Wang @ 2015-10-29 7:14 UTC (permalink / raw) To: Heiko Stuebner, Eduardo Valentin Cc: linux-rockchip, Caesar Wang, devicetree, Olof Johansson, Kumar Gala, linux-kernel, Ian Campbell, Rob Herring, Pawel Moll, Will Deacon, Mark Rutland, Catalin Marinas, linux-arm-kernel This patch enable the TS-ADC. When a thermal temperature is invoked use the CRU to reset the chip on R88 board. TSHUT is low active on this board. Signed-off-by: Caesar Wang <wxt@rock-chips.com> --- Changes in v1: None arch/arm64/boot/dts/rockchip/rk3368-r88.dts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3368-r88.dts b/arch/arm64/boot/dts/rockchip/rk3368-r88.dts index 401a812..7684426a 100644 --- a/arch/arm64/boot/dts/rockchip/rk3368-r88.dts +++ b/arch/arm64/boot/dts/rockchip/rk3368-r88.dts @@ -336,6 +336,12 @@ status = "okay"; }; +&tsadc { + rockchip,hw-tshut-mode = <0>; /* tshut mode 0:CRU 1:GPIO */ + rockchip,hw-tshut-polarity = <0>; /* tshut polarity 0:LOW 1:HIGH */ + status = "okay"; +} + &uart2 { status = "okay"; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-11-05 4:54 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-10-29 7:14 [PATCH v1 0/6] Support the thermal for RK3368 SoCs Caesar Wang 2015-10-29 7:14 ` [PATCH v1 1/6] dt-bindings: rockchip-thermal: Support the RK3368 SoCs compatible Caesar Wang 2015-10-29 7:14 ` [PATCH v1 2/6] thermal: rockchip: better to compatible the driver for different SoCs Caesar Wang 2015-10-29 7:14 ` [PATCH v1 3/6] thermal: rockchip: Support the RK3368 SoCs in thermal driver Caesar Wang 2015-11-03 17:48 ` Eduardo Valentin 2015-11-05 4:54 ` Caesar Wang 2015-10-29 7:14 ` [PATCH v1 4/6] arm64: dts: Add the thermal data found on RK3368 Caesar Wang 2015-10-29 7:14 ` [PATCH v1 5/6] arm64: dts: Add main Thermal info to rk3368.dtsi Caesar Wang 2015-10-29 7:14 ` [PATCH v1 6/6] arm64: dts: Enable the Thermal on R88 board Caesar Wang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).