* [PATCH] drivers:staging:gdm724x Fix comparison to NULL could be written like
@ 2015-10-30 14:54 Bogicevic Sasa
2015-10-31 7:53 ` Sudip Mukherjee
0 siblings, 1 reply; 3+ messages in thread
From: Bogicevic Sasa @ 2015-10-30 14:54 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, devel, Bogicevic Sasa
This fixes all messages from checkpatch.pl about comparison to NULL
could be written according to coding style preferences
Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
---
drivers/staging/gdm724x/gdm_mux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
index e416012..c70e8b8 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -489,7 +489,7 @@ static int init_usb(struct mux_dev *mux_dev)
for (i = 0; i < MAX_ISSUE_NUM * 2; i++) {
r = alloc_mux_rx();
- if (r == NULL) {
+ if (!r) {
ret = -ENOMEM;
break;
}
@@ -657,7 +657,7 @@ static struct usb_driver gdm_mux_driver = {
static int __init gdm_usb_mux_init(void)
{
mux_rx_wq = create_workqueue("mux_rx_wq");
- if (mux_rx_wq == NULL) {
+ if (!mux_rx_wq) {
pr_err("work queue create fail\n");
return -1;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers:staging:gdm724x Fix comparison to NULL could be written like
2015-10-30 14:54 [PATCH] drivers:staging:gdm724x Fix comparison to NULL could be written like Bogicevic Sasa
@ 2015-10-31 7:53 ` Sudip Mukherjee
2015-10-31 9:28 ` Bogicevic Sasa
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2015-10-31 7:53 UTC (permalink / raw)
To: Bogicevic Sasa; +Cc: gregkh, devel, linux-kernel
On Fri, Oct 30, 2015 at 03:54:03PM +0100, Bogicevic Sasa wrote:
> This fixes all messages from checkpatch.pl about comparison to NULL
> could be written according to coding style preferences
>
> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
> ---
For all your next patches, either they have already deen done or they
will not apply because of some other change in that part.
Are you still using the stable tree?
regards
sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers:staging:gdm724x Fix comparison to NULL could be written like
2015-10-31 7:53 ` Sudip Mukherjee
@ 2015-10-31 9:28 ` Bogicevic Sasa
0 siblings, 0 replies; 3+ messages in thread
From: Bogicevic Sasa @ 2015-10-31 9:28 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: gregkh, devel, linux-kernel
On 10/31, Sudip Mukherjee wrote:
>On Fri, Oct 30, 2015 at 03:54:03PM +0100, Bogicevic Sasa wrote:
>> This fixes all messages from checkpatch.pl about comparison to NULL
>> could be written according to coding style preferences
>>
>> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
>> ---
>
>For all your next patches, either they have already deen done or they
>will not apply because of some other change in that part.
>
>Are you still using the stable tree?
>
>regards
>sudip
Not a lot of work but all for nothing :) I cloned staging but didn't
switch to staging-testing branch :( No worries I will start again,
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-31 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-30 14:54 [PATCH] drivers:staging:gdm724x Fix comparison to NULL could be written like Bogicevic Sasa
2015-10-31 7:53 ` Sudip Mukherjee
2015-10-31 9:28 ` Bogicevic Sasa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).