linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] percpu: remove PERCPU_ENOUGH_ROOM which is stale definition
@ 2015-11-04 13:26 Jungseok Lee
  2015-11-16 15:55 ` Tejun Heo
  0 siblings, 1 reply; 3+ messages in thread
From: Jungseok Lee @ 2015-11-04 13:26 UTC (permalink / raw)
  To: tj, cl, tony.luck, fenghua.yu, linux-mm, linux-ia64; +Cc: linux-kernel

As pure cleanup, this patch removes PERCPU_ENOUGH_ROOM which is not
used any more. That is, no code refers to the definition.

Acked-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Jungseok Lee <jungseoklee85@gmail.com>
---
I've kept Acked-by from Christoph since there is no change in generic
percpu code between v1 and v2.

Changes since v1:
- Removed PERCPU_ENOUGH_ROOM from ia64

 arch/ia64/include/asm/percpu.h | 2 --
 include/linux/percpu.h         | 6 ------
 2 files changed, 8 deletions(-)

diff --git a/arch/ia64/include/asm/percpu.h b/arch/ia64/include/asm/percpu.h
index 0ec484d..b929579 100644
--- a/arch/ia64/include/asm/percpu.h
+++ b/arch/ia64/include/asm/percpu.h
@@ -6,8 +6,6 @@
  *	David Mosberger-Tang <davidm@hpl.hp.com>
  */
 
-#define PERCPU_ENOUGH_ROOM PERCPU_PAGE_SIZE
-
 #ifdef __ASSEMBLY__
 # define THIS_CPU(var)	(var)  /* use this to mark accesses to per-CPU variables... */
 #else /* !__ASSEMBLY__ */
diff --git a/include/linux/percpu.h b/include/linux/percpu.h
index caebf2a..4bc6daf 100644
--- a/include/linux/percpu.h
+++ b/include/linux/percpu.h
@@ -18,12 +18,6 @@
 #define PERCPU_MODULE_RESERVE		0
 #endif
 
-#ifndef PERCPU_ENOUGH_ROOM
-#define PERCPU_ENOUGH_ROOM						\
-	(ALIGN(__per_cpu_end - __per_cpu_start, SMP_CACHE_BYTES) +	\
-	 PERCPU_MODULE_RESERVE)
-#endif
-
 /* minimum unit size, also is the maximum supported allocation size */
 #define PCPU_MIN_UNIT_SIZE		PFN_ALIGN(32 << 10)
 
-- 
2.5.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] percpu: remove PERCPU_ENOUGH_ROOM which is stale definition
  2015-11-04 13:26 [PATCH v2] percpu: remove PERCPU_ENOUGH_ROOM which is stale definition Jungseok Lee
@ 2015-11-16 15:55 ` Tejun Heo
  2015-11-17 12:25   ` Jungseok Lee
  0 siblings, 1 reply; 3+ messages in thread
From: Tejun Heo @ 2015-11-16 15:55 UTC (permalink / raw)
  To: Jungseok Lee
  Cc: cl, tony.luck, fenghua.yu, linux-mm, linux-ia64, linux-kernel

On Wed, Nov 04, 2015 at 01:26:07PM +0000, Jungseok Lee wrote:
> As pure cleanup, this patch removes PERCPU_ENOUGH_ROOM which is not
> used any more. That is, no code refers to the definition.
> 
> Acked-by: Christoph Lameter <cl@linux.com>
> Signed-off-by: Jungseok Lee <jungseoklee85@gmail.com>

Applied to percpu/for-4.5.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] percpu: remove PERCPU_ENOUGH_ROOM which is stale definition
  2015-11-16 15:55 ` Tejun Heo
@ 2015-11-17 12:25   ` Jungseok Lee
  0 siblings, 0 replies; 3+ messages in thread
From: Jungseok Lee @ 2015-11-17 12:25 UTC (permalink / raw)
  To: Tejun Heo; +Cc: cl, tony.luck, fenghua.yu, linux-mm, linux-ia64, linux-kernel

On Nov 17, 2015, at 12:55 AM, Tejun Heo wrote:

Dear Tejun,

> On Wed, Nov 04, 2015 at 01:26:07PM +0000, Jungseok Lee wrote:
>> As pure cleanup, this patch removes PERCPU_ENOUGH_ROOM which is not
>> used any more. That is, no code refers to the definition.
>> 
>> Acked-by: Christoph Lameter <cl@linux.com>
>> Signed-off-by: Jungseok Lee <jungseoklee85@gmail.com>
> 
> Applied to percpu/for-4.5.

I don't know how to handle this one as not getting feedbacks from ia64
side. Thanks for taking caring of this one!

Best Regards
Jungseok Lee

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-11-17 12:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-04 13:26 [PATCH v2] percpu: remove PERCPU_ENOUGH_ROOM which is stale definition Jungseok Lee
2015-11-16 15:55 ` Tejun Heo
2015-11-17 12:25   ` Jungseok Lee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).