* [PATCH] misc: mic: ERR_PTR expects -Exxx
@ 2015-11-20 8:14 Rasmus Villemoes
0 siblings, 0 replies; only message in thread
From: Rasmus Villemoes @ 2015-11-20 8:14 UTC (permalink / raw)
To: Sudeep Dutt, Greg Kroah-Hartman, Nikhil Rao, Ashutosh Dixit
Cc: Rasmus Villemoes, linux-kernel
These wouldn't be recognized by IS_ERR. There's no actual harm done,
since the only caller ignores the return value.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/misc/mic/scif/scif_dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/mic/scif/scif_dma.c b/drivers/misc/mic/scif/scif_dma.c
index 95a13c629a8e..f998daad1993 100644
--- a/drivers/misc/mic/scif/scif_dma.c
+++ b/drivers/misc/mic/scif/scif_dma.c
@@ -293,13 +293,13 @@ scif_add_mmu_notifier(struct mm_struct *mm, struct scif_endpt *ep)
= kzalloc(sizeof(*mmn), GFP_KERNEL);
if (!mmn)
- return ERR_PTR(ENOMEM);
+ return ERR_PTR(-ENOMEM);
scif_init_mmu_notifier(mmn, current->mm, ep);
if (mmu_notifier_register(&mmn->ep_mmu_notifier,
current->mm)) {
kfree(mmn);
- return ERR_PTR(EBUSY);
+ return ERR_PTR(-EBUSY);
}
list_add(&mmn->list, &ep->rma_info.mmn_list);
return mmn;
--
2.6.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-11-20 8:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-20 8:14 [PATCH] misc: mic: ERR_PTR expects -Exxx Rasmus Villemoes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).