linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	tgraf@suug.ch, fengguang.wu@intel.com, wfg@linux.intel.com,
	lkp@01.org
Subject: [PATCH v2 4/4] rhashtable-test: allow to retry even if -ENOMEM was returned
Date: Fri, 20 Nov 2015 18:17:20 +0100	[thread overview]
Message-ID: <1448039840-11367-5-git-send-email-phil@nwl.cc> (raw)
In-Reply-To: <1448039840-11367-1-git-send-email-phil@nwl.cc>

This is rather a hack to expose the current issue with rhashtable to
under high pressure sometimes return -ENOMEM even though system memory
is not exhausted and a consecutive insert may succeed.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 lib/test_rhashtable.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c
index 6fa77b3..270bf72 100644
--- a/lib/test_rhashtable.c
+++ b/lib/test_rhashtable.c
@@ -52,6 +52,10 @@ static int tcount = 10;
 module_param(tcount, int, 0);
 MODULE_PARM_DESC(tcount, "Number of threads to spawn (default: 10)");
 
+static bool enomem_retry = false;
+module_param(enomem_retry, bool, 0);
+MODULE_PARM_DESC(enomem_retry, "Retry insert even if -ENOMEM was returned (default: off)");
+
 struct test_obj {
 	int			value;
 	struct rhash_head	node;
@@ -79,14 +83,22 @@ static struct semaphore startup_sem = __SEMAPHORE_INITIALIZER(startup_sem, 0);
 static int insert_retry(struct rhashtable *ht, struct rhash_head *obj,
                         const struct rhashtable_params params)
 {
-	int err, retries = -1;
+	int err, retries = -1, enomem_retries = 0;
 
 	do {
 		retries++;
 		cond_resched();
 		err = rhashtable_insert_fast(ht, obj, params);
+		if (err == -ENOMEM && enomem_retry) {
+			enomem_retries++;
+			err = -EBUSY;
+		}
 	} while (err == -EBUSY);
 
+	if (enomem_retries)
+		pr_info(" %u insertions retried after -ENOMEM\n",
+			enomem_retries);
+
 	return err ? : retries;
 }
 
-- 
2.1.2


  parent reply	other threads:[~2015-11-20 17:19 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 17:17 [PATCH v2 0/4] improve fault-tolerance of rhashtable runtime-test Phil Sutter
2015-11-20 17:17 ` [PATCH v2 1/4] rhashtable-test: add cond_resched() to thread test Phil Sutter
2015-11-20 17:17 ` [PATCH v2 2/4] rhashtable-test: retry insert operations Phil Sutter
2015-11-20 17:17 ` [PATCH v2 3/4] rhashtable-test: calculate max_entries value by default Phil Sutter
2015-11-20 17:17 ` Phil Sutter [this message]
2015-11-20 17:28   ` [PATCH v2 4/4] rhashtable-test: allow to retry even if -ENOMEM was returned Phil Sutter
2015-11-23 17:38 ` [PATCH v2 0/4] improve fault-tolerance of rhashtable runtime-test David Miller
2015-11-30  9:37 ` Herbert Xu
2015-11-30 10:14   ` Phil Sutter
2015-11-30 10:18     ` Herbert Xu
2015-12-03 12:41       ` rhashtable: Prevent spurious EBUSY errors on insertion Herbert Xu
2015-12-03 15:38         ` Phil Sutter
2015-12-04 19:38         ` David Miller
2015-12-17  8:46         ` Xin Long
2015-12-17  8:48           ` Herbert Xu
2015-12-17  9:00             ` Xin Long
2015-12-17 16:07               ` Xin Long
2015-12-18  2:26                 ` Herbert Xu
2015-12-18  8:18                   ` Xin Long
2015-12-17 17:00               ` David Miller
2015-12-03 12:51       ` rhashtable: ENOMEM errors when hit with a flood of insertions Herbert Xu
2015-12-03 15:08         ` David Laight
2015-12-03 16:08         ` Eric Dumazet
2015-12-04  0:07           ` Herbert Xu
2015-12-04 14:39           ` rhashtable: Use __vmalloc with GFP_ATOMIC for table allocation Herbert Xu
2015-12-04 17:01             ` Phil Sutter
2015-12-04 17:45               ` Eric Dumazet
2015-12-04 18:15                 ` Phil Sutter
2015-12-05  7:06                   ` Herbert Xu
2015-12-07 15:35                     ` Thomas Graf
2015-12-07 19:29                       ` David Miller
2015-12-09  2:18                     ` Thomas Graf
2015-12-09  2:24                       ` Herbert Xu
2015-12-09  2:36                         ` Thomas Graf
2015-12-09  2:38                           ` Herbert Xu
2015-12-09  2:42                             ` Thomas Graf
2015-12-04 21:53             ` David Miller
2015-12-05  7:03               ` Herbert Xu
2015-12-06  3:48                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448039840-11367-5-git-send-email-phil@nwl.cc \
    --to=phil@nwl.cc \
    --cc=davem@davemloft.net \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    --cc=wfg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).