linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCHSET v4] netfilter, cgroup: implement cgroup2 path match in xt_cgroup
@ 2015-12-07 22:38 Tejun Heo
  2015-12-07 22:38 ` [PATCH 1/8] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it Tejun Heo
                   ` (9 more replies)
  0 siblings, 10 replies; 23+ messages in thread
From: Tejun Heo @ 2015-12-07 22:38 UTC (permalink / raw)
  To: davem, pablo, kaber, kadlec, daniel, daniel.wagner, nhorman
  Cc: lizefan, hannes, netdev, netfilter-devel, coreteam, cgroups,
	linux-kernel, kernel-team, ninasc

Hello,

This is v4 of the xt_cgroup2 patchset.  Changes from v3 are

* Refreshed on top of net-next/master e72c932d3f8a ("cxgb3: Convert
  simple_strtoul to kstrtox").  Dropped "cgroups: Allow dynamically
  changing net_classid" from series as it's already applied.

The changes from v2 to v3 are

* Folded cgroup2 path matching into xt_cgroup as a new revision rather
  than a separate xt_cgroup2 match as suggested by Pablo.

* Refreshed on top of Nina's net_cls dynamic config update fix patch.
  I included the fix patch as part of this series to ease reviewing.

The changes from v1 to v2 are

* Instead of adding sock->sk_cgroup separately, sock->sk_cgrp_data now
  carries either (prioidx, classid) pair or cgroup2 pointer.  This
  avoids inflating struct sock with yet another cgroup related field.
  Unfortunately, this does add some complexity but that's the
  trade-off and the complexity is contained in cgroup proper.

* Various small updats as per David and Jan's reviews.


In cgroup v1, dealing with cgroup membership was difficult because the
number of membership associations was unbound.  As a result, cgroup v1
grew several controllers whose primary purpose is either tagging
membership or pull in configuration knobs from other subsystems so
that cgroup membership test can be avoided.

net_cls and net_prio controllers are examples of the latter.  They
allow configuring network-specific attributes from cgroup side so that
network subsystem can avoid testing cgroup membership; unfortunately,
these are not only cumbersome but also problematic.

Both net_cls and net_prio aren't properly hierarchical.  Both inherit
configuration from the parent on creation but there's no interaction
afterwards.  An ancestor doesn't restrict the behavior in its subtree
in anyway and configuration changes aren't propagated downwards.
Especially when combined with cgroup delegation, this is problematic
because delegatees can mess up whatever network configuration
implemented at the system level.  net_prio would allow the delegatees
to set whatever priority value regardless of CAP_NET_ADMIN and net_cls
the same for classid.

While it is possible to solve these issues from controller side by
implementing hierarchical allowable ranges in both controllers, it
would involve quite a bit of complexity in the controllers and further
obfuscate network configuration as it becomes even more difficult to
tell what's actually being configured looking from the network side.
While not much can be done for v1 at this point, as membership
handling is sane on cgroup v2, it'd be better to make cgroup matching
behave like other network matches and classifiers than introducing
further complications.

This patchset includes the following eight patches.

 0001-cgroup-record-ancestor-IDs-and-reimplement-cgroup_is.patch
 0002-kernfs-implement-kernfs_walk_and_get.patch
 0003-cgroup-implement-cgroup_get_from_path-and-expose-cgr.patch
 0004-netprio_cgroup-limit-the-maximum-css-id-to-USHRT_MAX.patch
 0005-net-wrap-sock-sk_cgrp_prioidx-and-sk_classid-inside-.patch
 0006-sock-cgroup-add-sock-sk_cgroup.patch
 0007-netfilter-prepare-xt_cgroup-for-multi-revisions.patch
 0008-netfilter-implement-xt_cgroup-cgroup2-path-match.patch

0001-0003 are prepatory patches in kernfs and cgroup.  These patches
are available in the following branch which will stay stable.

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git for-4.5-ancestor-test

0004-0006 consolidate two cgroup related fields in struct sock into
cgroup_sock_data and update it so that it can alternatively carry a
cgroup pointer.

0007-0008 implement cgroup2 patch matching in xt_cgroup.

This patchset is on top of net-next/master and also available in the
following git branch.

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-xt_cgroup2

I'll post iptables extension as a reply.  diffstat follows.  Thanks.

 fs/kernfs/dir.c                          |   46 +++++++++++
 include/linux/cgroup-defs.h              |  126 +++++++++++++++++++++++++++++++
 include/linux/cgroup.h                   |   66 +++++++++++++++-
 include/linux/kernfs.h                   |   12 ++
 include/net/cls_cgroup.h                 |   11 +-
 include/net/netprio_cgroup.h             |   16 +++
 include/net/sock.h                       |   13 ---
 include/uapi/linux/netfilter/xt_cgroup.h |   15 +++
 kernel/cgroup.c                          |  126 ++++++++++++++++++++++++-------
 net/Kconfig                              |    6 +
 net/core/dev.c                           |    3 
 net/core/netclassid_cgroup.c             |   11 +-
 net/core/netprio_cgroup.c                |   19 ++++
 net/core/scm.c                           |    4 
 net/core/sock.c                          |   17 ----
 net/netfilter/nft_meta.c                 |    2 
 net/netfilter/xt_cgroup.c                |  108 ++++++++++++++++++++++----
 17 files changed, 513 insertions(+), 88 deletions(-)

--
tejun

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2016-02-12 16:06 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-07 22:38 [PATCHSET v4] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Tejun Heo
2015-12-07 22:38 ` [PATCH 1/8] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it Tejun Heo
2015-12-07 22:38 ` [PATCH 2/8] kernfs: implement kernfs_walk_and_get() Tejun Heo
2016-01-15 12:29   ` Geert Uytterhoeven
2016-01-15 17:30     ` [PATCH] kernfs: make kernfs_walk_ns() use kernfs_pr_cont_buf[] Tejun Heo
2016-01-15 22:05       ` Greg Kroah-Hartman
2015-12-07 22:38 ` [PATCH 3/8] cgroup: implement cgroup_get_from_path() and expose cgroup_put() Tejun Heo
2015-12-22  0:22   ` Serge E. Hallyn
2015-12-22 18:13     ` Tejun Heo
2015-12-07 22:38 ` [PATCH 4/8] netprio_cgroup: limit the maximum css->id to USHRT_MAX Tejun Heo
2015-12-07 22:38 ` [PATCH 5/8] net: wrap sock->sk_cgrp_prioidx and ->sk_classid inside a struct Tejun Heo
2015-12-07 22:38 ` [PATCH 6/8] sock, cgroup: add sock->sk_cgroup Tejun Heo
2015-12-07 22:38 ` [PATCH 7/8] netfilter: prepare xt_cgroup for multi revisions Tejun Heo
2015-12-14 19:35   ` Pablo Neira Ayuso
2015-12-07 22:38 ` [PATCH 8/8] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo
2015-12-14 19:37   ` Pablo Neira Ayuso
2016-02-12  0:10   ` Alban Crequy
2016-02-12 16:05     ` Tejun Heo
2015-12-09  3:03 ` [PATCHSET v4] netfilter, cgroup: implement cgroup2 path match in xt_cgroup David Miller
2015-12-14 11:54 ` Dexuan Cui
2015-12-14 16:24   ` [PATCH net-next] net, cgroup: cgroup_sk_updat_lock was missing initializer Tejun Heo
2015-12-14 19:20     ` David Miller
2015-12-15  2:11       ` Dexuan Cui

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).