* [RESEND PATCH] mtd: mtk-nor: adjust sequence of trigger function and assignment function
@ 2015-12-18 3:02 Bayi Cheng
2015-12-18 23:06 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Bayi Cheng @ 2015-12-18 3:02 UTC (permalink / raw)
To: David Woodhouse, Brian Norris
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Matthias Brugger, Daniel Kurtz, Sascha Hauer, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel, linux-mtd,
srv_heupstream, Bayi Cheng
Move write data register before excute command to avoid
missing first byte write to nor flash
Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com>
---
the previous patch didn't drop the Change-Id
---
drivers/mtd/spi-nor/mtk-quadspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/mtk-quadspi.c b/drivers/mtd/spi-nor/mtk-quadspi.c
index dd269650..04da971 100644
--- a/drivers/mtd/spi-nor/mtk-quadspi.c
+++ b/drivers/mtd/spi-nor/mtk-quadspi.c
@@ -272,10 +272,10 @@ static int mt8173_nor_write_single_byte(struct mt8173_nor *mt8173_nor,
mt8173_nor_set_addr(mt8173_nor, addr);
for (i = 0; i < length; i++) {
+ writeb(*data++, mt8173_nor->base + MTK_NOR_WDATA_REG);
ret = mt8173_nor_execute_cmd(mt8173_nor, MTK_NOR_PIO_WR_CMD);
if (ret < 0)
return ret;
- writeb(*data++, mt8173_nor->base + MTK_NOR_WDATA_REG);
}
return 0;
}
--
1.8.1.1.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RESEND PATCH] mtd: mtk-nor: adjust sequence of trigger function and assignment function
2015-12-18 3:02 [RESEND PATCH] mtd: mtk-nor: adjust sequence of trigger function and assignment function Bayi Cheng
@ 2015-12-18 23:06 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2015-12-18 23:06 UTC (permalink / raw)
To: Bayi Cheng
Cc: David Woodhouse, Rob Herring, Pawel Moll, Mark Rutland,
Ian Campbell, Kumar Gala, Matthias Brugger, Daniel Kurtz,
Sascha Hauer, devicetree, linux-arm-kernel, linux-mediatek,
linux-kernel, linux-mtd, srv_heupstream
On Fri, Dec 18, 2015 at 11:02:40AM +0800, Bayi Cheng wrote:
> Move write data register before excute command to avoid
> missing first byte write to nor flash
>
> Signed-off-by: Bayi Cheng <bayi.cheng@mediatek.com>
> ---
> the previous patch didn't drop the Change-Id
Applied to l2-mtd.git
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-18 23:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-18 3:02 [RESEND PATCH] mtd: mtk-nor: adjust sequence of trigger function and assignment function Bayi Cheng
2015-12-18 23:06 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).