From: wanghaibin <wanghaibin.wang@huawei.com>
To: <linux-kernel@vger.kernel.org>
Cc: <tj@kernel.org>, <jiangshanlai@gmail.com>,
<peter.huangpeng@huawei.com>,
wanghaibin <wanghaibin.wang@huawei.com>
Subject: [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed.
Date: Thu, 7 Jan 2016 20:38:57 +0800 [thread overview]
Message-ID: <1452170339-26748-3-git-send-email-wanghaibin.wang@huawei.com> (raw)
In-Reply-To: <1452170339-26748-1-git-send-email-wanghaibin.wang@huawei.com>
Before the return that wq_numa_init failed, it will be bettet to free
the numa node table to avoid the memory leaks.
Signed-off-by: wanghaibin <wanghaibin.wang@huawei.com>
---
kernel/workqueue.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index d6cbe3d..60e192c 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -5195,6 +5195,10 @@ static void __init wq_numa_init(void)
for_each_possible_cpu(cpu) {
node = cpu_to_node(cpu);
if (WARN_ON(node == NUMA_NO_NODE)) {
+ for_each_node(node)
+ free_cpumask_var(tbl[node]);
+ kfree(tbl);
+
pr_warn("workqueue: NUMA node mapping not available for cpu%d, disabling NUMA support\n", cpu);
/* happens iff arch is bonkers, let's just proceed */
return;
--
1.8.3.1
next prev parent reply other threads:[~2016-01-07 12:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 12:38 [RFC PATCH 0/4] fixs/suggestions for workqueue subsystem wanghaibin
2016-01-07 12:38 ` [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location wanghaibin
2016-01-07 15:48 ` Tejun Heo
2016-01-11 5:21 ` wanghaibin
2016-01-07 12:38 ` wanghaibin [this message]
2016-01-07 15:50 ` [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed Tejun Heo
2016-01-11 4:26 ` wanghaibin
2016-01-07 12:38 ` [RFC PATCH 3/4] workqueue: remove the unbind workqueue attr sys_file before unregister the workqueue device wanghaibin
2016-01-07 16:00 ` Tejun Heo
2016-01-11 12:23 ` wanghaibin
2016-01-07 12:38 ` [RFC PATCH 4/4] workqueue: simplify the apply_workqueue_attrs_locked function wanghaibin
2016-01-07 16:07 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452170339-26748-3-git-send-email-wanghaibin.wang@huawei.com \
--to=wanghaibin.wang@huawei.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.huangpeng@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).