* [patch] get_maintainer: handle file names beginning with ./
@ 2016-01-08 10:51 Dan Carpenter
2016-01-08 11:37 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2016-01-08 10:51 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel, Andrew Morton
The problem is that get_maintainer.pl doesn't work if you have a ./
prefix on the filename. For example, if you type:
./scripts/get_maintainer.pl -f ./drivers/usb/usb-skeleton.c
then the current code only includes LKML and people from the git log, it
doesn't include Greg or the linux-usb list.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index cab641a..41cfe59 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -605,6 +605,8 @@ sub get_maintainers {
foreach my $file (@files) {
+ $file =~ s/^\.\///;
+
my %hash;
my $tvi = find_first_section();
while ($tvi < @typevalue) {
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] get_maintainer: handle file names beginning with ./
2016-01-08 10:51 [patch] get_maintainer: handle file names beginning with ./ Dan Carpenter
@ 2016-01-08 11:37 ` Joe Perches
2016-01-08 13:44 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2016-01-08 11:37 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, Andrew Morton
On Fri, 2016-01-08 at 13:51 +0300, Dan Carpenter wrote:
> The problem is that get_maintainer.pl doesn't work if you have a ./
> prefix on the filename. For example, if you type:
>
> ./scripts/get_maintainer.pl -f ./drivers/usb/usb-skeleton.c
Someone's been feeding find output to get_maintainer?
Then maybe you'd also have to consider fully qualified
file names, tilde expansion, $PWD, and probably a bunch
of other things too.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] get_maintainer: handle file names beginning with ./
2016-01-08 11:37 ` Joe Perches
@ 2016-01-08 13:44 ` Dan Carpenter
2016-01-08 17:47 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2016-01-08 13:44 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel, Andrew Morton
On Fri, Jan 08, 2016 at 03:37:56AM -0800, Joe Perches wrote:
> On Fri, 2016-01-08 at 13:51 +0300, Dan Carpenter wrote:
> > The problem is that get_maintainer.pl doesn't work if you have a ./
> > prefix on the filename. For example, if you type:
> >
> > ./scripts/get_maintainer.pl -f ./drivers/usb/usb-skeleton.c
>
> Someone's been feeding find output to get_maintainer?
Yep.
>
> Then maybe you'd also have to consider fully qualified
> file names, tilde expansion, $PWD, and probably a bunch
> of other things too.
I don't think you'd "have" to consider those as well, but I won't stand
in your way if you want to...
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] get_maintainer: handle file names beginning with ./
2016-01-08 13:44 ` Dan Carpenter
@ 2016-01-08 17:47 ` Joe Perches
2016-01-08 18:46 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2016-01-08 17:47 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, Andrew Morton
On Fri, 2016-01-08 at 16:44 +0300, Dan Carpenter wrote:
> On Fri, Jan 08, 2016 at 03:37:56AM -0800, Joe Perches wrote:
> > On Fri, 2016-01-08 at 13:51 +0300, Dan Carpenter wrote:
> > > The problem is that get_maintainer.pl doesn't work if you have a ./
> > > prefix on the filename. For example, if you type:
> > >
> > > ./scripts/get_maintainer.pl -f ./drivers/usb/usb-skeleton.c
> >
> > Someone's been feeding find output to get_maintainer?
>
> Yep.
So strip the leading './' before using it.
Also, if you're looking for unmaintained files,
I think have a script for that too.
> > Then maybe you'd also have to consider fully qualified
> > file names, tilde expansion, $PWD, and probably a bunch
> > of other things too.
>
> I don't think you'd "have" to consider those as well, but I won't stand
> in your way if you want to...
Half measures aren't generally good enough.
Using a combination of CWnd abs_fast_path and $lk_path
is probably better. $lkpath is set to './' by default.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] get_maintainer: handle file names beginning with ./
2016-01-08 17:47 ` Joe Perches
@ 2016-01-08 18:46 ` Dan Carpenter
2016-01-08 19:46 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2016-01-08 18:46 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel, Andrew Morton
On Fri, Jan 08, 2016 at 09:47:07AM -0800, Joe Perches wrote:
> > > Then maybe you'd also have to consider fully qualified
> > > file names, tilde expansion, $PWD, and probably a bunch
> > > of other things too.
> >
> > I don't think you'd "have" to consider those as well, but I won't stand
> > in your way if you want to...
>
> Half measures aren't generally good enough.
>
Those are fake issues though and I can't imagine how they would affect
anyone. My issue was super annoying for me because I was sending find
output to a script and it was almost mailing the correct people because
it was using git output. I had to debug for a long time before I
spotted the difference between ./drivers/media/radio/wl128x/fmdrv_common.c
and drivers/media/radio/wl128x/fmdrv_common.c.
I feel like I have seen this before and just manually added the correct
mailing lists back. It's crazy annoying and easy to do.
> Using a combination of CWnd abs_fast_path and $lk_path
> is probably better. $lkpath is set to './' by default.
I have no idea what this means... It sounds like a good idea though.
:) Please give me Reported-by credit.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] get_maintainer: handle file names beginning with ./
2016-01-08 18:46 ` Dan Carpenter
@ 2016-01-08 19:46 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2016-01-08 19:46 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, Andrew Morton
On Fri, 2016-01-08 at 21:46 +0300, Dan Carpenter wrote:
> On Fri, Jan 08, 2016 at 09:47:07AM -0800, Joe Perches wrote:
> > > > Then maybe you'd also have to consider fully qualified
> > > > file names, tilde expansion, $PWD, and probably a bunch
> > > > of other things too.
> > >
> > > I don't think you'd "have" to consider those as well, but I won't stand
> > > in your way if you want to...
> >
> > Half measures aren't generally good enough.
> >
>
> Those are fake issues though and I can't imagine how they would affect
> anyone. My issue was super annoying for me because I was sending find
> output to a script and it was almost mailing the correct people because
> it was using git output. I had to debug for a long time before I
> spotted the difference between ./drivers/media/radio/wl128x/fmdrv_common.c
> and drivers/media/radio/wl128x/fmdrv_common.c.
>
> I feel like I have seen this before and just manually added the correct
> mailing lists back. It's crazy annoying and easy to do.
>
> > Using a combination of CWnd abs_fast_path and $lk_path
> > is probably better. $lkpath is set to './' by default.
>
> I have no idea what this means... It sounds like a good idea though.
> :) Please give me Reported-by credit.
>
Maybe this (probably won't apply because I still haven't
converted from Evolution to something that doesn't futz
up sending text emails)
---
scripts/get_maintainer.pl | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index cab641a..1873421 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -16,7 +16,9 @@ my $P = $0;
my $V = '0.26';
use Getopt::Long qw(:config no_auto_abbrev);
+use Cwd;
+my $cur_path = fastgetcwd() . '/';
my $lk_path = "./";
my $email = 1;
my $email_usename = 1;
@@ -429,6 +431,8 @@ foreach my $file (@ARGV) {
}
}
if ($from_filename) {
+ $file =~ s/^\Q${cur_path}\E//; #strip any absolute path
+ $file =~ s/^\Q${lk_path}\E//; #or the path to the lk tree
push(@files, $file);
if ($file ne "MAINTAINERS" && -f $file && ($keywords || $file_emails)) {
open(my $f, '<', $file)
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-08 19:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-08 10:51 [patch] get_maintainer: handle file names beginning with ./ Dan Carpenter
2016-01-08 11:37 ` Joe Perches
2016-01-08 13:44 ` Dan Carpenter
2016-01-08 17:47 ` Joe Perches
2016-01-08 18:46 ` Dan Carpenter
2016-01-08 19:46 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).