[PATCH 0/2] ASoC: ads117x: Add device tree support for TI ADS117x

[PATCH 0/2] ASoC: ads117x: Add device tree support for TI ADS117x

[Florian Vaussard]

Hello,

This series adds device tree support for the Texas Instruments ADS117x
ADC chip. The first patch adds the binding documentation, while the second
patch adds the compatible string into the driver.

Best regards,

Florian

Florian Vaussard (2):
  dt/bindings: Add bindings documentation for TI ADS117x ADC
  ASoC: ads117x: Add device tree compatible string

 Documentation/devicetree/bindings/sound/ti,ads117x.txt | 11 +++++++++++
 sound/soc/codecs/ads117x.c                             | 11 +++++++++++
 2 files changed, 22 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/ti,ads117x.txt

-- 
2.1.0

[PATCH 1/2] dt/bindings: Add bindings documentation for TI ADS117x ADC

[Florian Vaussard]

Currently the binding is only made of the compatible string.

Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch>
---
 Documentation/devicetree/bindings/sound/ti,ads117x.txt | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/ti,ads117x.txt

diff --git a/Documentation/devicetree/bindings/sound/ti,ads117x.txt b/Documentation/devicetree/bindings/sound/ti,ads117x.txt
new file mode 100644
index 0000000..c1c2741
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/ti,ads117x.txt
@@ -0,0 +1,11 @@
+Texas Intstruments ADS117x ADC
+
+Required properties:
+
+  - compatible : "ti,ads117x"
+
+Example:
+
+ads1178 {
+	compatible = "ti,ads117x";
+};
-- 
2.1.0

[PATCH 2/2] ASoC: ads117x: Add device tree compatible string

[Florian Vaussard]

This patch adds the necessary device tree compatible string to allow
DT probing.

Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch>
---
 sound/soc/codecs/ads117x.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/sound/soc/codecs/ads117x.c b/sound/soc/codecs/ads117x.c
index 1222282..b3f6618 100644
--- a/sound/soc/codecs/ads117x.c
+++ b/sound/soc/codecs/ads117x.c
@@ -20,6 +20,8 @@
 #include <sound/initval.h>
 #include <sound/soc.h>
 
+#include <linux/of.h>
+
 #define ADS117X_RATES (SNDRV_PCM_RATE_8000_48000)
 #define ADS117X_FORMATS (SNDRV_PCM_FMTBIT_S16_LE)
 
@@ -75,9 +77,18 @@ static int ads117x_remove(struct platform_device *pdev)
 	return 0;
 }
 
+#if defined(CONFIG_OF)
+static const struct of_device_id ads117x_dt_ids[] = {
+	{ .compatible = "ti,ads117x" },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, ads117x_dt_ids);
+#endif
+
 static struct platform_driver ads117x_codec_driver = {
 	.driver = {
 			.name = "ads117x-codec",
+			.of_match_table = of_match_ptr(ads117x_dt_ids),
 	},
 
 	.probe = ads117x_probe,
-- 
2.1.0

Re: [PATCH 1/2] dt/bindings: Add bindings documentation for TI ADS117x ADC

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

On Mon, Jan 18, 2016 at 05:04:51PM +0100, Florian Vaussard wrote:
> Currently the binding is only made of the compatible string.

Please use subject lines matching the style for the subsystem.

> +  - compatible : "ti,ads117x"

Compatible strings shouldn't have wildcards in them, they should specify
a particular device - this way if we start caring about differences
later we don't have problems with old DTs.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]