From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Liguo Zhang <liguo.zhang@mediatek.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Xudong Chen <xudong.chen@mediatek.com>,
<srv_heupstream@mediatek.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <linux-i2c@vger.kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
Eddie Huang <eddie.huang@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6] i2c: mt8173: add 4GB mode support in i2c driver.
Date: Thu, 4 Feb 2016 14:54:03 +0800 [thread overview]
Message-ID: <1454568843.15541.1.camel@mtksdaap41> (raw)
In-Reply-To: <1454347143-31461-1-git-send-email-liguo.zhang@mediatek.com>
On Tue, 2016-02-02 at 01:19 +0800, Liguo Zhang wrote:
> If 4GB mode is enable, we should add 4gb mode support in i2c driver.
> Set 4GB mode register to support 4GB mode.
>
> Signed-off-by: Liguo Zhang <liguo.zhang@mediatek.com>
> ---
> change in v6:
> Remove unnecessary init for reg_4g_mode.
> change in v5:
> Use BIT_ULL() to fix kernel building warning.
> change in v4:
> Use BIT_ULL() to fix kernel building warning.
> change in v3:
> Only inline the computation of reg_4g_mode in mtk_i2c_set_4g_mode().
> change in v2:
> Define a static inline function mtk_i2c_set_4g_mode() for support 4g mode.
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 42 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
Looks good to me, Thanks.
Reviewed-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
Joe.C
next prev parent reply other threads:[~2016-02-04 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 17:19 [PATCH v6] i2c: mt8173: add 4GB mode support in i2c driver Liguo Zhang
2016-02-02 3:02 ` Daniel Kurtz
2016-02-04 6:54 ` Yingjoe Chen [this message]
2016-02-12 19:18 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454568843.15541.1.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=liguo.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
--cc=xudong.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).