linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Deepa Dinamani <deepa.kernel@gmail.com>
To: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org
Cc: Arnd Bergmann <arnd@arndb.de>, Dave Chinner <david@fromorbit.com>,
	"Theodore Ts'o" <tytso@mit.edu>,
	linux-kernel@vger.kernel.org
Subject: [RFC v2c 0/8] vfs 64 bit time transition proposal
Date: Fri, 12 Feb 2016 01:52:45 -0800	[thread overview]
Message-ID: <1455270773-3249-1-git-send-email-deepa.kernel@gmail.com> (raw)
In-Reply-To: <20160212092153.GA2368@deepa-ubuntu>

Introduction

The series is one of the proposals on how to transition VFS timestamps
to use 64 bit time.  The credit for the idea goes to Arnd Bergmann and
it’s a mix of approaches 2a and 2b.

Solution

1.Define vfs_time as alias to timespec.
2.Define accessor functions for inode timestamps.
3.Change individual filesystems to use timespec64 timestamps.
  Make sure each filesystem will be safe when converted to use
  timespec64.
4.Change individual filesystems to use only vfs_time data type
  for inode timestamps.  Make sure each filesystem will be safe
  when converted to use timespec64.
5.Change vfs_time to timespec64.
6.Delete all accessors from individual filesystem and access inode
  timestamps directly.

Note that the series only includes patches for steps 1-4.

Variant

We could make the solution similar to 2a and use timespec in the
individual filesystems instead of timespec64.

Concerns

1. It is not clear when vfs_time or accessors should be used.
   Even though it is advisable to make the conversions at vfs boundary,
   it is not easy to catch the exceptions.
2. Maintenance of the code base before vfs layer is changed is
   going to be a little hard as developers might be confused because
   of 1.
3. Has the same problem as changing all filesystems to 64 bit:
   the switch over to timespec64 has to be done globally in a single,
   huge patch for some filesystems.

Deepa Dinamani (8):
  vfs: Add vfs_time abstractions
  fs: cifs: Change auxdata to struct timespec64 data type
  fs: cifs: Change cifs_fattr timestamps data type to timespec64
  fs: cifs: Make cnvrtDosUnixTm() y2038 safe
  fs: btrfs: Change btrfs_inode.i_otime to vfs_time data type
  fs: btrfs: Use vfs timestamp abstraction helper
  fs: ceph: Use vfs timestamp abstraction helpers
  fs: xfs: change inode times to use vfs_time data type

 fs/btrfs/btrfs_inode.h          |  2 +-
 fs/btrfs/file.c                 |  7 ++--
 fs/btrfs/inode.c                |  6 +--
 fs/btrfs/ioctl.c                |  4 +-
 fs/btrfs/root-tree.c            |  2 +-
 fs/btrfs/transaction.c          |  2 +-
 fs/ceph/addr.c                  | 20 ++++++---
 fs/ceph/cache.c                 |  6 +--
 fs/ceph/caps.c                  | 10 ++---
 fs/ceph/dir.c                   |  4 +-
 fs/ceph/file.c                  | 14 +++++--
 fs/ceph/inode.c                 | 91 +++++++++++++++++++++++------------------
 fs/ceph/mds_client.c            |  9 ++--
 fs/ceph/mds_client.h            |  2 +-
 fs/ceph/snap.c                  |  6 +--
 fs/ceph/super.h                 |  9 ++--
 fs/ceph/xattr.c                 |  2 +-
 fs/cifs/cache.c                 | 16 +++++---
 fs/cifs/cifsencrypt.c           |  4 +-
 fs/cifs/cifsglob.h              |  6 +--
 fs/cifs/cifsproto.h             |  6 +--
 fs/cifs/cifssmb.c               |  6 +--
 fs/cifs/inode.c                 | 35 +++++++++-------
 fs/cifs/netmisc.c               | 16 ++++----
 fs/xfs/xfs_inode.c              |  2 +-
 fs/xfs/xfs_iops.c               |  2 +-
 fs/xfs/xfs_trans_inode.c        |  7 ++--
 include/linux/ceph/decode.h     |  9 ++--
 include/linux/ceph/osd_client.h |  4 +-
 include/linux/fs.h              | 21 ++++++++++
 net/ceph/osd_client.c           |  4 +-
 31 files changed, 199 insertions(+), 135 deletions(-)

-- 
1.9.1

  parent reply	other threads:[~2016-02-12  9:53 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12  9:21 [RFC v2] vfs 64 bit time transition proposals Deepa Dinamani
2016-02-12  9:35 ` [RFC v2a 00/12] vfs 64 bit time transition proposal Deepa Dinamani
2016-02-12  9:35   ` [RFC v2a 01/12] vfs: Add vfs_time abstractions Deepa Dinamani
2016-02-12  9:35   ` [RFC v2a 02/12] fs: cifs: Change cifs_fscache_inode_auxdata to use vfs_time data type Deepa Dinamani
2016-02-12  9:35   ` [RFC v2a 03/12] fs: cifs: Change cifs_fattr timestamps data type to vfs_time Deepa Dinamani
2016-02-12  9:35   ` [RFC v2a 04/12] fs: cifs: Make cnvrtDosUnixTm() y2038 safe Deepa Dinamani
2016-02-12  9:35   ` [RFC v2a 05/12] fs: cifs: Use vfs_time_get_real_* time functions Deepa Dinamani
2016-02-12  9:36   ` [RFC v2a 06/12] fs: btrfs: Change btrfs_inode.i_otime to use vfs_time data type Deepa Dinamani
2016-02-12  9:36   ` [RFC v2a 07/12] fs: btrfs: Use vfs_time data type for btrfs_update_time() Deepa Dinamani
2016-02-12  9:36   ` [RFC v2a 08/12] fs: btrfs: Change timespec data types to use vfs_time Deepa Dinamani
2016-02-12  9:36   ` [RFC v2a 09/12] fs: ceph: Change encode and decode functions " Deepa Dinamani
2016-02-12  9:36   ` [RFC v2a 10/12] fs: ceph: Replace timespec data type with vfs_time Deepa Dinamani
2016-02-12  9:36   ` [RFC v2a 11/12] net: ceph: use vfs_time data type instead of timespec Deepa Dinamani
2016-02-13 22:08     ` Dave Chinner
2016-02-14  1:46       ` Deepa Dinamani
2016-02-14  2:05         ` Deepa Dinamani
2016-02-14 21:00         ` Dave Chinner
2016-02-17  9:32           ` Arnd Bergmann
2016-02-12  9:36   ` [RFC v2a 12/12] fs: xfs: change inode times to use vfs_time data type Deepa Dinamani
2016-02-12  9:45 ` [RFC v2b 0/5] vfs 64 bit time transition proposal Deepa Dinamani
2016-02-12  9:45   ` [RFC v2b 1/5] vfs: Add vfs_time accessors Deepa Dinamani
2016-02-12  9:45   ` [RFC v2b 2/5] fs: cifs: Use " Deepa Dinamani
2016-02-12  9:45   ` [RFC v2b 3/5] fs: btrfs: " Deepa Dinamani
2016-02-12 13:57     ` Arnd Bergmann
2016-02-13  7:01       ` Deepa Dinamani
2016-02-12  9:45   ` [RFC v2b 4/5] fs: ceph: Use vfs timestamp accessors Deepa Dinamani
2016-02-12  9:45   ` [RFC v2b 5/5] fs: xfs: change inode times to use vfs_time data type Deepa Dinamani
2016-02-13  2:18     ` Dave Chinner
2016-02-13 14:50       ` [Y2038] " Arnd Bergmann
2016-02-13 15:56         ` David F.
2016-02-12  9:52 ` Deepa Dinamani [this message]
2016-02-12  9:52   ` [RFC v2c 1/8] vfs: Add vfs_time abstractions Deepa Dinamani
2016-02-12  9:52   ` [RFC v2c 2/8] fs: cifs: Change auxdata to struct timespec64 data type Deepa Dinamani
2016-02-12  9:52   ` [RFC v2c 3/8] fs: cifs: Change cifs_fattr timestamps data type to timespec64 Deepa Dinamani
2016-02-12  9:52   ` [RFC v2c 4/8] fs: cifs: Make cnvrtDosUnixTm() y2038 safe Deepa Dinamani
2016-02-12  9:52   ` [RFC v2c 5/8] fs: btrfs: Change btrfs_inode.i_otime to vfs_time data type Deepa Dinamani
2016-02-12  9:52   ` [RFC v2c 6/8] fs: btrfs: Use vfs timestamp abstraction helper Deepa Dinamani
2016-02-12  9:52   ` [RFC v2c 7/8] fs: ceph: Use vfs timestamp abstraction helpers Deepa Dinamani
2016-02-12  9:52   ` [RFC v2c 8/8] fs: xfs: change inode times to use vfs_time data type Deepa Dinamani
2016-02-12 14:03 ` [Y2038] [RFC v2] vfs 64 bit time transition proposals Arnd Bergmann
2016-02-13  6:58   ` Deepa Dinamani
2016-02-13 11:54     ` Deepa Dinamani
2016-02-24 12:19   ` [Y2038] " Thomas Gleixner
2016-02-24 12:26     ` Julia Lawall
2016-02-24 13:56     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1455270773-3249-1-git-send-email-deepa.kernel@gmail.com \
    --to=deepa.kernel@gmail.com \
    --cc=arnd@arndb.de \
    --cc=david@fromorbit.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=y2038@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).