From: Deepa Dinamani <deepa.kernel@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org,
Dave Chinner <david@fromorbit.com>,
"Theodore Ts'o" <tytso@mit.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC v2b 3/5] fs: btrfs: Use vfs_time accessors
Date: Fri, 12 Feb 2016 23:01:22 -0800 [thread overview]
Message-ID: <CABeXuvor=fR1B12e_yzpZUriwChSfNw-A83mx9_E=GKaeyGZgA@mail.gmail.com> (raw)
In-Reply-To: <2859000.sW5HDiH6vW@wuerfel>
On Fri, Feb 12, 2016 at 5:57 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 12 February 2016 01:45:47 Deepa Dinamani wrote:
>> + ts = vfs_time_to_timespec(inode->i_mtime);
>> + if (!timespec_equal(&ts, &now))
>> + inode->i_mtime = timespec_to_vfs_time(now);
>> +
>> + ts = vfs_time_to_timespec(inode->i_mtime);
>> + if (!timespec_equal(&ts, &now))
>> + inode->i_ctime = timespec_to_vfs_time(now);
>>
>
> The second one needs to be fs_time_to_timespec(inode->i_ctime), not i_mtime.
Yes, you are correct.
I will wait for some consensus on the proposal to figure out which
version to post again.
Thanks,
-Deepa
next prev parent reply other threads:[~2016-02-13 7:01 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 9:21 [RFC v2] vfs 64 bit time transition proposals Deepa Dinamani
2016-02-12 9:35 ` [RFC v2a 00/12] vfs 64 bit time transition proposal Deepa Dinamani
2016-02-12 9:35 ` [RFC v2a 01/12] vfs: Add vfs_time abstractions Deepa Dinamani
2016-02-12 9:35 ` [RFC v2a 02/12] fs: cifs: Change cifs_fscache_inode_auxdata to use vfs_time data type Deepa Dinamani
2016-02-12 9:35 ` [RFC v2a 03/12] fs: cifs: Change cifs_fattr timestamps data type to vfs_time Deepa Dinamani
2016-02-12 9:35 ` [RFC v2a 04/12] fs: cifs: Make cnvrtDosUnixTm() y2038 safe Deepa Dinamani
2016-02-12 9:35 ` [RFC v2a 05/12] fs: cifs: Use vfs_time_get_real_* time functions Deepa Dinamani
2016-02-12 9:36 ` [RFC v2a 06/12] fs: btrfs: Change btrfs_inode.i_otime to use vfs_time data type Deepa Dinamani
2016-02-12 9:36 ` [RFC v2a 07/12] fs: btrfs: Use vfs_time data type for btrfs_update_time() Deepa Dinamani
2016-02-12 9:36 ` [RFC v2a 08/12] fs: btrfs: Change timespec data types to use vfs_time Deepa Dinamani
2016-02-12 9:36 ` [RFC v2a 09/12] fs: ceph: Change encode and decode functions " Deepa Dinamani
2016-02-12 9:36 ` [RFC v2a 10/12] fs: ceph: Replace timespec data type with vfs_time Deepa Dinamani
2016-02-12 9:36 ` [RFC v2a 11/12] net: ceph: use vfs_time data type instead of timespec Deepa Dinamani
2016-02-13 22:08 ` Dave Chinner
2016-02-14 1:46 ` Deepa Dinamani
2016-02-14 2:05 ` Deepa Dinamani
2016-02-14 21:00 ` Dave Chinner
2016-02-17 9:32 ` Arnd Bergmann
2016-02-12 9:36 ` [RFC v2a 12/12] fs: xfs: change inode times to use vfs_time data type Deepa Dinamani
2016-02-12 9:45 ` [RFC v2b 0/5] vfs 64 bit time transition proposal Deepa Dinamani
2016-02-12 9:45 ` [RFC v2b 1/5] vfs: Add vfs_time accessors Deepa Dinamani
2016-02-12 9:45 ` [RFC v2b 2/5] fs: cifs: Use " Deepa Dinamani
2016-02-12 9:45 ` [RFC v2b 3/5] fs: btrfs: " Deepa Dinamani
2016-02-12 13:57 ` Arnd Bergmann
2016-02-13 7:01 ` Deepa Dinamani [this message]
2016-02-12 9:45 ` [RFC v2b 4/5] fs: ceph: Use vfs timestamp accessors Deepa Dinamani
2016-02-12 9:45 ` [RFC v2b 5/5] fs: xfs: change inode times to use vfs_time data type Deepa Dinamani
2016-02-13 2:18 ` Dave Chinner
2016-02-13 14:50 ` [Y2038] " Arnd Bergmann
2016-02-13 15:56 ` David F.
2016-02-12 9:52 ` [RFC v2c 0/8] vfs 64 bit time transition proposal Deepa Dinamani
2016-02-12 9:52 ` [RFC v2c 1/8] vfs: Add vfs_time abstractions Deepa Dinamani
2016-02-12 9:52 ` [RFC v2c 2/8] fs: cifs: Change auxdata to struct timespec64 data type Deepa Dinamani
2016-02-12 9:52 ` [RFC v2c 3/8] fs: cifs: Change cifs_fattr timestamps data type to timespec64 Deepa Dinamani
2016-02-12 9:52 ` [RFC v2c 4/8] fs: cifs: Make cnvrtDosUnixTm() y2038 safe Deepa Dinamani
2016-02-12 9:52 ` [RFC v2c 5/8] fs: btrfs: Change btrfs_inode.i_otime to vfs_time data type Deepa Dinamani
2016-02-12 9:52 ` [RFC v2c 6/8] fs: btrfs: Use vfs timestamp abstraction helper Deepa Dinamani
2016-02-12 9:52 ` [RFC v2c 7/8] fs: ceph: Use vfs timestamp abstraction helpers Deepa Dinamani
2016-02-12 9:52 ` [RFC v2c 8/8] fs: xfs: change inode times to use vfs_time data type Deepa Dinamani
2016-02-12 14:03 ` [Y2038] [RFC v2] vfs 64 bit time transition proposals Arnd Bergmann
2016-02-13 6:58 ` Deepa Dinamani
2016-02-13 11:54 ` Deepa Dinamani
2016-02-24 12:19 ` [Y2038] " Thomas Gleixner
2016-02-24 12:26 ` Julia Lawall
2016-02-24 13:56 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABeXuvor=fR1B12e_yzpZUriwChSfNw-A83mx9_E=GKaeyGZgA@mail.gmail.com' \
--to=deepa.kernel@gmail.com \
--cc=arnd@arndb.de \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).