* [PATCH] ubi: Fix out of bounds write in volume update code
@ 2016-02-21 9:53 Richard Weinberger
2016-02-24 14:03 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Richard Weinberger @ 2016-02-21 9:53 UTC (permalink / raw)
To: linux-mtd; +Cc: dedekind1, richard, linux-kernel, stable
ubi_start_leb_change() alloctes too few bytes.
ubi_more_leb_change_data() will write up to req->upd_bytes +
ubi->min_io_size bytes.
Cc: stable@vger.kernel.org
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/ubi/upd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/upd.c b/drivers/mtd/ubi/upd.c
index cfeaf0f..b7901ce 100644
--- a/drivers/mtd/ubi/upd.c
+++ b/drivers/mtd/ubi/upd.c
@@ -193,7 +193,7 @@ int ubi_start_leb_change(struct ubi_device *ubi, struct ubi_volume *vol,
vol->changing_leb = 1;
vol->ch_lnum = req->lnum;
- vol->upd_buf = vmalloc(req->bytes);
+ vol->upd_buf = vmalloc(ALIGN((int)req->bytes, ubi->min_io_size));
if (!vol->upd_buf)
return -ENOMEM;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ubi: Fix out of bounds write in volume update code
2016-02-21 9:53 [PATCH] ubi: Fix out of bounds write in volume update code Richard Weinberger
@ 2016-02-24 14:03 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2016-02-24 14:03 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-mtd, linux-kernel, stable, dedekind1
On Sun, 21 Feb 2016 10:53:03 +0100
Richard Weinberger <richard@nod.at> wrote:
> ubi_start_leb_change() alloctes too few bytes.
> ubi_more_leb_change_data() will write up to req->upd_bytes +
> ubi->min_io_size bytes.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Richard Weinberger <richard@nod.at>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> ---
> drivers/mtd/ubi/upd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/upd.c b/drivers/mtd/ubi/upd.c
> index cfeaf0f..b7901ce 100644
> --- a/drivers/mtd/ubi/upd.c
> +++ b/drivers/mtd/ubi/upd.c
> @@ -193,7 +193,7 @@ int ubi_start_leb_change(struct ubi_device *ubi, struct ubi_volume *vol,
> vol->changing_leb = 1;
> vol->ch_lnum = req->lnum;
>
> - vol->upd_buf = vmalloc(req->bytes);
> + vol->upd_buf = vmalloc(ALIGN((int)req->bytes, ubi->min_io_size));
> if (!vol->upd_buf)
> return -ENOMEM;
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-24 14:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-21 9:53 [PATCH] ubi: Fix out of bounds write in volume update code Richard Weinberger
2016-02-24 14:03 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).