* [PATCH] ASoC: pcm3168a: remove unused variable
@ 2016-03-03 13:37 Sudip Mukherjee
2016-03-04 2:48 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2016-03-03 13:37 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: linux-kernel, alsa-devel, Sudip Mukherjee
While building we were getting build warning about:
sound/soc/codecs/pcm3168a.c:403:21: warning: variable 'channels' set but not used
The variable channels were being assigned some value but that was never
reused.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
Its upto you now. If you dont want to accept then I will add an extra
From: in the commit. But since that will not be a part of my scripts so
there will be chances of error. If you are worried about missing signoff,
then I can assure you that my scripts will catch that before i can send
it.
sound/soc/codecs/pcm3168a.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c
index 0c7248a..992a77e 100644
--- a/sound/soc/codecs/pcm3168a.c
+++ b/sound/soc/codecs/pcm3168a.c
@@ -400,13 +400,12 @@ static int pcm3168a_hw_params(struct snd_pcm_substream *substream,
struct pcm3168a_priv *pcm3168a = snd_soc_codec_get_drvdata(codec);
bool tx, master_mode;
u32 val, mask, shift, reg;
- unsigned int rate, channels, fmt, ratio, max_ratio;
+ unsigned int rate, fmt, ratio, max_ratio;
int i, min_frame_size;
snd_pcm_format_t format;
rate = params_rate(params);
format = params_format(params);
- channels = params_channels(params);
ratio = pcm3168a->sysclk / rate;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: pcm3168a: remove unused variable
2016-03-03 13:37 [PATCH] ASoC: pcm3168a: remove unused variable Sudip Mukherjee
@ 2016-03-04 2:48 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2016-03-04 2:48 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-kernel, alsa-devel
[-- Attachment #1: Type: text/plain, Size: 311 bytes --]
On Thu, Mar 03, 2016 at 07:07:49PM +0530, Sudip Mukherjee wrote:
> Its upto you now. If you dont want to accept then I will add an extra
> From: in the commit. But since that will not be a part of my scripts so
> there will be chances of error. If you are worried about missing signoff,
git config user.email
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-04 2:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-03 13:37 [PATCH] ASoC: pcm3168a: remove unused variable Sudip Mukherjee
2016-03-04 2:48 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).