From: Ben Hutchings <ben@decadent.org.uk>
To: Joseph Chang <joseph_chang@davicom.com.tw>,
"'Joseph CHANG'" <josright123@gmail.com>,
"'Peter Korsgaard'" <jacmet@sunsite.dk>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] dm9601: add support ethtool style utility
Date: Thu, 10 Mar 2016 13:17:45 +0000 [thread overview]
Message-ID: <1457615865.3001.36.camel@decadent.org.uk> (raw)
In-Reply-To: <201603101253.u2ACrnUJ002444@mail.davicom.com.tw>
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
On Thu, 2016-03-10 at 20:51 +0800, Joseph Chang wrote:
> I did verify to dump EEPROM data and also write EEPROM by per byte.
>
> 1.Plug dm9601/dm9621 adapter and has get dm9601.ko be 'insmod' to have 'eht0',
> 2.Run ethtool v3.7 (as attached executable file and it's help display.)
> 3. Commands:
> ./ethtool -e eth0 (dump EEPROM data for all the .get_eeprom_len )
> ./ethtool -E eth0 magic 0x9620 offset 0 value 0xf1 (write 0xf1 to eeprom byte0)
> ./ethtool -E eth0 magic 0x9620 offset 1 value 0xf2 (write 0xf2 to eeprom byte1)
> ./ethtool -E eth0 magic 0x9620 offset 2 value 0xf3 (write 0xf3 to eeprom byte2)
[...]
So you only tested writing 1 byte at a time. Try again with 3 bytes
and you'll see how it goes wrong.
Ben.
--
Ben Hutchings
To err is human; to really foul things up requires a computer.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next parent reply other threads:[~2016-03-10 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201603101253.u2ACrnUJ002444@mail.davicom.com.tw>
2016-03-10 13:17 ` Ben Hutchings [this message]
2016-03-11 11:08 ` [PATCH 3/3] dm9601: add support ethtool style utility Joseph Chang
2016-03-11 11:33 ` Ben Hutchings
2016-03-11 11:42 ` Ben Hutchings
2016-03-10 11:24 Joseph CHANG
2016-03-10 11:49 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457615865.3001.36.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=jacmet@sunsite.dk \
--cc=joseph_chang@davicom.com.tw \
--cc=josright123@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).