linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: martin.petersen@oracle.com,
	James.Bottomley@HansenPartnership.com,
	Adaptec OEM Raid Solutions <aacraid@adaptec.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	Tomas Henzl <thenzl@redhat.com>,
	Mahesh Rajashekhara <Mahesh.Rajashekhara@pmcs.com>,
	Raghava Aditya Renukunta <raghavaaditya.renukunta@pmcs.com>,
	Fengguang Wu <fengguang.wu@intel.com>
Subject: [PATCH 1/3] aacraid: add missing curly braces
Date: Mon, 14 Mar 2016 15:29:43 +0100	[thread overview]
Message-ID: <1457965789-3373916-2-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1457965789-3373916-1-git-send-email-arnd@arndb.de>

gcc-6 warns about obviously wrong indentation for newly added
code in aac_slave_configure():

drivers/scsi/aacraid/linit.c: In function 'aac_slave_configure':
drivers/scsi/aacraid/linit.c:458:3: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation]
   sdev->tagged_supported = 1;
   ^~~~
drivers/scsi/aacraid/linit.c:455:4: note: ...this 'else' clause, but it is not

gcc is correct, and evidently this was meant to be within the curly
braces that should have been there to start with. This patch adds
them, which avoids the warning and makes it clear what was intended
here.

Nothing changes in behavior because in the 'if' block, the
sdev->tagged_supported flag is known to be set already.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 6bf3b630d0a7 ("aacraid: SCSI blk tag support")
---
 drivers/scsi/aacraid/linit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c
index 21a67ed047e8..ff6caab8cc8b 100644
--- a/drivers/scsi/aacraid/linit.c
+++ b/drivers/scsi/aacraid/linit.c
@@ -452,10 +452,11 @@ static int aac_slave_configure(struct scsi_device *sdev)
 		else if (depth < 2)
 			depth = 2;
 		scsi_change_queue_depth(sdev, depth);
-	} else
+	} else {
 		scsi_change_queue_depth(sdev, 1);
 
 		sdev->tagged_supported = 1;
+	}
 
 	return 0;
 }
-- 
2.7.0

  reply	other threads:[~2016-03-14 14:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-14 14:29 gcc-6.0 warnings for scsi Arnd Bergmann
2016-03-14 14:29 ` Arnd Bergmann [this message]
2016-03-18 19:20   ` [PATCH 1/3] aacraid: add missing curly braces Martin K. Petersen
2016-03-18 20:50   ` Raghava Aditya Renukunta
2016-03-22  0:26   ` Martin K. Petersen
2016-03-14 14:29 ` [PATCH 2/3] lpfc: fix misleading indentation Arnd Bergmann
2016-03-14 15:19   ` Hannes Reinecke
2016-03-14 15:25     ` Arnd Bergmann
2016-03-14 15:26       ` Hannes Reinecke
2016-03-14 15:48         ` Ewan Milne
2016-03-14 22:27   ` Sebastian Herbszt
2016-03-18 19:22   ` Martin K. Petersen
2016-03-14 14:29 ` [PATCH 3/3] megaraid_sas: add missing curly braces in ioctl handler Arnd Bergmann
2016-03-14 15:20   ` Hannes Reinecke
2016-03-15 11:08   ` Sumit Saxena
2016-03-18 19:23   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457965789-3373916-2-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=JBottomley@odin.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=Mahesh.Rajashekhara@pmcs.com \
    --cc=aacraid@adaptec.com \
    --cc=fengguang.wu@intel.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=raghavaaditya.renukunta@pmcs.com \
    --cc=thenzl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).