From: Ewan Milne <emilne@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
martin.petersen@oracle.com,
James.Bottomley@hansenpartnership.com,
James Smart <james.smart@avagotech.com>,
Dick Kennedy <dick.kennedy@avagotech.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Hannes Reinecke <hare@suse.com>,
Sebastian Herbszt <herbszt@gmx.de>
Subject: Re: [PATCH 2/3] lpfc: fix misleading indentation
Date: Mon, 14 Mar 2016 11:48:03 -0400 [thread overview]
Message-ID: <1457970483.4188.19.camel@localhost.localdomain> (raw)
In-Reply-To: <56E6D824.3080809@suse.de>
On Mon, 2016-03-14 at 16:26 +0100, Hannes Reinecke wrote:
> On 03/14/2016 04:25 PM, Arnd Bergmann wrote:
> > On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote:
> >>> vports = lpfc_create_vport_work_array(phba);
> >>> - if (vports != NULL)
> >>> + if (vports != NULL) {
> >>> for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++) {
> >>> struct Scsi_Host *shost;
> >>> shost = lpfc_shost_from_vport(vports[i]);
> >>> @@ -2877,7 +2877,8 @@ lpfc_online(struct lpfc_hba *phba)
> >>> }
> >>> spin_unlock_irq(shost->host_lock);
> >>> }
> >>> - lpfc_destroy_vport_work_array(phba, vports);
> >>> + }
> >>> + lpfc_destroy_vport_work_array(phba, vports);
> >>>
> >>> lpfc_unblock_mgmt_io(phba);
> >>> return 0;
> >>>
> >> Nope.
> >>
> >> vports is only valid from within the indentation block, so it should
> >> be moved into it.
> >>
> >>
> >
> > Well, every other user of the function also looks like
> >
> > vports = lpfc_create_vport_work_array(phba);
> > if (vports != NULL) {
> > do_something(vports);
> > }
> > lpfc_destroy_vport_work_array(phba, vports);
Actually the lpfc code is inconsistent about whether the _destroy call
is within the (vports != NULL) test or not, but as you say below it
doesn't matter.
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
> >
> > and lpfc_destroy_vport_work_array() does nothing if its argument is NULL.
> >
> > I still think my patch is the correct fix for the warning.
> >
> Okay, good point.
>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
>
> Cheers,
>
> Hannes
next prev parent reply other threads:[~2016-03-14 15:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 14:29 gcc-6.0 warnings for scsi Arnd Bergmann
2016-03-14 14:29 ` [PATCH 1/3] aacraid: add missing curly braces Arnd Bergmann
2016-03-18 19:20 ` Martin K. Petersen
2016-03-18 20:50 ` Raghava Aditya Renukunta
2016-03-22 0:26 ` Martin K. Petersen
2016-03-14 14:29 ` [PATCH 2/3] lpfc: fix misleading indentation Arnd Bergmann
2016-03-14 15:19 ` Hannes Reinecke
2016-03-14 15:25 ` Arnd Bergmann
2016-03-14 15:26 ` Hannes Reinecke
2016-03-14 15:48 ` Ewan Milne [this message]
2016-03-14 22:27 ` Sebastian Herbszt
2016-03-18 19:22 ` Martin K. Petersen
2016-03-14 14:29 ` [PATCH 3/3] megaraid_sas: add missing curly braces in ioctl handler Arnd Bergmann
2016-03-14 15:20 ` Hannes Reinecke
2016-03-15 11:08 ` Sumit Saxena
2016-03-18 19:23 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457970483.4188.19.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=JBottomley@odin.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=dick.kennedy@avagotech.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=herbszt@gmx.de \
--cc=james.smart@avagotech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).