* [PATCH] irqchip: tegra: Switch to use irq_domain_free_irqs_common
@ 2016-03-20 12:44 Axel Lin
2016-03-20 19:12 ` [tip:irq/urgent] irqchip/tegra: " tip-bot for Axel Lin
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2016-03-20 12:44 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier
Cc: Stephen Warren, Thierry Reding, Alexandre Courbot, linux-kernel,
linux-tegra
Current code calls irq_domain_alloc_irqs_parent() in .alloc,
so it should call irq_domain_free_irqs_parent() accordingly in .free.
Fix it by switching to use irq_domain_free_irqs_common() instead of
open-coded.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/irqchip/irq-tegra.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c
index 121ec30..50be963 100644
--- a/drivers/irqchip/irq-tegra.c
+++ b/drivers/irqchip/irq-tegra.c
@@ -275,22 +275,10 @@ static int tegra_ictlr_domain_alloc(struct irq_domain *domain,
&parent_fwspec);
}
-static void tegra_ictlr_domain_free(struct irq_domain *domain,
- unsigned int virq,
- unsigned int nr_irqs)
-{
- unsigned int i;
-
- for (i = 0; i < nr_irqs; i++) {
- struct irq_data *d = irq_domain_get_irq_data(domain, virq + i);
- irq_domain_reset_irq_data(d);
- }
-}
-
static const struct irq_domain_ops tegra_ictlr_domain_ops = {
.translate = tegra_ictlr_domain_translate,
.alloc = tegra_ictlr_domain_alloc,
- .free = tegra_ictlr_domain_free,
+ .free = irq_domain_free_irqs_common,
};
static int __init tegra_ictlr_init(struct device_node *node,
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:irq/urgent] irqchip/tegra: Switch to use irq_domain_free_irqs_common
2016-03-20 12:44 [PATCH] irqchip: tegra: Switch to use irq_domain_free_irqs_common Axel Lin
@ 2016-03-20 19:12 ` tip-bot for Axel Lin
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Axel Lin @ 2016-03-20 19:12 UTC (permalink / raw)
To: linux-tip-commits
Cc: axel.lin, thierry.reding, mingo, hpa, linux-kernel, tglx,
swarren, gnurou, marc.zyngier, jason
Commit-ID: 46f920d8a970cf102e18f25814a4ff4729ad8537
Gitweb: http://git.kernel.org/tip/46f920d8a970cf102e18f25814a4ff4729ad8537
Author: Axel Lin <axel.lin@ingics.com>
AuthorDate: Sun, 20 Mar 2016 20:44:05 +0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Sun, 20 Mar 2016 20:08:28 +0100
irqchip/tegra: Switch to use irq_domain_free_irqs_common
Current code calls irq_domain_alloc_irqs_parent() in .alloc,
so it should call irq_domain_free_irqs_parent() accordingly in .free.
Fix it by switching to use irq_domain_free_irqs_common() instead of
the open-coded private implementation.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org
Link: http://lkml.kernel.org/r/1458477845.28679.1.camel@ingics.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/irqchip/irq-tegra.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c
index 121ec30..50be963 100644
--- a/drivers/irqchip/irq-tegra.c
+++ b/drivers/irqchip/irq-tegra.c
@@ -275,22 +275,10 @@ static int tegra_ictlr_domain_alloc(struct irq_domain *domain,
&parent_fwspec);
}
-static void tegra_ictlr_domain_free(struct irq_domain *domain,
- unsigned int virq,
- unsigned int nr_irqs)
-{
- unsigned int i;
-
- for (i = 0; i < nr_irqs; i++) {
- struct irq_data *d = irq_domain_get_irq_data(domain, virq + i);
- irq_domain_reset_irq_data(d);
- }
-}
-
static const struct irq_domain_ops tegra_ictlr_domain_ops = {
.translate = tegra_ictlr_domain_translate,
.alloc = tegra_ictlr_domain_alloc,
- .free = tegra_ictlr_domain_free,
+ .free = irq_domain_free_irqs_common,
};
static int __init tegra_ictlr_init(struct device_node *node,
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-20 19:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-20 12:44 [PATCH] irqchip: tegra: Switch to use irq_domain_free_irqs_common Axel Lin
2016-03-20 19:12 ` [tip:irq/urgent] irqchip/tegra: " tip-bot for Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).