[PATCH] i40iw: pass hw_stats by reference rather than by value

[PATCH] i40iw: pass hw_stats by reference rather than by value

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

passing hw_stats by value requires a 280 byte copy so instead
pass it by reference is much more efficient.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/infiniband/hw/i40iw/i40iw_virtchnl.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c b/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
index 6b68f78..62bb8265 100644
--- a/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
+++ b/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
@@ -254,7 +254,7 @@ static void vchnl_pf_send_get_hmc_fcn_resp(struct i40iw_sc_dev *dev,
 static void vchnl_pf_send_get_pe_stats_resp(struct i40iw_sc_dev *dev,
 					    u32 vf_id,
 					    struct i40iw_virtchnl_op_buf *vchnl_msg,
-					    struct i40iw_dev_hw_stats hw_stats)
+					    struct i40iw_dev_hw_stats *hw_stats)
 {
 	enum i40iw_status_code ret_code;
 	u8 resp_buffer[sizeof(struct i40iw_virtchnl_resp_buf) + sizeof(struct i40iw_dev_hw_stats) - 1];
@@ -264,7 +264,7 @@ static void vchnl_pf_send_get_pe_stats_resp(struct i40iw_sc_dev *dev,
 	vchnl_msg_resp->iw_chnl_op_ctx = vchnl_msg->iw_chnl_op_ctx;
 	vchnl_msg_resp->iw_chnl_buf_len = sizeof(resp_buffer);
 	vchnl_msg_resp->iw_op_ret_code = I40IW_SUCCESS;
-	*((struct i40iw_dev_hw_stats *)vchnl_msg_resp->iw_chnl_buf) = hw_stats;
+	*((struct i40iw_dev_hw_stats *)vchnl_msg_resp->iw_chnl_buf) = *hw_stats;
 	ret_code = dev->vchnl_if.vchnl_send(dev, vf_id, resp_buffer, sizeof(resp_buffer));
 	if (ret_code)
 		i40iw_debug(dev, I40IW_DEBUG_VIRT,
@@ -541,7 +541,7 @@ enum i40iw_status_code i40iw_vchnl_recv_pf(struct i40iw_sc_dev *dev,
 		devstat->ops.iw_hw_stat_read_all(devstat, &devstat->hw_stats);
 		spin_unlock_irqrestore(&dev->dev_pestat.stats_lock, flags);
 		vf_dev->msg_count--;
-		vchnl_pf_send_get_pe_stats_resp(dev, vf_id, vchnl_msg, devstat->hw_stats);
+		vchnl_pf_send_get_pe_stats_resp(dev, vf_id, vchnl_msg, &devstat->hw_stats);
 		break;
 	default:
 		i40iw_debug(dev, I40IW_DEBUG_VIRT,
-- 
2.7.4

Re: [PATCH] i40iw: pass hw_stats by reference rather than by value

[Chien Tin Tung]

On Mon, Mar 28, 2016 at 12:14:46PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> passing hw_stats by value requires a 280 byte copy so instead
> pass it by reference is much more efficient.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thank you for the patch Colin.

Acked-by: Chien Tin Tung <chien.tin.tung@intel.com>

Re: [PATCH] i40iw: pass hw_stats by reference rather than by value

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

On 03/28/2016 07:57 PM, Chien Tin Tung wrote:
> On Mon, Mar 28, 2016 at 12:14:46PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> passing hw_stats by value requires a 280 byte copy so instead
>> pass it by reference is much more efficient.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Thank you for the patch Colin.
> 
> Acked-by: Chien Tin Tung <chien.tin.tung@intel.com>
> 

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]