* [PATCH V2 0/2] scripts: small fixes
@ 2016-04-12 20:54 Maxim Zhukov
2016-04-12 20:54 ` [PATCH V2 1/2] scripts: genksyms: fix resource leak Maxim Zhukov
2016-04-12 20:55 ` [PATCH V2 2/2] scripts: dtc: fix memory leak after realloc Maxim Zhukov
0 siblings, 2 replies; 6+ messages in thread
From: Maxim Zhukov @ 2016-04-12 20:54 UTC (permalink / raw)
To: linux-kernel
Cc: Michal Marek, Rob Herring, Frank Rowand, Grant Likely, Maxim Zhukov
This patch series fixed small bugs intro scripts folder
Maxim Zhukov (2):
scripts: genksyms: fix resource leak
scripts: dtc: fix memory leak after realloc
scripts/dtc/fdtput.c | 10 +++++++---
scripts/genksyms/genksyms.c | 3 +++
2 files changed, 10 insertions(+), 3 deletions(-)
--
2.7.1.1.g3617aa0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2 1/2] scripts: genksyms: fix resource leak
2016-04-12 20:54 [PATCH V2 0/2] scripts: small fixes Maxim Zhukov
@ 2016-04-12 20:54 ` Maxim Zhukov
2016-04-20 7:26 ` Michal Marek
2016-04-12 20:55 ` [PATCH V2 2/2] scripts: dtc: fix memory leak after realloc Maxim Zhukov
1 sibling, 1 reply; 6+ messages in thread
From: Maxim Zhukov @ 2016-04-12 20:54 UTC (permalink / raw)
To: linux-kernel
Cc: Michal Marek, Rob Herring, Frank Rowand, Grant Likely, Maxim Zhukov
This commit fixed resource leak at func main
Signed-off-by: Maxim Zhukov <mussitantesmortem@gmail.com>
---
scripts/genksyms/genksyms.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/genksyms/genksyms.c b/scripts/genksyms/genksyms.c
index dafaf96..06121ce 100644
--- a/scripts/genksyms/genksyms.c
+++ b/scripts/genksyms/genksyms.c
@@ -873,5 +873,8 @@ int main(int argc, char **argv)
(double)nsyms / (double)HASH_BUCKETS);
}
+ if (dumpfile)
+ fclose(dumpfile);
+
return errors != 0;
}
--
2.7.1.1.g3617aa0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V2 2/2] scripts: dtc: fix memory leak after realloc
2016-04-12 20:54 [PATCH V2 0/2] scripts: small fixes Maxim Zhukov
2016-04-12 20:54 ` [PATCH V2 1/2] scripts: genksyms: fix resource leak Maxim Zhukov
@ 2016-04-12 20:55 ` Maxim Zhukov
2016-04-12 21:11 ` Rob Herring
1 sibling, 1 reply; 6+ messages in thread
From: Maxim Zhukov @ 2016-04-12 20:55 UTC (permalink / raw)
To: linux-kernel
Cc: Michal Marek, Rob Herring, Frank Rowand, Grant Likely,
Maxim Zhukov, devicetree-compiler
This commit fixed memory leak after errors realloc.
Signed-off-by: Maxim Zhukov <mussitantesmortem@gmail.com>
---
scripts/dtc/fdtput.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/scripts/dtc/fdtput.c b/scripts/dtc/fdtput.c
index f2197f5..1042319 100644
--- a/scripts/dtc/fdtput.c
+++ b/scripts/dtc/fdtput.c
@@ -75,8 +75,9 @@ static int encode_value(struct display_info *disp, char **arg, int arg_count,
char *ptr; /* pointer to current value position */
int len; /* length of this cell/string/byte */
int ival;
- int upto; /* the number of bytes we have written to buf */
+ int upto; /* the number of bytes we have written to buf */
char fmt[3];
+ void *save_ptr = NULL; /* save pointer to realloc */
upto = 0;
@@ -96,12 +97,15 @@ static int encode_value(struct display_info *disp, char **arg, int arg_count,
/* enlarge our value buffer by a suitable margin if needed */
if (upto + len > value_size) {
value_size = (upto + len) + 500;
- value = realloc(value, value_size);
- if (!value) {
+ void *save_ptr = realloc(value, value_size);
+
+ if (!save_ptr) {
+ free(value);
fprintf(stderr, "Out of mmory: cannot alloc "
"%d bytes\n", value_size);
return -1;
}
+ value = save_ptr;
}
ptr = value + upto;
--
2.7.1.1.g3617aa0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2 2/2] scripts: dtc: fix memory leak after realloc
2016-04-12 20:55 ` [PATCH V2 2/2] scripts: dtc: fix memory leak after realloc Maxim Zhukov
@ 2016-04-12 21:11 ` Rob Herring
2016-04-13 4:17 ` David Gibson
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2016-04-12 21:11 UTC (permalink / raw)
To: Maxim Zhukov
Cc: linux-kernel, Michal Marek, Frank Rowand, Grant Likely,
devicetree-compiler
On Tue, Apr 12, 2016 at 3:55 PM, Maxim Zhukov
<mussitantesmortem@gmail.com> wrote:
> This commit fixed memory leak after errors realloc.
>
> Signed-off-by: Maxim Zhukov <mussitantesmortem@gmail.com>
> ---
> scripts/dtc/fdtput.c | 10 +++++++---
Again, your patch is against the kernel copy of dtc. It needs to be
against upstream dtc and then I can update the kernel copy once this
lands.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2 2/2] scripts: dtc: fix memory leak after realloc
2016-04-12 21:11 ` Rob Herring
@ 2016-04-13 4:17 ` David Gibson
0 siblings, 0 replies; 6+ messages in thread
From: David Gibson @ 2016-04-13 4:17 UTC (permalink / raw)
To: Rob Herring
Cc: Maxim Zhukov, linux-kernel, Michal Marek, Frank Rowand,
Grant Likely, devicetree-compiler
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
On Tue, Apr 12, 2016 at 04:11:17PM -0500, Rob Herring wrote:
> On Tue, Apr 12, 2016 at 3:55 PM, Maxim Zhukov
> <mussitantesmortem@gmail.com> wrote:
> > This commit fixed memory leak after errors realloc.
> >
> > Signed-off-by: Maxim Zhukov <mussitantesmortem@gmail.com>
> > ---
> > scripts/dtc/fdtput.c | 10 +++++++---
>
> Again, your patch is against the kernel copy of dtc. It needs to be
> against upstream dtc and then I can update the kernel copy once this
> lands.
Right. TBH, I'm not particularly concerned about the leak anyway.
The memory will be freed when fdtput exits moments later, so it's
really not a big deal.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2 1/2] scripts: genksyms: fix resource leak
2016-04-12 20:54 ` [PATCH V2 1/2] scripts: genksyms: fix resource leak Maxim Zhukov
@ 2016-04-20 7:26 ` Michal Marek
0 siblings, 0 replies; 6+ messages in thread
From: Michal Marek @ 2016-04-20 7:26 UTC (permalink / raw)
To: Maxim Zhukov
Cc: linux-kernel, Michal Marek, Rob Herring, Frank Rowand, Grant Likely
On Tue, Apr 12, 2016 at 11:54:59PM +0300, Maxim Zhukov wrote:
> This commit fixed resource leak at func main
>
> Signed-off-by: Maxim Zhukov <mussitantesmortem@gmail.com>
Applied to kbuild.git#kbuild. Although the leak is harmless.
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-20 7:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-12 20:54 [PATCH V2 0/2] scripts: small fixes Maxim Zhukov
2016-04-12 20:54 ` [PATCH V2 1/2] scripts: genksyms: fix resource leak Maxim Zhukov
2016-04-20 7:26 ` Michal Marek
2016-04-12 20:55 ` [PATCH V2 2/2] scripts: dtc: fix memory leak after realloc Maxim Zhukov
2016-04-12 21:11 ` Rob Herring
2016-04-13 4:17 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).