From: Gustavo Padovan <gustavo@padovan.org>
To: dri-devel@lists.freedesktop.org
Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 14/14] drm: remove legacy drm_send_vblank_event()
Date: Thu, 14 Apr 2016 10:48:25 -0700 [thread overview]
Message-ID: <1460656118-16766-14-git-send-email-gustavo@padovan.org> (raw)
In-Reply-To: <1460656118-16766-1-git-send-email-gustavo@padovan.org>
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
We don't have any user of this function anymore, let's remove it.
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/drm_irq.c | 31 ++++++-------------------------
include/drm/drmP.h | 2 --
2 files changed, 6 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c
index 3c1a6f1..c0205ed 100644
--- a/drivers/gpu/drm/drm_irq.c
+++ b/drivers/gpu/drm/drm_irq.c
@@ -1100,21 +1100,19 @@ void drm_crtc_arm_vblank_event(struct drm_crtc *crtc,
EXPORT_SYMBOL(drm_crtc_arm_vblank_event);
/**
- * drm_send_vblank_event - helper to send vblank event after pageflip
- * @dev: DRM device
- * @pipe: CRTC index
+ * drm_crtc_send_vblank_event - helper to send vblank event after pageflip
+ * @crtc: the source CRTC of the vblank event
* @e: the event to send
*
* Updates sequence # and timestamp on event, and sends it to userspace.
* Caller must hold event lock.
- *
- * This is the legacy version of drm_crtc_send_vblank_event().
*/
-void drm_send_vblank_event(struct drm_device *dev, unsigned int pipe,
- struct drm_pending_vblank_event *e)
+void drm_crtc_send_vblank_event(struct drm_crtc *crtc,
+ struct drm_pending_vblank_event *e)
{
+ struct drm_device *dev = crtc->dev;
+ unsigned int seq, pipe = drm_crtc_index(crtc);
struct timeval now;
- unsigned int seq;
if (dev->num_crtcs > 0) {
seq = drm_vblank_count_and_time(dev, pipe, &now);
@@ -1126,23 +1124,6 @@ void drm_send_vblank_event(struct drm_device *dev, unsigned int pipe,
e->pipe = pipe;
send_vblank_event(dev, e, seq, &now);
}
-EXPORT_SYMBOL(drm_send_vblank_event);
-
-/**
- * drm_crtc_send_vblank_event - helper to send vblank event after pageflip
- * @crtc: the source CRTC of the vblank event
- * @e: the event to send
- *
- * Updates sequence # and timestamp on event, and sends it to userspace.
- * Caller must hold event lock.
- *
- * This is the native KMS version of drm_send_vblank_event().
- */
-void drm_crtc_send_vblank_event(struct drm_crtc *crtc,
- struct drm_pending_vblank_event *e)
-{
- drm_send_vblank_event(crtc->dev, drm_crtc_index(crtc), e);
-}
EXPORT_SYMBOL(drm_crtc_send_vblank_event);
/**
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 3c8422c..d0e1332 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -970,8 +970,6 @@ extern u32 drm_vblank_count_and_time(struct drm_device *dev, unsigned int pipe,
struct timeval *vblanktime);
extern u32 drm_crtc_vblank_count_and_time(struct drm_crtc *crtc,
struct timeval *vblanktime);
-extern void drm_send_vblank_event(struct drm_device *dev, unsigned int pipe,
- struct drm_pending_vblank_event *e);
extern void drm_crtc_send_vblank_event(struct drm_crtc *crtc,
struct drm_pending_vblank_event *e);
extern void drm_arm_vblank_event(struct drm_device *dev, unsigned int pipe,
--
2.5.5
next prev parent reply other threads:[~2016-04-14 17:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 17:48 [PATCH 01/14] drm/amdgpu: use drm_crtc_send_vblank_event() Gustavo Padovan
2016-04-14 17:48 ` [PATCH 02/14] drm/armada: " Gustavo Padovan
2016-04-14 17:48 ` [PATCH 03/14] drm/atmel: " Gustavo Padovan
2016-04-14 17:48 ` [PATCH 05/14] drm/msm: " Gustavo Padovan
2016-04-14 20:51 ` Rob Clark
2016-04-19 14:02 ` Gustavo Padovan
2016-04-20 11:13 ` Daniel Vetter
2016-05-02 15:04 ` Daniel Vetter
2016-04-14 17:48 ` [PATCH 06/14] drm/qxl: " Gustavo Padovan
2016-04-14 17:48 ` [PATCH 07/14] drm/nouveau: " Gustavo Padovan
2016-04-25 7:01 ` Mario Kleiner
2016-04-25 20:06 ` Gustavo Padovan
2016-04-14 17:48 ` [PATCH 08/14] drm/radeon: " Gustavo Padovan
2016-04-14 17:48 ` [PATCH 09/14] drm/rcar-du: " Gustavo Padovan
2016-04-14 21:59 ` Laurent Pinchart
2016-04-14 17:48 ` [PATCH 10/14] drm/shmobile: " Gustavo Padovan
2016-04-14 21:59 ` Laurent Pinchart
2016-05-02 15:06 ` Daniel Vetter
2016-04-14 17:48 ` [PATCH 11/14] drm/tilcdc: " Gustavo Padovan
2016-04-19 12:56 ` Jyri Sarha
2016-04-19 14:03 ` Gustavo Padovan
2016-05-02 15:05 ` Daniel Vetter
2016-05-02 18:58 ` Jyri Sarha
2016-04-14 17:48 ` [PATCH 12/14] drm/udl: " Gustavo Padovan
2016-04-14 17:48 ` [PATCH 13/14] drm/virtio: " Gustavo Padovan
2016-04-14 17:48 ` Gustavo Padovan [this message]
2016-04-15 2:55 ` [PATCH 01/14] drm/amdgpu: " Michel Dänzer
2016-05-02 15:03 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460656118-16766-14-git-send-email-gustavo@padovan.org \
--to=gustavo@padovan.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).