Re: [PATCH 01/14] drm/amdgpu: use drm_crtc_send_vblank_event()

From: Daniel Vetter <daniel@ffwll.ch>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: "Gustavo Padovan" <gustavo@padovan.org>,
	"Tom St Denis" <tom.stdenis@amd.com>,
	"Jammy Zhou" <Jammy.Zhou@amd.com>,
	"Marek Olšák" <marek.olsak@amd.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org, yanyang1 <young.yang@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 01/14] drm/amdgpu: use drm_crtc_send_vblank_event()
Date: Mon, 2 May 2016 17:03:40 +0200	[thread overview]
Message-ID: <20160502150340.GR14148@phenom.ffwll.local> (raw)
In-Reply-To: <57105814.20502@daenzer.net>

On Fri, Apr 15, 2016 at 11:55:16AM +0900, Michel Dänzer wrote:
> On 15.04.2016 02:48, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > Replace the legacy drm_send_vblank_event() with the new helper function.
> > 
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +-
> >  drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +-
> >  drivers/gpu/drm/amd/amdgpu/dce_v8_0.c  | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
> > index 6de2ce53..92c5a71 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
> > @@ -3370,7 +3370,7 @@ static int dce_v10_0_pageflip_irq(struct amdgpu_device *adev,
> >  
> >  	/* wakeup usersapce */
> >  	if (works->event)
> > -		drm_send_vblank_event(adev->ddev, crtc_id, works->event);
> > +		drm_crtc_send_vblank_event(&amdgpu_crtc->base, works->event);
> >  
> >  	spin_unlock_irqrestore(&adev->ddev->event_lock, flags);
> >  
> > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
> > index e9ccc6b..2f784f2 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c
> > @@ -3366,7 +3366,7 @@ static int dce_v11_0_pageflip_irq(struct amdgpu_device *adev,
> >  
> >  	/* wakeup usersapce */
> >  	if(works->event)
> > -		drm_send_vblank_event(adev->ddev, crtc_id, works->event);
> > +		drm_crtc_send_vblank_event(&amdgpu_crtc->base, works->event);
> >  
> >  	spin_unlock_irqrestore(&adev->ddev->event_lock, flags);
> >  
> > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> > index e56b55d..9155e3b 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c
> > @@ -3379,7 +3379,7 @@ static int dce_v8_0_pageflip_irq(struct amdgpu_device *adev,
> >  
> >  	/* wakeup usersapce */
> >  	if (works->event)
> > -		drm_send_vblank_event(adev->ddev, crtc_id, works->event);
> > +		drm_crtc_send_vblank_event(&amdgpu_crtc->base, works->event);
> >  
> >  	spin_unlock_irqrestore(&adev->ddev->event_lock, flags);
> >  
> > 
> 
> This patch and patch 8 are
> 
> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>

Both applied to drm-misc.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch