* [PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes
@ 2016-04-21 3:51 David Rivshin (Allworx)
0 siblings, 0 replies; 5+ messages in thread
From: David Rivshin (Allworx) @ 2016-04-21 3:51 UTC (permalink / raw)
To: netdev, linux-omap
Cc: linux-arm-kernel, devicetree, linux-kernel, David Miller,
Mugunthan V N, Grygorii Strashko, Andrew Goodbody,
Markus Brunner, Nicolas Chauvet
From: David Rivshin <drivshin@allworx.com>
The first patch fixes a bug that makes dual_emac mode break if
either slave uses the phy-handle property in the devicetree.
The second patch fixes some cosmetic problems with error messages,
and also makes the binding documentation more explicit.
The third patch cleans up the fixed-link case to work like
the now-fixed phy-handle case.
I have tested on the following hardware configurations:
- (EVMSK) dual emac, phy_id property in both slaves
- (EVMSK) dual emac, phy-handle property in both slaves
- (BeagleBoneBlack) single emac, phy_id property
- (custom) single emac, fixed-link subnode
Nicolas Chauvet reported testing on an HP t410 (dm8148).
Markus Brunner reported testing v1 on the following [1]:
- emac0 with phy_id and emac1 with fixed phy
- emac0 with phy-handle and emac1 with fixed phy
- emac0 with fixed phy and emac1 with fixed phy
Changes since v1 [2]:
- Rebased
- Added Tested-by from Nicolas Chauvet on all patches
- Added Acked-by from Rob Herring for the binding change in patch 2 [3]
[1] http://www.spinics.net/lists/netdev/msg357890.html
[2] http://www.spinics.net/lists/netdev/msg357772.html
[3] http://www.spinics.net/lists/netdev/msg358254.html
David Rivshin (3):
drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac
config
drivers: net: cpsw: fix error messages when using phy-handle DT
property
drivers: net: cpsw: use of_phy_connect() in fixed-link case
Documentation/devicetree/bindings/net/cpsw.txt | 4 +--
drivers/net/ethernet/ti/cpsw.c | 41 +++++++++++++-------------
drivers/net/ethernet/ti/cpsw.h | 1 +
3 files changed, 23 insertions(+), 23 deletions(-)
--
2.5.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes
2016-04-21 17:50 David Rivshin (Allworx)
2016-04-22 6:55 ` Mugunthan V N
@ 2016-04-22 13:44 ` Andrew Goodbody
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Goodbody @ 2016-04-22 13:44 UTC (permalink / raw)
To: David Rivshin (Allworx), netdev, linux-omap
Cc: linux-arm-kernel, devicetree, linux-kernel, David Miller,
Mugunthan V N, Grygorii Strashko, Markus Brunner,
Nicolas Chauvet
> From: David Rivshin <drivshin@allworx.com>
>
> The first patch fixes a bug that makes dual_emac mode break if either slave
> uses the phy-handle property in the devicetree.
>
> The second patch fixes some cosmetic problems with error messages, and
> also makes the binding documentation more explicit.
>
> The third patch cleans up the fixed-link case to work like the now-fixed phy-
> handle case.
>
> I have tested on the following hardware configurations:
> - (EVMSK) dual emac, phy_id property in both slaves
> - (EVMSK) dual emac, phy-handle property in both slaves
> - (BeagleBoneBlack) single emac, phy_id property
> - (custom) single emac, fixed-link subnode
>
> Nicolas Chauvet reported testing on an HP t410 (dm8148).
>
> Markus Brunner reported testing v1 on the following [1]:
> - emac0 with phy_id and emac1 with fixed phy
> - emac0 with phy-handle and emac1 with fixed phy
> - emac0 with fixed phy and emac1 with fixed phy
>
>
> Changes since v1 [2]:
> - Rebased
> - Added Tested-by from Nicolas Chauvet on all patches
> - Added Acked-by from Rob Herring for the binding change in patch 2 [3]
>
> [1] http://www.spinics.net/lists/netdev/msg357890.html
> [2] http://www.spinics.net/lists/netdev/msg357772.html
> [3] http://www.spinics.net/lists/netdev/msg358254.html
>
> David Rivshin (3):
> drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac
> config
> drivers: net: cpsw: fix error messages when using phy-handle DT
> property
> drivers: net: cpsw: use of_phy_connect() in fixed-link case
>
> Documentation/devicetree/bindings/net/cpsw.txt | 4 +--
> drivers/net/ethernet/ti/cpsw.c | 41 +++++++++++++-------------
> drivers/net/ethernet/ti/cpsw.h | 1 +
> 3 files changed, 23 insertions(+), 23 deletions(-)
>
> --
> 2.5.5
Tested on hardware with 2 PHYs but not dual_emac mode, DT has phy-handle entries.
Tested-by: Andrew Goodbody <andrew.goodbody@cambrionix.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes
2016-04-21 17:50 David Rivshin (Allworx)
@ 2016-04-22 6:55 ` Mugunthan V N
2016-04-22 13:44 ` Andrew Goodbody
1 sibling, 0 replies; 5+ messages in thread
From: Mugunthan V N @ 2016-04-22 6:55 UTC (permalink / raw)
To: David Rivshin (Allworx), netdev, linux-omap
Cc: linux-arm-kernel, devicetree, linux-kernel, David Miller,
Grygorii Strashko, Andrew Goodbody, Markus Brunner,
Nicolas Chauvet
On Thursday 21 April 2016 11:20 PM, David Rivshin (Allworx) wrote:
> From: David Rivshin <drivshin@allworx.com>
>
> The first patch fixes a bug that makes dual_emac mode break if
> either slave uses the phy-handle property in the devicetree.
>
> The second patch fixes some cosmetic problems with error messages,
> and also makes the binding documentation more explicit.
>
> The third patch cleans up the fixed-link case to work like
> the now-fixed phy-handle case.
>
> I have tested on the following hardware configurations:
> - (EVMSK) dual emac, phy_id property in both slaves
> - (EVMSK) dual emac, phy-handle property in both slaves
> - (BeagleBoneBlack) single emac, phy_id property
> - (custom) single emac, fixed-link subnode
>
> Nicolas Chauvet reported testing on an HP t410 (dm8148).
>
> Markus Brunner reported testing v1 on the following [1]:
> - emac0 with phy_id and emac1 with fixed phy
> - emac0 with phy-handle and emac1 with fixed phy
> - emac0 with fixed phy and emac1 with fixed phy
>
>
Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes
@ 2016-04-21 17:50 David Rivshin (Allworx)
2016-04-22 6:55 ` Mugunthan V N
2016-04-22 13:44 ` Andrew Goodbody
0 siblings, 2 replies; 5+ messages in thread
From: David Rivshin (Allworx) @ 2016-04-21 17:50 UTC (permalink / raw)
To: netdev, linux-omap
Cc: linux-arm-kernel, devicetree, linux-kernel, David Miller,
Mugunthan V N, Grygorii Strashko, Andrew Goodbody,
Markus Brunner, Nicolas Chauvet
From: David Rivshin <drivshin@allworx.com>
The first patch fixes a bug that makes dual_emac mode break if
either slave uses the phy-handle property in the devicetree.
The second patch fixes some cosmetic problems with error messages,
and also makes the binding documentation more explicit.
The third patch cleans up the fixed-link case to work like
the now-fixed phy-handle case.
I have tested on the following hardware configurations:
- (EVMSK) dual emac, phy_id property in both slaves
- (EVMSK) dual emac, phy-handle property in both slaves
- (BeagleBoneBlack) single emac, phy_id property
- (custom) single emac, fixed-link subnode
Nicolas Chauvet reported testing on an HP t410 (dm8148).
Markus Brunner reported testing v1 on the following [1]:
- emac0 with phy_id and emac1 with fixed phy
- emac0 with phy-handle and emac1 with fixed phy
- emac0 with fixed phy and emac1 with fixed phy
Changes since v1 [2]:
- Rebased
- Added Tested-by from Nicolas Chauvet on all patches
- Added Acked-by from Rob Herring for the binding change in patch 2 [3]
[1] http://www.spinics.net/lists/netdev/msg357890.html
[2] http://www.spinics.net/lists/netdev/msg357772.html
[3] http://www.spinics.net/lists/netdev/msg358254.html
David Rivshin (3):
drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac
config
drivers: net: cpsw: fix error messages when using phy-handle DT
property
drivers: net: cpsw: use of_phy_connect() in fixed-link case
Documentation/devicetree/bindings/net/cpsw.txt | 4 +--
drivers/net/ethernet/ti/cpsw.c | 41 +++++++++++++-------------
drivers/net/ethernet/ti/cpsw.h | 1 +
3 files changed, 23 insertions(+), 23 deletions(-)
--
2.5.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes
[not found] <1461209082-25609-1-git-send-email-drivshin.allworx@gmail.com>
@ 2016-04-21 4:20 ` David Rivshin (Allworx)
0 siblings, 0 replies; 5+ messages in thread
From: David Rivshin (Allworx) @ 2016-04-21 4:20 UTC (permalink / raw)
To: netdev, linux-omap
Cc: linux-arm-kernel, linux-kernel, David Miller, Mugunthan V N,
Grygorii Strashko, Andrew Goodbody, Heiko Schocher,
Markus Brunner, Nicolas Chauvet, Pascal Speck, Daniel Trautmann,
Tony Lindgren, devicetree
Sorry all for the noise. Gmail seems to be deciding that this outgoing
mail is spammy, and starts blocking it part-way through. I've tried
cutting down the CC list, but still no luck. If anyone knows how to get
around this (while still having a reasonable patch submission), please
let me know.
For tonight, I guess I have no choice but to give up. I'll try again
tomorrow in hopes gmail becomes sane again.
On Wed, 20 Apr 2016 23:24:39 -0400
"David Rivshin (Allworx)" <drivshin.allworx@gmail.com> wrote:
> From: David Rivshin <drivshin@allworx.com>
>
> The first patch fixes a bug that makes dual_emac mode break if
> either slave uses the phy-handle property in the devicetree.
>
> The second patch fixes some cosmetic problems with error messages,
> and also makes the binding documentation more explicit.
>
> The third patch cleans up the fixed-link case to work like
> the now-fixed phy-handle case.
>
> I have tested on the following hardware configurations:
> - (EVMSK) dual emac, phy_id property in both slaves
> - (EVMSK) dual emac, phy-handle property in both slaves
> - (BeagleBoneBlack) single emac, phy_id property
> - (custom) single emac, fixed-link subnode
>
> Nicolas Chauvet reported testing on an HP t410 (dm8148).
>
> Markus Brunner reported testing v1 on the following [1]:
> - emac0 with phy_id and emac1 with fixed phy
> - emac0 with phy-handle and emac1 with fixed phy
> - emac0 with fixed phy and emac1 with fixed phy
>
>
> Changes since v1 [2]:
> - Rebased
> - Added Tested-by from Nicolas Chauvet on all patches
> - Added Acked-by from Rob Herring for the binding change in patch 2 [3]
>
> [1] http://www.spinics.net/lists/netdev/msg357890.html
> [2] http://www.spinics.net/lists/netdev/msg357772.html
> [3] http://www.spinics.net/lists/netdev/msg358254.html
>
> David Rivshin (3):
> drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac
> config
> drivers: net: cpsw: fix error messages when using phy-handle DT
> property
> drivers: net: cpsw: use of_phy_connect() in fixed-link case
>
> Documentation/devicetree/bindings/net/cpsw.txt | 4 +--
> drivers/net/ethernet/ti/cpsw.c | 41 +++++++++++++-------------
> drivers/net/ethernet/ti/cpsw.h | 1 +
> 3 files changed, 23 insertions(+), 23 deletions(-)
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-22 13:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-21 3:51 [PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes David Rivshin (Allworx)
[not found] <1461209082-25609-1-git-send-email-drivshin.allworx@gmail.com>
2016-04-21 4:20 ` David Rivshin (Allworx)
2016-04-21 17:50 David Rivshin (Allworx)
2016-04-22 6:55 ` Mugunthan V N
2016-04-22 13:44 ` Andrew Goodbody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).