* [PATCH] net: mvneta: bm: fix dependencies again
@ 2016-05-11 20:13 Arnd Bergmann
2016-05-12 15:32 ` Gregory CLEMENT
2016-05-12 20:57 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-05-11 20:13 UTC (permalink / raw)
To: David S. Miller
Cc: Arnd Bergmann, Gregory CLEMENT, Paul Gortmaker, Marcin Wojtas,
netdev, linux-kernel
I tried to fix this before, but my previous fix was incomplete
and we can still get the same link error in randconfig builds
because of the way that Kconfig treats the
default y if MVNETA=y && MVNETA_BM_ENABLE
line that does not actually trigger when MVNETA_BM_ENABLE=m,
unlike I intended.
Changing the line to use MVNETA_BM_ENABLE!=n however has
the desired effect and hopefully makes all configurations
work as expected.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 019ded3aa7c9 ("net: mvneta: bm: clarify dependencies")
---
drivers/net/ethernet/marvell/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig
index b5c6d42daa12..2664827ddecd 100644
--- a/drivers/net/ethernet/marvell/Kconfig
+++ b/drivers/net/ethernet/marvell/Kconfig
@@ -68,7 +68,7 @@ config MVNETA
config MVNETA_BM
tristate
- default y if MVNETA=y && MVNETA_BM_ENABLE
+ default y if MVNETA=y && MVNETA_BM_ENABLE!=n
default MVNETA_BM_ENABLE
select HWBM
help
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: mvneta: bm: fix dependencies again
2016-05-11 20:13 [PATCH] net: mvneta: bm: fix dependencies again Arnd Bergmann
@ 2016-05-12 15:32 ` Gregory CLEMENT
2016-05-12 20:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Gregory CLEMENT @ 2016-05-12 15:32 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David S. Miller, Paul Gortmaker, Marcin Wojtas, netdev, linux-kernel
Hi Arnd,
On mer., mai 11 2016, Arnd Bergmann <arnd@arndb.de> wrote:
> I tried to fix this before, but my previous fix was incomplete
> and we can still get the same link error in randconfig builds
> because of the way that Kconfig treats the
>
> default y if MVNETA=y && MVNETA_BM_ENABLE
>
> line that does not actually trigger when MVNETA_BM_ENABLE=m,
> unlike I intended.
> Changing the line to use MVNETA_BM_ENABLE!=n however has
> the desired effect and hopefully makes all configurations
> work as expected.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 019ded3aa7c9 ("net: mvneta: bm: clarify dependencies")
It looks ok for me.
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Thanks,
Gregory
> ---
> drivers/net/ethernet/marvell/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/Kconfig b/drivers/net/ethernet/marvell/Kconfig
> index b5c6d42daa12..2664827ddecd 100644
> --- a/drivers/net/ethernet/marvell/Kconfig
> +++ b/drivers/net/ethernet/marvell/Kconfig
> @@ -68,7 +68,7 @@ config MVNETA
>
> config MVNETA_BM
> tristate
> - default y if MVNETA=y && MVNETA_BM_ENABLE
> + default y if MVNETA=y && MVNETA_BM_ENABLE!=n
> default MVNETA_BM_ENABLE
> select HWBM
> help
> --
> 2.7.0
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: mvneta: bm: fix dependencies again
2016-05-11 20:13 [PATCH] net: mvneta: bm: fix dependencies again Arnd Bergmann
2016-05-12 15:32 ` Gregory CLEMENT
@ 2016-05-12 20:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-05-12 20:57 UTC (permalink / raw)
To: arnd; +Cc: gregory.clement, paul.gortmaker, mw, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 11 May 2016 22:13:23 +0200
> I tried to fix this before, but my previous fix was incomplete
> and we can still get the same link error in randconfig builds
> because of the way that Kconfig treats the
>
> default y if MVNETA=y && MVNETA_BM_ENABLE
>
> line that does not actually trigger when MVNETA_BM_ENABLE=m,
> unlike I intended.
> Changing the line to use MVNETA_BM_ENABLE!=n however has
> the desired effect and hopefully makes all configurations
> work as expected.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 019ded3aa7c9 ("net: mvneta: bm: clarify dependencies")
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-12 20:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-11 20:13 [PATCH] net: mvneta: bm: fix dependencies again Arnd Bergmann
2016-05-12 15:32 ` Gregory CLEMENT
2016-05-12 20:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).