* [PATCH] of/unittest: Remove unnecessary module.h header inclusion
@ 2016-05-11 20:26 Javier Martinez Canillas
2016-05-16 14:21 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2016-05-11 20:26 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Frank Rowand, devicetree, Rob Herring
The OF_UNITTEST Kconfig symbol is bool so this unittest can only be
built-in and not build as a module. Also, nothing defined in this
header file used so is not necessary to include it.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/of/unittest.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index fd6318a91fa3..f34ed9310323 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -8,7 +8,6 @@
#include <linux/err.h>
#include <linux/errno.h>
#include <linux/hashtable.h>
-#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_fdt.h>
#include <linux/of_irq.h>
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] of/unittest: Remove unnecessary module.h header inclusion
2016-05-11 20:26 [PATCH] of/unittest: Remove unnecessary module.h header inclusion Javier Martinez Canillas
@ 2016-05-16 14:21 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2016-05-16 14:21 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel, Frank Rowand, devicetree
On Wed, May 11, 2016 at 04:26:18PM -0400, Javier Martinez Canillas wrote:
> The OF_UNITTEST Kconfig symbol is bool so this unittest can only be
> built-in and not build as a module. Also, nothing defined in this
> header file used so is not necessary to include it.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/of/unittest.c | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-16 14:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-11 20:26 [PATCH] of/unittest: Remove unnecessary module.h header inclusion Javier Martinez Canillas
2016-05-16 14:21 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).