linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Byungchul Park <byungchul.park@lge.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Luca Abeni <luca.abeni@unitn.it>,
	"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
	Rik van Riel <riel@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Wanpeng Li <wanpeng.li@hotmail.com>,
	Yuyang Du <yuyang.du@intel.com>,
	Mel Gorman <mgorman@techsingularity.net>,
	Mike Galbraith <umgwanakikbuti@gmail.com>,
	Matt Fleming <matt@codeblueprint.co.uk>
Subject: [RFC][PATCH 1/5] sched/fair: Update the rq clock before detaching tasks
Date: Thu, 12 May 2016 20:49:49 +0100	[thread overview]
Message-ID: <1463082593-27777-2-git-send-email-matt@codeblueprint.co.uk> (raw)
In-Reply-To: <1463082593-27777-1-git-send-email-matt@codeblueprint.co.uk>

detach_task_cfs_rq() may indirectly call rq_clock() to inform the
cpufreq code that the rq utilisation has changed. In which case, we
need to update the rq clock.

Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Mike Galbraith <umgwanakikbuti@gmail.com>
Cc: Yuyang Du <yuyang.du@intel.com>
Cc: Byungchul Park <byungchul.park@lge.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
---
 kernel/sched/fair.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 218f8e83db73..02856647339d 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8378,6 +8378,8 @@ static void detach_task_cfs_rq(struct task_struct *p)
 	struct sched_entity *se = &p->se;
 	struct cfs_rq *cfs_rq = cfs_rq_of(se);
 
+	update_rq_clock(task_rq(p));
+
 	if (!vruntime_normalized(p)) {
 		/*
 		 * Fix up our vruntime so that the current sleep doesn't
-- 
2.7.3

  reply	other threads:[~2016-05-12 19:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12 19:49 [RFC][PATCH 0/5] sched: Diagnostic checks for missing rq clock updates Matt Fleming
2016-05-12 19:49 ` Matt Fleming [this message]
2016-05-12 19:49 ` [RFC][PATCH 2/5] sched: Add wrappers for lockdep_(un)pin_lock() Matt Fleming
2016-05-12 19:49 ` [RFC][PATCH 3/5] sched/core: Reset RQCF_ACT_SKIP before unpinning rq->lock Matt Fleming
2016-05-12 19:49 ` [RFC][PATCH 4/5] sched/fair: Push rq lock pin/unpin into idle_balance() Matt Fleming
2016-05-12 19:49 ` [RFC][PATCH 5/5] sched/core: Add debug code to catch missing update_rq_clock() Matt Fleming
2016-05-15  2:14   ` Yuyang Du
2016-05-16  9:46     ` Matt Fleming
2016-05-16 20:11       ` Yuyang Du
2016-05-17 12:24         ` Matt Fleming
2016-05-17 19:01           ` Yuyang Du
2016-05-18  8:41             ` Matt Fleming
2016-05-18 22:51               ` Yuyang Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463082593-27777-2-git-send-email-matt@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=byungchul.park@lge.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.abeni@unitn.it \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=umgwanakikbuti@gmail.com \
    --cc=wanpeng.li@hotmail.com \
    --cc=yuyang.du@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).