* [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.
@ 2016-05-15 1:26 Shubham Bansal
2016-08-15 14:49 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Shubham Bansal @ 2016-05-15 1:26 UTC (permalink / raw)
To: gregkh, arve, riandrews, labbott, daniel.vetter, rohit.kr,
gioh.kim, Liviu.Dudau, paul.gortmaker, dmitry.kalinkin, chris,
neilzhang1123, eun.taik.lee, sriram, tiago.vignatti
Cc: devel, linux-kernel
Fixed a coding style issue. Issue reported by checkpatch.pl.
Signed-off-by: Shubham Bansal <illusionist.neo@gmail.com>
---
drivers/staging/android/ion/ion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 8536567..2217ccb 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -184,7 +184,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
struct scatterlist *sg;
int i, ret;
- buffer = kzalloc(sizeof(struct ion_buffer), GFP_KERNEL);
+ buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
if (!buffer)
return ERR_PTR(-ENOMEM);
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.
2016-05-15 1:26 [PATCH] Staging: android: ion: fixed a kzalloc coding style issue Shubham Bansal
@ 2016-08-15 14:49 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2016-08-15 14:49 UTC (permalink / raw)
To: Shubham Bansal
Cc: arve, riandrews, labbott, daniel.vetter, rohit.kr, gioh.kim,
Liviu.Dudau, paul.gortmaker, dmitry.kalinkin, chris,
neilzhang1123, eun.taik.lee, sriram, tiago.vignatti, devel,
linux-kernel
On Sun, May 15, 2016 at 06:56:05AM +0530, Shubham Bansal wrote:
> Fixed a coding style issue. Issue reported by checkpatch.pl.
>
> Signed-off-by: Shubham Bansal <illusionist.neo@gmail.com>
> ---
> drivers/staging/android/ion/ion.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Doesn't apply to the tree :(
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.
2016-05-26 8:01 Shubham Bansal
2016-05-26 12:35 ` Luis de Bethencourt
@ 2016-08-15 14:51 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2016-08-15 14:51 UTC (permalink / raw)
To: Shubham Bansal
Cc: arve, riandrews, labbott, rohit.kr, gioh.kim, daniel.vetter,
kirill.shutemov, shawn.lin, dy, neilzhang1123, eun.taik.lee,
sriram, tiago.vignatti, devel, linux-kernel
On Thu, May 26, 2016 at 01:31:14PM +0530, Shubham Bansal wrote:
> Fixed a coding style issue. Issue reported by checkpatch.pl.
What coding style issue was fixed?
Be specific please.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.
2016-05-26 8:01 Shubham Bansal
@ 2016-05-26 12:35 ` Luis de Bethencourt
2016-08-15 14:51 ` Greg KH
1 sibling, 0 replies; 5+ messages in thread
From: Luis de Bethencourt @ 2016-05-26 12:35 UTC (permalink / raw)
To: Shubham Bansal, gregkh, arve, riandrews, labbott, rohit.kr,
gioh.kim, daniel.vetter, kirill.shutemov, shawn.lin, dy,
neilzhang1123, eun.taik.lee, sriram, tiago.vignatti
Cc: devel, linux-kernel
On 26/05/16 09:01, Shubham Bansal wrote:
> Fixed a coding style issue. Issue reported by checkpatch.pl.
>
> Signed-off-by: Shubham Bansal <illusionist.neo@gmail.com>
> ---
> drivers/staging/android/ion/ion.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 8536567..2217ccb 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -184,7 +184,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
> struct scatterlist *sg;
> int i, ret;
>
> - buffer = kzalloc(sizeof(struct ion_buffer), GFP_KERNEL);
> + buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
> if (!buffer)
> return ERR_PTR(-ENOMEM);
>
>
This patch looks good.
It is not a big issue, but have it in mind for the future. When fixing issues
reported by checkpatch, it is nice to paste the output warning of checkpatch
in the commit message.
Look at this example:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=e7a142aaa09fa5db015fd176d6943f888665829f
Thanks,
Luis
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.
@ 2016-05-26 8:01 Shubham Bansal
2016-05-26 12:35 ` Luis de Bethencourt
2016-08-15 14:51 ` Greg KH
0 siblings, 2 replies; 5+ messages in thread
From: Shubham Bansal @ 2016-05-26 8:01 UTC (permalink / raw)
To: gregkh, arve, riandrews, labbott, rohit.kr, gioh.kim,
daniel.vetter, kirill.shutemov, shawn.lin, dy, neilzhang1123,
eun.taik.lee, sriram, tiago.vignatti
Cc: devel, linux-kernel
Fixed a coding style issue. Issue reported by checkpatch.pl.
Signed-off-by: Shubham Bansal <illusionist.neo@gmail.com>
---
drivers/staging/android/ion/ion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 8536567..2217ccb 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -184,7 +184,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
struct scatterlist *sg;
int i, ret;
- buffer = kzalloc(sizeof(struct ion_buffer), GFP_KERNEL);
+ buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
if (!buffer)
return ERR_PTR(-ENOMEM);
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-15 14:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-15 1:26 [PATCH] Staging: android: ion: fixed a kzalloc coding style issue Shubham Bansal
2016-08-15 14:49 ` Greg KH
2016-05-26 8:01 Shubham Bansal
2016-05-26 12:35 ` Luis de Bethencourt
2016-08-15 14:51 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).