* [PATCH] net: au1000 eth: simplify logical expression
@ 2016-05-17 23:58 Heinrich Schuchardt
2016-05-18 5:03 ` Florian Fainelli
2016-05-19 18:32 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2016-05-17 23:58 UTC (permalink / raw)
To: David S. Miller
Cc: Andrew Lunn, Florian Fainelli, Ivan Vecera, Antonio Quartulli,
Florian Westphal, netdev, linux-kernel, Heinrich Schuchardt
(a && a > 0) is equivalent to (a > 0).
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/net/ethernet/amd/au1000_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/amd/au1000_eth.c b/drivers/net/ethernet/amd/au1000_eth.c
index 9af309e..e0fb0f1 100644
--- a/drivers/net/ethernet/amd/au1000_eth.c
+++ b/drivers/net/ethernet/amd/au1000_eth.c
@@ -1269,7 +1269,7 @@ static int au1000_probe(struct platform_device *pdev)
aup->phy_irq = pd->phy_irq;
}
- if (aup->phy_busid && aup->phy_busid > 0) {
+ if (aup->phy_busid > 0) {
dev_err(&pdev->dev, "MAC0-associated PHY attached 2nd MACs MII bus not supported yet\n");
err = -ENODEV;
goto err_mdiobus_alloc;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: au1000 eth: simplify logical expression
2016-05-17 23:58 [PATCH] net: au1000 eth: simplify logical expression Heinrich Schuchardt
@ 2016-05-18 5:03 ` Florian Fainelli
2016-05-19 18:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2016-05-18 5:03 UTC (permalink / raw)
To: Heinrich Schuchardt, David S. Miller
Cc: Andrew Lunn, Ivan Vecera, Antonio Quartulli, Florian Westphal,
netdev, linux-kernel
Le 17/05/2016 16:58, Heinrich Schuchardt a écrit :
> (a && a > 0) is equivalent to (a > 0).
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: au1000 eth: simplify logical expression
2016-05-17 23:58 [PATCH] net: au1000 eth: simplify logical expression Heinrich Schuchardt
2016-05-18 5:03 ` Florian Fainelli
@ 2016-05-19 18:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-05-19 18:32 UTC (permalink / raw)
To: xypron.glpk; +Cc: andrew, f.fainelli, ivecera, a, fw, netdev, linux-kernel
From: Heinrich Schuchardt <xypron.glpk@gmx.de>
Date: Wed, 18 May 2016 01:58:45 +0200
> (a && a > 0) is equivalent to (a > 0).
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-19 18:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-17 23:58 [PATCH] net: au1000 eth: simplify logical expression Heinrich Schuchardt
2016-05-18 5:03 ` Florian Fainelli
2016-05-19 18:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).