* [PATCH] brcmfmac: use kmemdup
@ 2016-05-19 13:59 Muhammad Falak R Wani
2016-05-20 7:53 ` Arend Van Spriel
2016-06-14 14:27 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Muhammad Falak R Wani @ 2016-05-19 13:59 UTC (permalink / raw)
To: Kalle Valo
Cc: Brett Rudley, Arend van Spriel, Franky (Zhenhui) Lin,
Hante Meuleman, Pieter-Paul Giesberts, Rafał Miłecki,
linux-wireless, brcm80211-dev-list, netdev, linux-kernel
Use kmemdup when some other buffer is immediately copied into allocated
region. It replaces call to allocation followed by memcpy, by a single
call to kmemdup.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index d0631b6..705adaa 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -6699,11 +6699,10 @@ struct brcmf_cfg80211_info *brcmf_cfg80211_attach(struct brcmf_pub *drvr,
return NULL;
}
- ops = kzalloc(sizeof(*ops), GFP_KERNEL);
+ ops = kmemdup(&brcmf_cfg80211_ops, sizeof(*ops), GFP_KERNEL);
if (!ops)
return NULL;
- memcpy(ops, &brcmf_cfg80211_ops, sizeof(*ops));
ifp = netdev_priv(ndev);
#ifdef CONFIG_PM
if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_WOWL_GTK))
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] brcmfmac: use kmemdup
2016-05-19 13:59 [PATCH] brcmfmac: use kmemdup Muhammad Falak R Wani
@ 2016-05-20 7:53 ` Arend Van Spriel
2016-06-14 14:27 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Arend Van Spriel @ 2016-05-20 7:53 UTC (permalink / raw)
To: Muhammad Falak R Wani, Kalle Valo
Cc: Brett Rudley, Arend van Spriel, Franky (Zhenhui) Lin,
Hante Meuleman, Pieter-Paul Giesberts, Rafał Miłecki,
linux-wireless, brcm80211-dev-list, netdev, linux-kernel
On 19-5-2016 15:59, Muhammad Falak R Wani wrote:
> Use kmemdup when some other buffer is immediately copied into allocated
> region. It replaces call to allocation followed by memcpy, by a single
> call to kmemdup.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index d0631b6..705adaa 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -6699,11 +6699,10 @@ struct brcmf_cfg80211_info *brcmf_cfg80211_attach(struct brcmf_pub *drvr,
> return NULL;
> }
>
> - ops = kzalloc(sizeof(*ops), GFP_KERNEL);
> + ops = kmemdup(&brcmf_cfg80211_ops, sizeof(*ops), GFP_KERNEL);
> if (!ops)
> return NULL;
>
> - memcpy(ops, &brcmf_cfg80211_ops, sizeof(*ops));
> ifp = netdev_priv(ndev);
> #ifdef CONFIG_PM
> if (brcmf_feat_is_enabled(ifp, BRCMF_FEAT_WOWL_GTK))
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: brcmfmac: use kmemdup
2016-05-19 13:59 [PATCH] brcmfmac: use kmemdup Muhammad Falak R Wani
2016-05-20 7:53 ` Arend Van Spriel
@ 2016-06-14 14:27 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2016-06-14 14:27 UTC (permalink / raw)
To: Muhammad Falak R Wani
Cc: Brett Rudley, Arend van Spriel, Franky (Zhenhui) Lin,
Hante Meuleman, Pieter-Paul Giesberts, Rafał Miłecki,
linux-wireless, brcm80211-dev-list, netdev, linux-kernel
Muhammad Falak R Wani <falakreyaz@gmail.com> wrote:
> Use kmemdup when some other buffer is immediately copied into allocated
> region. It replaces call to allocation followed by memcpy, by a single
> call to kmemdup.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Thanks, 1 patch applied to wireless-drivers-next.git:
d464fd8b48f3 brcmfmac: use kmemdup
--
Sent by pwcli
https://patchwork.kernel.org/patch/9127677/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-14 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-19 13:59 [PATCH] brcmfmac: use kmemdup Muhammad Falak R Wani
2016-05-20 7:53 ` Arend Van Spriel
2016-06-14 14:27 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).