* [PATCH 1/1] usbip: don't call stub_device_reset() during stub_disconnect()
@ 2016-05-20 9:37 Alexander Popov
2016-05-27 14:20 ` Alexander Popov
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Popov @ 2016-05-20 9:37 UTC (permalink / raw)
To: Valentina Manea, Shuah Khan, Greg Kroah-Hartman, linux-usb,
linux-kernel, Alexander Popov
stub_disconnect() calls stub_device_reset() during usb_unbind_device() when
usb device is locked. So usb_lock_device_for_reset() in stub_device_reset()
in that case polls for one second and returns -EBUSY anyway.
Remove useless flag USBIP_EH_RESET from SDEV_EVENT_REMOVED.
Signed-off-by: Alexander Popov <alpopov@ptsecurity.com>
---
drivers/usb/usbip/usbip_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/usbip/usbip_common.h b/drivers/usb/usbip/usbip_common.h
index 86b0847..c4b4938 100644
--- a/drivers/usb/usbip/usbip_common.h
+++ b/drivers/usb/usbip/usbip_common.h
@@ -242,7 +242,7 @@ enum usbip_side {
#define USBIP_EH_RESET (1 << 2)
#define USBIP_EH_UNUSABLE (1 << 3)
-#define SDEV_EVENT_REMOVED (USBIP_EH_SHUTDOWN | USBIP_EH_RESET | USBIP_EH_BYE)
+#define SDEV_EVENT_REMOVED (USBIP_EH_SHUTDOWN | USBIP_EH_BYE)
#define SDEV_EVENT_DOWN (USBIP_EH_SHUTDOWN | USBIP_EH_RESET)
#define SDEV_EVENT_ERROR_TCP (USBIP_EH_SHUTDOWN | USBIP_EH_RESET)
#define SDEV_EVENT_ERROR_SUBMIT (USBIP_EH_SHUTDOWN | USBIP_EH_RESET)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] usbip: don't call stub_device_reset() during stub_disconnect()
2016-05-20 9:37 [PATCH 1/1] usbip: don't call stub_device_reset() during stub_disconnect() Alexander Popov
@ 2016-05-27 14:20 ` Alexander Popov
2016-05-27 16:12 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Popov @ 2016-05-27 14:20 UTC (permalink / raw)
To: Valentina Manea, Shuah Khan, Greg Kroah-Hartman, linux-usb, linux-kernel
Cc: Alexander Popov
Hello,
Excuse me for disturbing, could I have a feedback?
On 20.05.2016 12:37, Alexander Popov wrote:
> stub_disconnect() calls stub_device_reset() during usb_unbind_device() when
> usb device is locked. So usb_lock_device_for_reset() in stub_device_reset()
> in that case polls for one second and returns -EBUSY anyway.
>
> Remove useless flag USBIP_EH_RESET from SDEV_EVENT_REMOVED.
>
> Signed-off-by: Alexander Popov <alpopov@ptsecurity.com>
> ---
> drivers/usb/usbip/usbip_common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/usbip_common.h b/drivers/usb/usbip/usbip_common.h
> index 86b0847..c4b4938 100644
> --- a/drivers/usb/usbip/usbip_common.h
> +++ b/drivers/usb/usbip/usbip_common.h
> @@ -242,7 +242,7 @@ enum usbip_side {
> #define USBIP_EH_RESET (1 << 2)
> #define USBIP_EH_UNUSABLE (1 << 3)
>
> -#define SDEV_EVENT_REMOVED (USBIP_EH_SHUTDOWN | USBIP_EH_RESET | USBIP_EH_BYE)
> +#define SDEV_EVENT_REMOVED (USBIP_EH_SHUTDOWN | USBIP_EH_BYE)
> #define SDEV_EVENT_DOWN (USBIP_EH_SHUTDOWN | USBIP_EH_RESET)
> #define SDEV_EVENT_ERROR_TCP (USBIP_EH_SHUTDOWN | USBIP_EH_RESET)
> #define SDEV_EVENT_ERROR_SUBMIT (USBIP_EH_SHUTDOWN | USBIP_EH_RESET)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] usbip: don't call stub_device_reset() during stub_disconnect()
2016-05-27 14:20 ` Alexander Popov
@ 2016-05-27 16:12 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2016-05-27 16:12 UTC (permalink / raw)
To: Alexander Popov; +Cc: Valentina Manea, Shuah Khan, linux-usb, linux-kernel
On Fri, May 27, 2016 at 05:20:45PM +0300, Alexander Popov wrote:
> Hello,
>
> Excuse me for disturbing, could I have a feedback?
Nope, it's the middle of the merge window, I can't do anything with new
patches until after 4.7-rc1 comes out. And even then, give me a week or
so to catch up...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-27 16:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-20 9:37 [PATCH 1/1] usbip: don't call stub_device_reset() during stub_disconnect() Alexander Popov
2016-05-27 14:20 ` Alexander Popov
2016-05-27 16:12 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).