From: Joe Perches <joe@perches.com>
To: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>,
tyreld@linux.vnet.ibm.com, bart.vanassche@sandisk.com
Cc: martin.petersen@oracle.com, akpm@linux-foundation.org,
kvalo@codeaurora.org, davem@davemloft.net,
mchehab@osg.samsung.com, jslaby@suse.com, bp@suse.de,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] ibmvscsis: clean up functions
Date: Wed, 25 May 2016 07:44:39 -0700 [thread overview]
Message-ID: <1464187479.16344.14.camel@perches.com> (raw)
In-Reply-To: <1464185854-19761-3-git-send-email-bryantly@linux.vnet.ibm.com>
On Wed, 2016-05-25 at 09:17 -0500, Bryant G. Ly wrote:
> From: bryantly <bryantly@linux.vnet.ibm.com>
Please use your whole name here and for your sign-off like:
From: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
> This patch removes forward declarations and re-organizes the
> functions within the driver. This patch also fixes MAINTAINERS
> for ibmvscsis.
trivial note:
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsis.c b/drivers/scsi/ibmvscsi/ibmvscsis.c
[]
> static inline long h_copy_rdma(s64 length, u64 sliobn, u64 slioba,
> u64 dliobn, u64 dlioba)
> {
>
Functions like this would be less indented and less
line wrapped for 80 columns if they were written:
if (!se_cmd->residual_count)
return;
[unindented one level...]
etc...
prev parent reply other threads:[~2016-05-25 14:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 13:52 [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver Bryant G. Ly
2016-05-24 14:14 ` Joe Perches
2016-05-24 14:30 ` Greg KH
2016-05-24 16:25 ` Bart Van Assche
2016-05-24 16:34 ` Greg KH
2016-05-24 16:44 ` Bart Van Assche
2016-05-24 16:50 ` Greg KH
2016-05-24 20:00 ` Bryant G Ly
2016-06-10 19:03 ` Bart Van Assche
2016-06-14 6:23 ` Nicholas A. Bellinger
2016-06-14 14:55 ` Christoph Hellwig
2016-05-25 14:17 ` IBM VSCSI Target Driver Initial Patch Sets Bryant G. Ly
2016-05-25 14:17 ` [PATCH 2/3] ibmvscsis: Addressing Bart's comments Bryant G. Ly
2016-05-25 14:17 ` [PATCH 3/3] ibmvscsis: clean up functions Bryant G. Ly
2016-05-25 14:44 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464187479.16344.14.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=bart.vanassche@sandisk.com \
--cc=bp@suse.de \
--cc=bryantly@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=jslaby@suse.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchehab@osg.samsung.com \
--cc=target-devel@vger.kernel.org \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).