From: chunfeng yun <chunfeng.yun@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Alan Stern <stern@rowland.harvard.edu>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Pawel Moll <pawel.moll@arm.com>,
Kumar Gala <galak@codeaurora.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
<linux-usb@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2,3/5] dt-bindings: mtu3: add devicetree bindings
Date: Sun, 5 Jun 2016 17:33:32 +0800 [thread overview]
Message-ID: <1465119212.11651.141.camel@mhfsdcap03> (raw)
In-Reply-To: <5751874C.9070100@gmail.com>
On Fri, 2016-06-03 at 15:34 +0200, Matthias Brugger wrote:
>
> On 31/05/16 07:52, Chunfeng Yun wrote:
> > add a DT binding doc for MediaTek USB3 DRD driver
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > Documentation/devicetree/bindings/usb/mtu3.txt | 85 ++++++++++++++++++++++++
> > 1 file changed, 85 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/usb/mtu3.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mtu3.txt b/Documentation/devicetree/bindings/usb/mtu3.txt
> > new file mode 100644
> > index 0000000..571ae8b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/mtu3.txt
>
> The file should be called mt8173-mtu3.txt to be in line with mt8173-xhci.txt
> Ok, I will rename it
>
> > @@ -0,0 +1,85 @@
> > +The device node for Mediatek USB3.0 DRD controller
> > +
> > +Required properties:
> > + - compatible : should be "mediatek,mt8173-mtu3"
> > + - reg : specifies physical base address and size of the registers
> > + - reg-names: should be "mac" for device IP and "ippc" for IP port control
> > + - interrupts : interrupt used by the device IP
> > + - power-domains : a phandle to USB power domain node to control USB's
> > + mtcmos
> > + - vusb33-supply : regulator of USB avdd3.3v
> > + - clocks : a list of phandle + clock-specifier pairs, one for each
> > + entry in clock-names
> > + - clock-names : must contain "sys_ck" for clock of controller;
> > + "wakeup_deb_p0" and "wakeup_deb_p1" are optional, they are
> > + depends on "mediatek,enable-wakeup"
> > + - phys : a list of phandle + phy specifier pairs
> > + - dr_mode : should be one of "host", "peripheral" or "otg",
> > + refer to usb/generic.txt
> > +
> > +Optional properties:
> > + - #address-cells, #size-cells : should be '2' if the device has sub-nodes
> > + with 'reg' property
> > + - ranges : allows valid 1:1 translation between child's address space and
> > + parent's address space
> > + - extcon : external connector for vbus and idpin changes detection, needed
> > + when supports dual-role mode.
> > + - vbus-supply : reference to the VBUS regulator, needed when supports
> > + dual-role mode.
> > + - pinctl-names : a pinctrl state named "default" must be defined,
> > + "id_float" and "id_ground" are optinal which depends on
> > + "mediatek,enable-manual-drd"
>
> So pinctrl is optional, but if you put it, you need at least "default"?
Yes, the first one is "default".
>
> Apart from that, DT maintainers prefer to have the binding patches at
> the beginning of a series, so it's easier for them to not oversee any.
> Ok.
Thanks a lot.
> Regards,
> Matthias
next prev parent reply other threads:[~2016-06-05 9:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 5:52 Add MediaTek USB3 DRD Driver Chunfeng Yun
2016-05-31 5:52 ` [PATCH v2,1/5] dt-bindings: mt8173-xhci: support host side of dual-role mode Chunfeng Yun
2016-05-31 11:07 ` Sergei Shtylyov
2016-06-01 12:04 ` chunfeng yun
2016-05-31 5:52 ` [PATCH v2,2/5] usb: xhci-mtk: make IPPC register optional Chunfeng Yun
2016-05-31 5:52 ` [PATCH v2,3/5] dt-bindings: mtu3: add devicetree bindings Chunfeng Yun
2016-06-03 13:34 ` Matthias Brugger
2016-06-05 9:33 ` chunfeng yun [this message]
2016-05-31 5:52 ` [PATCH v2,4/5] usb: Add MediaTek USB3 DRD Driver Chunfeng Yun
2016-05-31 5:52 ` [PATCH v2,5/5] arm64: dts: mediatek: add USB3 DRD driver Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465119212.11651.141.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).