* [PATCH] kbuild: setlocalversion: print error to STDERR
@ 2016-06-06 19:00 Wolfram Sang
2016-06-20 15:38 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2016-06-06 19:00 UTC (permalink / raw)
To: linux-kbuild; +Cc: linux-kernel, Michal Marek, Wolfram Sang
I tried to use 'make O=...' from an unclean source tree. This triggered
the error path of setlocalversion. But by printing to STDOUT, it created
a broken localversion which then caused another (unrelated) error:
"4.7.0-rc2Error: kernelrelease not valid - run make prepare to update it" exceeds 64 characters
After printing to STDERR, the true build error gets displayed later:
/home/wsa/Kernel/linux is not clean, please run 'make mrproper'
in the '/home/wsa/Kernel/linux' directory.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
scripts/setlocalversion | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/setlocalversion b/scripts/setlocalversion
index 63d91e22ed7ccd..966dd3924ea9cb 100755
--- a/scripts/setlocalversion
+++ b/scripts/setlocalversion
@@ -143,7 +143,7 @@ fi
if test -e include/config/auto.conf; then
. include/config/auto.conf
else
- echo "Error: kernelrelease not valid - run 'make prepare' to update it"
+ echo "Error: kernelrelease not valid - run 'make prepare' to update it" >&2
exit 1
fi
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kbuild: setlocalversion: print error to STDERR
2016-06-06 19:00 [PATCH] kbuild: setlocalversion: print error to STDERR Wolfram Sang
@ 2016-06-20 15:38 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2016-06-20 15:38 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-kbuild, linux-kernel
On Mon, Jun 06, 2016 at 09:00:38PM +0200, Wolfram Sang wrote:
> I tried to use 'make O=...' from an unclean source tree. This triggered
> the error path of setlocalversion. But by printing to STDOUT, it created
> a broken localversion which then caused another (unrelated) error:
>
> "4.7.0-rc2Error: kernelrelease not valid - run make prepare to update it" exceeds 64 characters
>
> After printing to STDERR, the true build error gets displayed later:
>
> /home/wsa/Kernel/linux is not clean, please run 'make mrproper'
> in the '/home/wsa/Kernel/linux' directory.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> scripts/setlocalversion | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to kbuild.git#kbuild. But this points at another
problem, namely that filechk is ignoring the exit status of the command.
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-20 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-06 19:00 [PATCH] kbuild: setlocalversion: print error to STDERR Wolfram Sang
2016-06-20 15:38 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).