From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
<linux-gpio@vger.kernel.org>
Subject: [PATCH 6/9] pinctrl: palmas: make it explicitly non-modular
Date: Mon, 6 Jun 2016 22:43:05 -0400 [thread overview]
Message-ID: <1465267388-17884-7-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1465267388-17884-1-git-send-email-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
config PINCTRL_PALMAS
bool "Pinctrl driver for the PALMAS Series MFD devices"
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.
We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.
Cc: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/pinctrl/pinctrl-palmas.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-palmas.c b/drivers/pinctrl/pinctrl-palmas.c
index 8edb3f8c72c8..3def8805a882 100644
--- a/drivers/pinctrl/pinctrl-palmas.c
+++ b/drivers/pinctrl/pinctrl-palmas.c
@@ -21,7 +21,7 @@
*/
#include <linux/delay.h>
-#include <linux/module.h>
+#include <linux/init.h>
#include <linux/mfd/palmas.h>
#include <linux/of.h>
#include <linux/of_device.h>
@@ -1059,10 +1059,4 @@ static struct platform_driver palmas_pinctrl_driver = {
},
.probe = palmas_pinctrl_probe,
};
-
-module_platform_driver(palmas_pinctrl_driver);
-
-MODULE_DESCRIPTION("Palmas pin control driver");
-MODULE_AUTHOR("Laxman Dewangan<ldewangan@nvidia.com>");
-MODULE_ALIAS("platform:palmas-pinctrl");
-MODULE_LICENSE("GPL v2");
+builtin_platform_driver(palmas_pinctrl_driver);
--
2.8.0
next prev parent reply other threads:[~2016-06-07 2:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 2:42 [PATCH 0/9] pinctrl: make non-modular drivers really non modular Paul Gortmaker
2016-06-07 2:43 ` [PATCH 1/9] pinctrl: as3722: make it explicitly non-modular Paul Gortmaker
2016-06-07 6:36 ` Laxman Dewangan
2016-06-07 2:43 ` [PATCH 2/9] pinctrl: baytrail: " Paul Gortmaker
2016-06-09 14:10 ` Mika Westerberg
2016-06-13 6:26 ` Linus Walleij
2016-06-07 2:43 ` [PATCH 3/9] pinctrl: at91: " Paul Gortmaker
2016-06-13 6:27 ` Linus Walleij
2016-06-07 2:43 ` [PATCH 4/9] pinctrl: lpc18xx: " Paul Gortmaker
2016-06-13 6:28 ` Linus Walleij
2016-06-07 2:43 ` [PATCH 5/9] pinctrl: amd: " Paul Gortmaker
2016-06-13 6:29 ` Linus Walleij
2016-06-07 2:43 ` Paul Gortmaker [this message]
2016-06-07 6:36 ` [PATCH 6/9] pinctrl: palmas: " Laxman Dewangan
2016-06-07 2:43 ` [PATCH 7/9] pinctrl: zynq: " Paul Gortmaker
2016-06-07 2:54 ` Sören Brinkmann
2016-06-07 7:15 ` Michal Simek
2016-06-07 2:43 ` [PATCH 8/9] pinctrl: digicolor: " Paul Gortmaker
2016-06-07 6:13 ` Baruch Siach
2016-06-13 6:34 ` Linus Walleij
2016-06-13 6:33 ` Linus Walleij
2016-06-07 2:43 ` [PATCH 9/9] pinctrl: at91-pio4: " Paul Gortmaker
2016-06-08 6:27 ` Ludovic Desroches
2016-06-13 6:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465267388-17884-7-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).