From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 2/9] pinctrl: baytrail: make it explicitly non-modular
Date: Thu, 9 Jun 2016 17:10:57 +0300 [thread overview]
Message-ID: <20160609141057.GM1791@lahna.fi.intel.com> (raw)
In-Reply-To: <1465267388-17884-3-git-send-email-paul.gortmaker@windriver.com>
On Mon, Jun 06, 2016 at 10:43:01PM -0400, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> config PINCTRL_BAYTRAIL
> bool "Intel Baytrail GPIO pin control"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We explicitly disallow a driver unbind, since that doesn't have a
> sensible use case anyway, and it allows us to drop the ".remove"
> code for non-modular drivers.
>
> Since module_init() was already not in use in this driver, we don't
> have any concerns with init ordering changes here.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Yeah, probably good thing to do. No objections from me.
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2016-06-09 14:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 2:42 [PATCH 0/9] pinctrl: make non-modular drivers really non modular Paul Gortmaker
2016-06-07 2:43 ` [PATCH 1/9] pinctrl: as3722: make it explicitly non-modular Paul Gortmaker
2016-06-07 6:36 ` Laxman Dewangan
2016-06-07 2:43 ` [PATCH 2/9] pinctrl: baytrail: " Paul Gortmaker
2016-06-09 14:10 ` Mika Westerberg [this message]
2016-06-13 6:26 ` Linus Walleij
2016-06-07 2:43 ` [PATCH 3/9] pinctrl: at91: " Paul Gortmaker
2016-06-13 6:27 ` Linus Walleij
2016-06-07 2:43 ` [PATCH 4/9] pinctrl: lpc18xx: " Paul Gortmaker
2016-06-13 6:28 ` Linus Walleij
2016-06-07 2:43 ` [PATCH 5/9] pinctrl: amd: " Paul Gortmaker
2016-06-13 6:29 ` Linus Walleij
2016-06-07 2:43 ` [PATCH 6/9] pinctrl: palmas: " Paul Gortmaker
2016-06-07 6:36 ` Laxman Dewangan
2016-06-07 2:43 ` [PATCH 7/9] pinctrl: zynq: " Paul Gortmaker
2016-06-07 2:54 ` Sören Brinkmann
2016-06-07 7:15 ` Michal Simek
2016-06-07 2:43 ` [PATCH 8/9] pinctrl: digicolor: " Paul Gortmaker
2016-06-07 6:13 ` Baruch Siach
2016-06-13 6:34 ` Linus Walleij
2016-06-13 6:33 ` Linus Walleij
2016-06-07 2:43 ` [PATCH 9/9] pinctrl: at91-pio4: " Paul Gortmaker
2016-06-08 6:27 ` Ludovic Desroches
2016-06-13 6:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609141057.GM1791@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).